Docker/Maybe
Docker/Maybe
1
0
Fork 0
mirror of https://github.com/maybe-finance/maybe.git synced 2025-07-30 10:39:40 +02:00
Code Issues Releases Activity Actions

Temporary disable of sync cascade behavior

Browse source
This commit is contained in:
Zach Gollwitzer 2025-05-12 15:41:14 -04:00
parent a268c5a563
commit 908b3e2489
2 changed files with 4 additions and 85 deletions
Download patch file Download diff file Expand all files Collapse all files

41
app/models/sync.rb
View file

@ -21,58 +21,17 @@ class Sync < ApplicationRecord
begin begin
syncable.sync_data(self, start_date: start_date) syncable.sync_data(self, start_date: start_date)
unless has_pending_child_syncs?
complete! complete!
Rails.logger.info("Sync completed, starting post-sync") Rails.logger.info("Sync completed, starting post-sync")
syncable.post_sync(self) syncable.post_sync(self)
Rails.logger.info("Post-sync completed") Rails.logger.info("Post-sync completed")
end
rescue StandardError => error rescue StandardError => error
fail! error, report_error: true fail! error, report_error: true
ensure
notify_parent_of_completion! if has_parent?
end
end
end
def handle_child_completion_event
Sync.transaction do
# We need this to ensure 2 child syncs don't update the parent at the exact same time with different results
# and cause the sync to hang in "syncing" status indefinitely
self.lock!
unless has_pending_child_syncs?
if has_failed_child_syncs?
fail!(Error.new("One or more child syncs failed"))
else
complete!
end
# If this sync is both a child and a parent, we need to notify the parent of completion
notify_parent_of_completion! if has_parent?
syncable.post_sync(self)
end end
end end
end end
private private
def has_pending_child_syncs?
children.where(status: [ :pending, :syncing ]).any?
end
def has_failed_child_syncs?
children.where(status: :failed).any?
end
def has_parent?
parent_id.present?
end
def notify_parent_of_completion!
parent.handle_child_completion_event
end
def start! def start!
Rails.logger.info("Starting sync") Rails.logger.info("Starting sync")
update! status: :syncing update! status: :syncing

40
test/models/sync_test.rb
View file

@ -31,44 +31,4 @@ class SyncTest < ActiveSupport::TestCase
assert_equal "failed", @sync.status assert_equal "failed", @sync.status
assert_equal "test sync error", @sync.error assert_equal "test sync error", @sync.error
end end
# Order is important here. Parent syncs must implement sync_data so that their own work
# is 100% complete *prior* to queueing up child syncs.
test "runs sync with child syncs" do
family = families(:dylan_family)
parent = Sync.create!(syncable: family)
child1 = Sync.create!(syncable: family.accounts.first, parent: parent)
child2 = Sync.create!(syncable: family.accounts.second, parent: parent)
grandchild = Sync.create!(syncable: family.accounts.last, parent: child2)
parent.syncable.expects(:sync_data).returns([]).once
child1.syncable.expects(:sync_data).returns([]).once
child2.syncable.expects(:sync_data).returns([]).once
grandchild.syncable.expects(:sync_data).returns([]).once
assert_equal "pending", parent.status
assert_equal "pending", child1.status
assert_equal "pending", child2.status
assert_equal "pending", grandchild.status
parent.perform
assert_equal "syncing", parent.reload.status
child1.perform
assert_equal "completed", child1.reload.status
assert_equal "syncing", parent.reload.status
child2.perform
assert_equal "syncing", child2.reload.status
assert_equal "completed", child1.reload.status
assert_equal "syncing", parent.reload.status
# Will complete the parent and grandparent syncs
grandchild.perform
assert_equal "completed", grandchild.reload.status
assert_equal "completed", child1.reload.status
assert_equal "completed", child2.reload.status
assert_equal "completed", parent.reload.status
end
end end