Add backend support for transaction categories (#524)

* Add backend support for transaction categories

* Fix tests

* Localize default category names

* Add tests

* Remove category icon and set default color

test/controllers/registrations_controller_test.rb

@@ -6,7 +6,7 @@ class RegistrationsControllerTest < ActionDispatch::IntegrationTest
     assert_response :success
   end
 
-  test "create" do
+  test "create redirects to correct URL" do
     post registration_url, params: { user: {
       email: "john@example.com",
       password: "password",
@@ -15,6 +15,15 @@ class RegistrationsControllerTest < ActionDispatch::IntegrationTest
     assert_redirected_to root_url
   end
 
+  test "create seeds default transaction categories" do
+    assert_difference "Transaction::Category.count", Transaction::Category::DEFAULT_CATEGORIES.size do
+      post registration_url, params: { user: {
+      email: "john@example.com",
+      password: "password",
+      password_confirmation: "password" } }
+    end
+  end
+
   test "create when hosted requires an invite code" do
     in_hosted_app do
       assert_no_difference "User.count" do

test/fixtures/transaction/categories.yml

@@ -0,0 +1,10 @@
+income:
+  name: Income
+  internal_category: income
+  color: "#fd7f6f"
+  family: dylan_family
+
+food_and_drink:
+  name: Food & Drink
+  internal_category: food_and_drink
+  family: dylan_family

test/fixtures/transactions.yml

@@ -4,12 +4,14 @@ checking_one:
   date: <%= 5.days.ago.to_date %>
   amount: 10
   account: checking
+  category: food_and_drink
 
 checking_two:
   name: Chipotle
   date: <%= 12.days.ago.to_date %>
   amount: 30
   account: checking
+  category: food_and_drink
 
 checking_three:
   name: Amazon
@@ -22,6 +24,7 @@ checking_four:
   date: <%= 22.days.ago.to_date %>
   amount: -1075
   account: checking
+  category: income
 
 checking_five:
   name: Netflix
@@ -35,12 +38,14 @@ savings_one:
   date: <%= 5.days.ago.to_date %>
   amount: -200
   account: savings_with_valuation_overrides
+  category: income
 
 savings_two:
   name: Check Deposit
   date: <%= 12.days.ago.to_date %>
   amount: -50
   account: savings_with_valuation_overrides
+  category: income
 
 savings_three:
   name: Withdrawal
@@ -53,6 +58,7 @@ savings_four:
   date: <%= 29.days.ago.to_date %>
   amount: -500
   account: savings_with_valuation_overrides
+  category: income
 
 # Credit card account transactions
 credit_card_one:
@@ -60,12 +66,14 @@ credit_card_one:
   date: <%= 5.days.ago.to_date %>
   amount: 10
   account: credit_card
+  category: food_and_drink
 
 credit_card_two:
   name: Chipotle
   date: <%= 12.days.ago.to_date %>
   amount: 30
   account: credit_card
+  category: food_and_drink
 
 credit_card_three:
   name: Amazon

test/models/family_test.rb

@@ -30,6 +30,12 @@ class FamilyTest < ActiveSupport::TestCase
     end
   end
 
+  test "should destroy dependent transaction categories" do
+    assert_difference("Transaction::Category.count", -@family.transaction_categories.count) do
+      @family.destroy
+    end
+  end
+
   test "should calculate total assets" do
     assert_equal BigDecimal("25550"), @family.assets
   end

test/models/transaction/category_test.rb

@@ -0,0 +1,35 @@
+require "test_helper"
+
+class Transaction::CategoryTest < ActiveSupport::TestCase
+  def setup
+    @family = families(:dylan_family)
+  end
+
+  test "create_default_categories should generate categories if none exist" do
+    @family.accounts.destroy_all
+    @family.transaction_categories.destroy_all
+    assert_difference "Transaction::Category.count", Transaction::Category::DEFAULT_CATEGORIES.size do
+      Transaction::Category.create_default_categories(@family)
+    end
+  end
+
+  test "create_default_categories should raise when there are existing categories" do
+    assert_raises(ArgumentError) do
+      Transaction::Category.create_default_categories(@family)
+    end
+  end
+
+  test "updating name should clear the internal_category field" do
+    category = Transaction::Category.take
+    assert_changes "category.reload.internal_category", to: nil do
+      category.update_attribute(:name, "new name")
+    end
+  end
+
+  test "updating other field than name should not clear the internal_category field" do
+    category = Transaction::Category.take
+    assert_no_changes "category.reload.internal_category" do
+      category.update_attribute(:color, "#000")
+    end
+  end
+end