1
0
Fork 0
mirror of https://github.com/maybe-finance/maybe.git synced 2025-08-02 20:15:22 +02:00

Dashboard empty view (#707)

* Added i18n for the Dashboard page.

* Add a check for blank. Empty returned an error since @accounts was nil.

* Remove subtitle when accounts are empty..

* Increased the padding-right value for the buttons. The sapce occupied by the icon made the button elements unbalanced.

* Add refactor as suggested by Zach (https://github.com/maybe-finance/maybe/pull/707#discussion_r1588506443)

* Extract empty state into a partial.

* Render new partial if no accounts exist.

* Moved translation text to shared directory.

* Fix padding-right on New account button.

* Lint fix

* i18n tasks

* Get tests passing with :test queue adapter

---------

Co-authored-by: Zach Gollwitzer <zach.gollwitzer@gmail.com>
This commit is contained in:
Claude Ayitey 2024-05-03 12:11:31 +00:00 committed by GitHub
parent 75cdddc6ca
commit 9563ac6334
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
9 changed files with 101 additions and 71 deletions

View file

@ -52,6 +52,8 @@ Rails.application.configure do
# Tell Active Support which deprecation messages to disallow.
config.active_support.disallowed_deprecation_warnings = []
config.active_job.queue_adapter = :test
# Raises error for missing translations.
# config.i18n.raise_on_missing_translations = true

View file

@ -6,6 +6,11 @@ en:
body_html: "<p>You will not be able to undo this decision</p>"
cancel: Cancel
title: Are you sure?
no_account_empty_state:
new_account: New account
no_account_subtitle: Since no accounts have been added, there's no data to display.
Add your first accounts to start viewing dashboard data.
no_account_title: No accounts yet
notification:
dismiss: Dismiss
upgrade_notification: