Add breadcrumbs support across application (#1897)

* Add breadcrumbs support across application

Fixes #1896

* Potential fix for tests

* Simplify breadcrumbs implementation

Remove complex breadcrumbs logic from controllers and concern, replacing with a simpler default approach that sets a basic breadcrumb based on the current controller name

* Refactor page header and breadcrumbs rendering

Remove complex breadcrumbs helper method and update layout to use more flexible content_for approach for page headers and breadcrumbs

* Add fallback breadcrumbs rendering to settings layout

app/controllers/application_controller.rb

@@ -1,5 +1,5 @@
 class ApplicationController < ActionController::Base
-  include Onboardable, Localize, AutoSync, Authentication, Invitable, SelfHostable, StoreLocation, Impersonatable
+  include Onboardable, Localize, AutoSync, Authentication, Invitable, SelfHostable, StoreLocation, Impersonatable, Breadcrumbable
   include Pagy::Backend
 
   helper_method :require_upgrade?, :subscription_pending?

app/controllers/budgets_controller.rb

@@ -25,6 +25,7 @@ class BudgetsController < ApplicationController
   end
 
   private
+
     def budget_create_params
       params.require(:budget).permit(:start_date)
     end

app/controllers/concerns/breadcrumbable.rb

@@ -0,0 +1,13 @@
+module Breadcrumbable
+  extend ActiveSupport::Concern
+
+  included do
+    before_action :set_breadcrumbs
+  end
+
+  private
+    # The default, unless specific controller or action explicitly overrides
+    def set_breadcrumbs
+      @breadcrumbs = [ [ "Home", root_path ], [ controller_name.titleize, nil ] ]
+    end
+end

app/controllers/pages_controller.rb

@@ -5,6 +5,8 @@ class PagesController < ApplicationController
     @period = Period.from_key(params[:period], fallback: true)
     @balance_sheet = Current.family.balance_sheet
     @accounts = Current.family.accounts.active.with_attached_logo
+
+    @breadcrumbs = [ [ "Home", root_path ], [ "Dashboard", nil ] ]
   end
 
   def changelog

app/controllers/transactions_controller.rb

@@ -49,6 +49,7 @@ class TransactionsController < ApplicationController
   end
 
   private
+
     def search_params
       cleaned_params = params.fetch(:q, {})
             .permit(