mirror of
https://github.com/maybe-finance/maybe.git
synced 2025-07-24 23:59:40 +02:00
Add partial account sync support (#653)
* Add partial account sync support * Fix indentation * Use historical balance as base when doing partial sync * Simplify controller crud tests * Fix linter errors
This commit is contained in:
Jakub Kottnauer
GitHub
parent
b3f8ab78d9
commit
ad4de99f1a
9 changed files with 260 additions and 111 deletions
|
|
@ -2,97 +2,111 @@ require "test_helper"
|
|||
require "csv"
|
||||
|
||||
class Account::Balance::CalculatorTest < ActiveSupport::TestCase
|
||||
# See: https://docs.google.com/spreadsheets/d/18LN5N-VLq4b49Mq1fNwF7_eBiHSQB46qQduRtdAEN98/edit?usp=sharing
|
||||
setup do
|
||||
@expected_balances = CSV.read("test/fixtures/account/expected_balances.csv", headers: true).map do |row|
|
||||
{
|
||||
"date" => (Date.current + row["date_offset"].to_i.days).to_date,
|
||||
"collectable" => row["collectable"],
|
||||
"checking" => row["checking"],
|
||||
"savings_with_valuation_overrides" => row["savings_with_valuation_overrides"],
|
||||
"credit_card" => row["credit_card"],
|
||||
"multi_currency" => row["multi_currency"],
|
||||
# See: https://docs.google.com/spreadsheets/d/18LN5N-VLq4b49Mq1fNwF7_eBiHSQB46qQduRtdAEN98/edit?usp=sharing
|
||||
setup do
|
||||
@expected_balances = CSV.read("test/fixtures/account/expected_balances.csv", headers: true).map do |row|
|
||||
{
|
||||
"date" => (Date.current + row["date_offset"].to_i.days).to_date,
|
||||
"collectable" => row["collectable"],
|
||||
"checking" => row["checking"],
|
||||
"savings_with_valuation_overrides" => row["savings_with_valuation_overrides"],
|
||||
"credit_card" => row["credit_card"],
|
||||
"multi_currency" => row["multi_currency"],
|
||||
|
||||
# Balances should be calculated for all currencies of an account
|
||||
"eur_checking_eur" => row["eur_checking_eur"],
|
||||
"eur_checking_usd" => row["eur_checking_usd"]
|
||||
}
|
||||
end
|
||||
# Balances should be calculated for all currencies of an account
|
||||
"eur_checking_eur" => row["eur_checking_eur"],
|
||||
"eur_checking_usd" => row["eur_checking_usd"]
|
||||
}
|
||||
end
|
||||
end
|
||||
|
||||
test "syncs account with only valuations" do
|
||||
account = accounts(:collectable)
|
||||
test "syncs account with only valuations" do
|
||||
account = accounts(:collectable)
|
||||
|
||||
calculator = Account::Balance::Calculator.new(account)
|
||||
calculator.calculate
|
||||
calculator = Account::Balance::Calculator.new(account)
|
||||
calculator.calculate
|
||||
|
||||
expected = @expected_balances.map { |row| row["collectable"].to_d }
|
||||
actual = calculator.daily_balances.map { |b| b[:balance] }
|
||||
expected = @expected_balances.map { |row| row["collectable"].to_d }
|
||||
actual = calculator.daily_balances.map { |b| b[:balance] }
|
||||
|
||||
assert_equal expected, actual
|
||||
end
|
||||
assert_equal expected, actual
|
||||
end
|
||||
|
||||
test "syncs account with only transactions" do
|
||||
account = accounts(:checking)
|
||||
test "syncs account with only transactions" do
|
||||
account = accounts(:checking)
|
||||
|
||||
calculator = Account::Balance::Calculator.new(account)
|
||||
calculator.calculate
|
||||
calculator = Account::Balance::Calculator.new(account)
|
||||
calculator.calculate
|
||||
|
||||
expected = @expected_balances.map { |row| row["checking"].to_d }
|
||||
actual = calculator.daily_balances.map { |b| b[:balance] }
|
||||
expected = @expected_balances.map { |row| row["checking"].to_d }
|
||||
actual = calculator.daily_balances.map { |b| b[:balance] }
|
||||
|
||||
assert_equal expected, actual
|
||||
end
|
||||
assert_equal expected, actual
|
||||
end
|
||||
|
||||
test "syncs account with both valuations and transactions" do
|
||||
account = accounts(:savings_with_valuation_overrides)
|
||||
test "syncs account with both valuations and transactions" do
|
||||
account = accounts(:savings_with_valuation_overrides)
|
||||
|
||||
calculator = Account::Balance::Calculator.new(account)
|
||||
calculator.calculate
|
||||
calculator = Account::Balance::Calculator.new(account)
|
||||
calculator.calculate
|
||||
|
||||
expected = @expected_balances.map { |row| row["savings_with_valuation_overrides"].to_d }
|
||||
actual = calculator.daily_balances.map { |b| b[:balance] }
|
||||
expected = @expected_balances.map { |row| row["savings_with_valuation_overrides"].to_d }
|
||||
actual = calculator.daily_balances.map { |b| b[:balance] }
|
||||
|
||||
assert_equal expected, actual
|
||||
end
|
||||
assert_equal expected, actual
|
||||
end
|
||||
|
||||
test "syncs liability account" do
|
||||
account = accounts(:credit_card)
|
||||
test "syncs liability account" do
|
||||
account = accounts(:credit_card)
|
||||
|
||||
calculator = Account::Balance::Calculator.new(account)
|
||||
calculator.calculate
|
||||
calculator = Account::Balance::Calculator.new(account)
|
||||
calculator.calculate
|
||||
|
||||
expected = @expected_balances.map { |row| row["credit_card"].to_d }
|
||||
actual = calculator.daily_balances.map { |b| b[:balance] }
|
||||
expected = @expected_balances.map { |row| row["credit_card"].to_d }
|
||||
actual = calculator.daily_balances.map { |b| b[:balance] }
|
||||
|
||||
assert_equal expected, actual
|
||||
end
|
||||
assert_equal expected, actual
|
||||
end
|
||||
|
||||
test "syncs foreign currency account" do
|
||||
account = accounts(:eur_checking)
|
||||
calculator = Account::Balance::Calculator.new(account)
|
||||
calculator.calculate
|
||||
test "syncs foreign currency account" do
|
||||
account = accounts(:eur_checking)
|
||||
calculator = Account::Balance::Calculator.new(account)
|
||||
calculator.calculate
|
||||
|
||||
# Calculator should calculate balances in both account and family currency
|
||||
expected_eur_balances = @expected_balances.map { |row| row["eur_checking_eur"].to_d }
|
||||
expected_usd_balances = @expected_balances.map { |row| row["eur_checking_usd"].to_d }
|
||||
# Calculator should calculate balances in both account and family currency
|
||||
expected_eur_balances = @expected_balances.map { |row| row["eur_checking_eur"].to_d }
|
||||
expected_usd_balances = @expected_balances.map { |row| row["eur_checking_usd"].to_d }
|
||||
|
||||
actual_eur_balances = calculator.daily_balances.select { |b| b[:currency] == "EUR" }.sort_by { |b| b[:date] }.map { |b| b[:balance] }
|
||||
actual_usd_balances = calculator.daily_balances.select { |b| b[:currency] == "USD" }.sort_by { |b| b[:date] }.map { |b| b[:balance] }
|
||||
actual_eur_balances = calculator.daily_balances.select { |b| b[:currency] == "EUR" }.sort_by { |b| b[:date] }.map { |b| b[:balance] }
|
||||
actual_usd_balances = calculator.daily_balances.select { |b| b[:currency] == "USD" }.sort_by { |b| b[:date] }.map { |b| b[:balance] }
|
||||
|
||||
assert_equal expected_eur_balances, actual_eur_balances
|
||||
assert_equal expected_usd_balances, actual_usd_balances
|
||||
end
|
||||
assert_equal expected_eur_balances, actual_eur_balances
|
||||
assert_equal expected_usd_balances, actual_usd_balances
|
||||
end
|
||||
|
||||
test "syncs multi currency account" do
|
||||
account = accounts(:multi_currency)
|
||||
calculator = Account::Balance::Calculator.new(account)
|
||||
calculator.calculate
|
||||
test "syncs multi currency account" do
|
||||
account = accounts(:multi_currency)
|
||||
calculator = Account::Balance::Calculator.new(account)
|
||||
calculator.calculate
|
||||
|
||||
expected_balances = @expected_balances.map { |row| row["multi_currency"].to_d }
|
||||
expected_balances = @expected_balances.map { |row| row["multi_currency"].to_d }
|
||||
|
||||
actual_balances = calculator.daily_balances.map { |b| b[:balance] }
|
||||
actual_balances = calculator.daily_balances.map { |b| b[:balance] }
|
||||
|
||||
assert_equal expected_balances, actual_balances
|
||||
end
|
||||
assert_equal expected_balances, actual_balances
|
||||
end
|
||||
|
||||
test "syncs with overridden start date" do
|
||||
account = accounts(:multi_currency)
|
||||
account.sync
|
||||
calc_start_date = 10.days.ago.to_date
|
||||
calculator = Account::Balance::Calculator.new(account, { calc_start_date: })
|
||||
calculator.calculate
|
||||
|
||||
expected_balances = @expected_balances.filter { |row| row["date"] >= calc_start_date }.map { |row| row["multi_currency"].to_d }
|
||||
|
||||
actual_balances = calculator.daily_balances.map { |b| b[:balance] }
|
||||
|
||||
assert_equal expected_balances, actual_balances
|
||||
end
|
||||
end
|
||||
|
|
|
|||
|
|
@ -1,38 +1,81 @@
|
|||
require "test_helper"
|
||||
|
||||
class Account::SyncableTest < ActiveSupport::TestCase
|
||||
test "account has no balances until synced" do
|
||||
account = accounts(:savings_with_valuation_overrides)
|
||||
test "account has no balances until synced" do
|
||||
account = accounts(:savings_with_valuation_overrides)
|
||||
|
||||
assert_equal 0, account.balances.count
|
||||
end
|
||||
assert_equal 0, account.balances.count
|
||||
end
|
||||
|
||||
test "account has balances after syncing" do
|
||||
account = accounts(:savings_with_valuation_overrides)
|
||||
account.sync
|
||||
test "account has balances after syncing" do
|
||||
account = accounts(:savings_with_valuation_overrides)
|
||||
account.sync
|
||||
|
||||
assert_equal 31, account.balances.count
|
||||
end
|
||||
assert_equal 31, account.balances.count
|
||||
end
|
||||
|
||||
test "foreign currency account has balances in each currency after syncing" do
|
||||
account = accounts(:eur_checking)
|
||||
account.sync
|
||||
test "partial sync with missing historical balances performs a full sync" do
|
||||
account = accounts(:savings_with_valuation_overrides)
|
||||
account.sync 10.days.ago.to_date
|
||||
|
||||
assert_equal 62, account.balances.count
|
||||
assert_equal 31, account.balances.where(currency: "EUR").count
|
||||
assert_equal 31, account.balances.where(currency: "USD").count
|
||||
end
|
||||
assert_equal 31, account.balances.count
|
||||
end
|
||||
|
||||
test "stale balances are purged after syncing" do
|
||||
account = accounts(:savings_with_valuation_overrides)
|
||||
test "balances are updated after syncing" do
|
||||
account = accounts(:savings_with_valuation_overrides)
|
||||
balance_date = 10.days.ago
|
||||
account.balances.create!(date: balance_date, balance: 1000)
|
||||
account.sync
|
||||
|
||||
# Create old, stale balances that should be purged (since they are before account start date)
|
||||
account.balances.create!(date: 1.year.ago, balance: 1000)
|
||||
account.balances.create!(date: 2.years.ago, balance: 2000)
|
||||
account.balances.create!(date: 3.years.ago, balance: 3000)
|
||||
assert_equal 19500, account.balances.find_by(date: balance_date)[:balance]
|
||||
end
|
||||
|
||||
account.sync
|
||||
test "balances before sync start date are not updated after syncing" do
|
||||
account = accounts(:savings_with_valuation_overrides)
|
||||
balance_date = 10.days.ago
|
||||
account.balances.create!(date: balance_date, balance: 1000)
|
||||
account.sync 5.days.ago.to_date
|
||||
|
||||
assert_equal 31, account.balances.count
|
||||
end
|
||||
assert_equal 1000, account.balances.find_by(date: balance_date)[:balance]
|
||||
end
|
||||
|
||||
test "balances after sync start date are updated after syncing" do
|
||||
account = accounts(:savings_with_valuation_overrides)
|
||||
balance_date = 10.days.ago
|
||||
account.balances.create!(date: balance_date, balance: 1000)
|
||||
account.sync 20.days.ago.to_date
|
||||
|
||||
assert_equal 19500, account.balances.find_by(date: balance_date)[:balance]
|
||||
end
|
||||
|
||||
test "balance on the sync date is updated after syncing" do
|
||||
account = accounts(:savings_with_valuation_overrides)
|
||||
balance_date = 5.days.ago
|
||||
account.balances.create!(date: balance_date, balance: 1000)
|
||||
account.sync balance_date.to_date
|
||||
|
||||
assert_equal 19700, account.balances.find_by(date: balance_date)[:balance]
|
||||
end
|
||||
|
||||
test "foreign currency account has balances in each currency after syncing" do
|
||||
account = accounts(:eur_checking)
|
||||
account.sync
|
||||
|
||||
assert_equal 62, account.balances.count
|
||||
assert_equal 31, account.balances.where(currency: "EUR").count
|
||||
assert_equal 31, account.balances.where(currency: "USD").count
|
||||
end
|
||||
|
||||
test "stale balances are purged after syncing" do
|
||||
account = accounts(:savings_with_valuation_overrides)
|
||||
|
||||
# Create old, stale balances that should be purged (since they are before account start date)
|
||||
account.balances.create!(date: 1.year.ago, balance: 1000)
|
||||
account.balances.create!(date: 2.years.ago, balance: 2000)
|
||||
account.balances.create!(date: 3.years.ago, balance: 3000)
|
||||
|
||||
account.sync
|
||||
|
||||
assert_equal 31, account.balances.count
|
||||
end
|
||||
end
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue