From b041edb648ff32e5b6d336c80259458ce9f908c2 Mon Sep 17 00:00:00 2001
From: Zach Gollwitzer <zach.gollwitzer@gmail.com>
Date: Wed, 14 May 2025 14:16:46 -0400
Subject: [PATCH] Tweak sync states

---
 app/controllers/sessions_controller.rb            | 4 ----
 app/jobs/sync_market_data_job.rb                  | 2 +-
 app/models/account/syncer.rb                      | 3 ++-
 app/models/family.rb                              | 8 ++++++++
 app/models/plaid_item/syncer.rb                   | 2 +-
 app/views/accounts/_account_sidebar_tabs.html.erb | 2 +-
 6 files changed, 13 insertions(+), 8 deletions(-)

diff --git a/app/controllers/sessions_controller.rb b/app/controllers/sessions_controller.rb
index a5fe41d9..3b7357f8 100644
--- a/app/controllers/sessions_controller.rb
+++ b/app/controllers/sessions_controller.rb
@@ -31,8 +31,4 @@ class SessionsController < ApplicationController
     def set_session
       @session = Current.user.sessions.find(params[:id])
     end
-
-    def session_params
-      params.require(:session).permit(:tab_key, :tab_value)
-    end
 end
diff --git a/app/jobs/sync_market_data_job.rb b/app/jobs/sync_market_data_job.rb
index 38b1fe7c..074cda9f 100644
--- a/app/jobs/sync_market_data_job.rb
+++ b/app/jobs/sync_market_data_job.rb
@@ -1,7 +1,7 @@
 class SyncMarketDataJob < ApplicationJob
   queue_as :scheduled
 
-  def perform(*args)
+  def perform
     MarketDataSyncer.new.sync_all
   end
 end
diff --git a/app/models/account/syncer.rb b/app/models/account/syncer.rb
index 4328e1d2..fcb586b5 100644
--- a/app/models/account/syncer.rb
+++ b/app/models/account/syncer.rb
@@ -12,7 +12,8 @@ class Account::Syncer
 
   def perform_post_sync
     account.family.auto_match_transfers!
-    account.family.broadcast_refresh
+    account.broadcast_refresh
+    account.family.broadcast_sidebar_refresh
   end
 
   private
diff --git a/app/models/family.rb b/app/models/family.rb
index 0cfb8b89..4db7fdf0 100644
--- a/app/models/family.rb
+++ b/app/models/family.rb
@@ -44,6 +44,14 @@ class Family < ApplicationRecord
         .exists?
   end
 
+  def broadcast_sidebar_refresh
+    broadcast_replace(
+      target: "account-sidebar-tabs",
+      partial: "accounts/sidebar_tabs",
+      locals: { family: self, active_account_group_tab: "all" }
+    )
+  end
+
   def assigned_merchants
     merchant_ids = transactions.where.not(merchant_id: nil).pluck(:merchant_id).uniq
     Merchant.where(id: merchant_ids)
diff --git a/app/models/plaid_item/syncer.rb b/app/models/plaid_item/syncer.rb
index 4669e9b8..f6333403 100644
--- a/app/models/plaid_item/syncer.rb
+++ b/app/models/plaid_item/syncer.rb
@@ -24,7 +24,7 @@ class PlaidItem::Syncer
 
   def perform_post_sync
     plaid_item.auto_match_categories!
-    plaid_item.family.broadcast_refresh
+    plaid_item.family.broadcast_sidebar_refresh
   end
 
   private
diff --git a/app/views/accounts/_account_sidebar_tabs.html.erb b/app/views/accounts/_account_sidebar_tabs.html.erb
index 9fb3acca..74c7d705 100644
--- a/app/views/accounts/_account_sidebar_tabs.html.erb
+++ b/app/views/accounts/_account_sidebar_tabs.html.erb
@@ -1,4 +1,4 @@
-<%# locals: (family:, active_account_group_tab: "assets") %>
+<%# locals: (family:, active_account_group_tab: "asset") %>
 
 <div id="account-sidebar-tabs">
   <% if family.missing_data_provider? %>