Isolate infinite loop bug, add timeout to actions (#583)

* Isolate infinite loop bug, add timeout to actions

* Increase timeout to allow for temporary failure

* Set correct timeout, implement temporary fix

* Trigger syncs at controller layer

app/models/account.rb

@@ -6,9 +6,10 @@ class Account < ApplicationRecord
 
   broadcasts_refreshes
   belongs_to :family
-  has_many :balances
-  has_many :valuations
-  has_many :transactions
+
+  has_many :balances, dependent: :destroy
+  has_many :valuations, dependent: :destroy
+  has_many :transactions, dependent: :destroy
 
   monetize :balance
 

app/models/transaction.rb

@@ -6,8 +6,6 @@ class Transaction < ApplicationRecord
 
   validates :name, :date, :amount, :account, presence: true
 
-  after_commit :sync_account
-
   monetize :amount
 
   scope :inflows, -> { where("amount > 0") }
@@ -42,10 +40,4 @@ class Transaction < ApplicationRecord
 
     filters
   end
-
-  private
-
-    def sync_account
-      self.account.sync_later
-    end
 end

app/models/valuation.rb

@@ -3,7 +3,6 @@ class Valuation < ApplicationRecord
 
   belongs_to :account
   validates :account, :date, :value, presence: true
-  after_commit :sync_account
   monetize :value
 
   scope :in_period, ->(period) { period.date_range.nil? ? all : where(date: period.date_range) }
@@ -11,9 +10,4 @@ class Valuation < ApplicationRecord
   def self.to_series
     TimeSeries.from_collection all, :value_money
   end
-
-  private
-    def sync_account
-      self.account.sync_later
-    end
 end