Docker/Maybe
Docker/Maybe
1
0
Fork 0
mirror of https://github.com/maybe-finance/maybe.git synced 2025-08-05 05:25:24 +02:00
Code Issues Releases Activity Actions

Added lints for ERB templates (#609)

Browse source 
* Added erblint and fixed offenses

* Added erblint bintstub. Included erblint into CI

* Merged GitHub Actions tasks for rubocop and erblint into one

* Added config for erblint.

* Reverted erblint call in the CI
This commit is contained in:
Igor Alexandrov 2024-04-09 16:08:58 +04:00 • committed by GitHub
parent 21e2d05d0c
commit b5c56f7775
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
49 changed files with 201 additions and 160 deletions
Download patch file Download diff file Expand all files Collapse all files

4
app/views/pages/_account_group_disclosure.erb
View file

@ -7,7 +7,7 @@
<div class="ml-4 h-2.5 w-2.5 rounded-full <%= accountable_bg_class(accountable_group.name) %>"></div>
<p class="text-gray-900 ml-2"><%= to_accountable_title(Accountable.from_type(accountable_group.name)) %></p>
<span class="mx-1">&middot;</span>
<div ><%= accountable_group.children.count %></div>
<div><%= accountable_group.children.count %></div>
<div class="ml-auto text-right flex items-center gap-10 text-sm font-medium text-gray-900">
<div class="flex items-center justify-end gap-2 w-24">
<%= render partial: "shared/progress_circle", locals: { progress: accountable_group.percent_of_total, text_class: text_class } %>
@ -47,4 +47,4 @@
</div>
<% end %>
</div>
</details>
</details>

2
app/views/pages/_account_percentages_bar.html.erb
View file

@ -14,4 +14,4 @@
</div>
<% end %>
</div>
</div>
</div>

41
app/views/pages/dashboard.html.erb
View file

@ -1,19 +1,18 @@
<div class="space-y-4">
<div>
<h1 class="sr-only">Dashboard</h1>
<p class="text-xl font-medium text-gray-900 mb-1"><%= t('.greeting', name: Current.user.first_name )%></p>
<p class="text-gray-500 text-sm font-medium"><%= Date.current.strftime('%A, %b %d') %></p>
<p class="text-xl font-medium text-gray-900 mb-1"><%= t(".greeting", name: Current.user.first_name ) %></p>
<p class="text-gray-500 text-sm font-medium"><%= Date.current.strftime("%A, %b %d") %></p>
</div>
<section class="bg-white rounded-xl shadow-xs border border-alpha-black-25">
<div class="flex justify-between p-4">
<div>
<%= render partial: "shared/balance_heading", locals: {
label: "Net Worth",
<%= render partial: "shared/balance_heading", locals: {
label: "Net Worth",
period: @period,
balance: Current.family.net_worth,
trend: @net_worth_series.trend
}
%>
} %>
</div>
<%= form_with url: root_path, method: :get, class: "flex items-center gap-4", data: { controller: "auto-submit-form" } do %>
<%= render partial: "shared/period_select", locals: { value: @period.name } %>
@ -25,24 +24,23 @@
<div class="border-t border-t-alpha-black-100 flex divide-x divide-gray-200">
<div class="w-1/2 p-4 flex items-stretch justify-between">
<div class="space-y-2 grow">
<%= render partial: "shared/balance_heading", locals: {
<%= render partial: "shared/balance_heading", locals: {
label: "Assets",
period: @period,
balance: Current.family.assets,
trend: @asset_series.trend
trend: @asset_series.trend
} %>
</div>
<div
data-controller="trendline"
id="assetsTrendline"
class="h-full w-2/5"
<div
data-controller="trendline"
id="assetsTrendline"
class="h-full w-2/5"
data-trendline-series-value="<%= @asset_series.to_json %>"
data-trendline-classification-value="asset"
></div>
data-trendline-classification-value="asset"></div>
</div>
<div class="w-1/2 p-4 flex items-stretch justify-between">
<div class="space-y-2 grow">
<%= render partial: "shared/balance_heading", locals: {
<%= render partial: "shared/balance_heading", locals: {
label: "Liabilities",
period: @period,
size: "md",
@ -50,13 +48,12 @@
trend: @liability_series.trend
} %>
</div>
<div
data-controller="trendline"
id="liabilitiesTrendline"
class="h-full w-2/5"
<div
data-controller="trendline"
id="liabilitiesTrendline"
class="h-full w-2/5"
data-trendline-series-value="<%= @liability_series.to_json %>"
data-trendline-classification-value="liability"
></div>
data-trendline-classification-value="liability"></div>
</div>
</div>
</section>
@ -70,7 +67,7 @@
<div class="flex items-center gap-2">
<%= link_to new_account_path, class: "flex items-center gap-1 p-2 text-gray-900 text-sm font-medium bg-gray-50 rounded-lg hover:bg-gray-100", data: { turbo_frame: "modal" } do %>
<%= lucide_icon("plus", class: "w-5 h-5 text-gray-500") %>
<p><%= t('.new') %></p>
<p><%= t(".new") %></p>
<% end %>
<%= form_with url: root_path, method: :get, class: "flex items-center gap-4", data: { controller: "auto-submit-form" } do %>
<%= render partial: "shared/period_select", locals: { value: @period.name } %>