Fix #910 (#917)

* Fix #910

* Unify helper for balance formatting in transactions and accounts views

* Remove obsolete method

* Rename helper method format_amount_by_curreny => totals_by_currency

app/helpers/application_helper.rb

@@ -122,4 +122,11 @@ module ApplicationHelper
     options.reverse_merge!(money.default_format_options)
     ActiveSupport::NumberHelper.number_to_delimited(money.amount.round(options[:precision] || 0), { delimiter: options[:delimiter], separator: options[:separator] })
   end
+
+  def totals_by_currency(collection:, money_method:, separator: " | ", negate: false, options: {})
+    collection.group_by(&:currency)
+              .transform_values { |item| negate ? item.sum(&money_method) * -1 : item.sum(&money_method) }
+              .map { |_currency, money| format_money(money) }
+              .join(separator)
+  end
 end

app/views/accounts/_accountable_group.html.erb

@@ -6,7 +6,7 @@
       <p><%= to_accountable_title(Accountable.from_type(group)) %></p>
       <span class="text-gray-400 mx-2">&middot;</span>
       <p><%= accounts.count %></p>
-      <p class="ml-auto"><%= format_money accounts.sum(&:balance_money) %></p>
+      <p class="ml-auto"><%= totals_by_currency(collection: accounts, money_method: :balance_money) %></p>
     </div>
     <div class="bg-white">
       <% accounts.each do |account| %>

app/views/transactions/_date_group.html.erb

@@ -11,13 +11,8 @@
     </div>
 
     <div>
-      <% transactions_by_currency = group[:transactions].group_by(&:currency) %>
-      <% transactions_by_currency.each_with_index do |(_currency, transactions), idx| %>
-        <%= tag.span format_money(-transactions.sum(&:amount_money)) %>
-        <%= tag.span "|", class: "mx-2" if idx < transactions_by_currency.count - 1 %>
-      <% end %>
+      <%= totals_by_currency(collection: group[:transactions], money_method: :amount_money, negate: true) %>
     </div>
-
   </div>
   <div class="bg-white shadow-xs rounded-md border border-alpha-black-25 divide-y divide-alpha-black-50">
     <%= render group[:transactions] %>