Docker/Maybe
Docker/Maybe
1
0
Fork 0
mirror of https://github.com/maybe-finance/maybe.git synced 2025-07-28 17:49:38 +02:00
Code Issues Releases Activity Actions

Fix favorable direction serialization

Browse source
This commit is contained in:
Jose Farias 2024-04-19 19:35:34 -06:00
parent febfa3bce6
commit bdd7e82bae
2 changed files with 10 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/models/time_series.rb
View file

@ -42,7 +42,7 @@ class TimeSeries
{ {
values: values.map(&:as_json), values: values.map(&:as_json),
trend: trend.as_json, trend: trend.as_json,
favorable_direction: favorable_direction favorableDirection: favorable_direction
}.as_json }.as_json
end end

18
test/models/time_series_test.rb
View file

@ -29,7 +29,7 @@ class TimeSeriesTest < ActiveSupport::TestCase
assert_nil series.first assert_nil series.first
assert_nil series.last assert_nil series.last
assert_equal({ values: [], trend: { favorable_direction: "up", direction: "flat", value: 0, percent: 0.0 }, favorable_direction: "up" }.to_json, series.to_json) assert_equal({ values: [], trend: { favorableDirection: "up", direction: "flat", value: 0, percent: 0.0 }, favorableDirection: "up" }.to_json, series.to_json)
end end
test "money series can be serialized to json" do test "money series can be serialized to json" do
@ -38,16 +38,16 @@ class TimeSeriesTest < ActiveSupport::TestCase
{ {
date: 1.day.ago.to_date, date: 1.day.ago.to_date,
value: { amount: "100.0", currency: "USD" }, value: { amount: "100.0", currency: "USD" },
trend: { favorable_direction: "up", direction: "flat", value: { amount: "0.0", currency: "USD" }, percent: 0.0 } trend: { favorableDirection: "up", direction: "flat", value: { amount: "0.0", currency: "USD" }, percent: 0.0 }
}, },
{ {
date: Date.current, date: Date.current,
value: { amount: "200.0", currency: "USD" }, value: { amount: "200.0", currency: "USD" },
trend: { favorable_direction: "up", direction: "up", value: { amount: "100.0", currency: "USD" }, percent: 100.0 } trend: { favorableDirection: "up", direction: "up", value: { amount: "100.0", currency: "USD" }, percent: 100.0 }
} }
], ],
trend: { favorable_direction: "up", direction: "up", value: { amount: "100.0", currency: "USD" }, percent: 100.0 }, trend: { favorableDirection: "up", direction: "up", value: { amount: "100.0", currency: "USD" }, percent: 100.0 },
favorable_direction: "up" favorableDirection: "up"
}.to_json }.to_json
series = TimeSeries.new([ { date: 1.day.ago.to_date, value: Money.new(100) }, { date: Date.current, value: Money.new(200) } ]) series = TimeSeries.new([ { date: 1.day.ago.to_date, value: Money.new(100) }, { date: Date.current, value: Money.new(200) } ])
@ -58,11 +58,11 @@ class TimeSeriesTest < ActiveSupport::TestCase
test "numeric series can be serialized to json" do test "numeric series can be serialized to json" do
expected_values = { expected_values = {
values: [ values: [
{ date: 1.day.ago.to_date, value: 100, trend: { favorable_direction: "up", direction: "flat", value: 0, percent: 0.0 } }, { date: 1.day.ago.to_date, value: 100, trend: { favorableDirection: "up", direction: "flat", value: 0, percent: 0.0 } },
{ date: Date.current, value: 200, trend: { favorable_direction: "up", direction: "up", value: 100, percent: 100.0 } } { date: Date.current, value: 200, trend: { favorableDirection: "up", direction: "up", value: 100, percent: 100.0 } }
], ],
trend: { favorable_direction: "up", direction: "up", value: 100, percent: 100.0 }, trend: { favorableDirection: "up", direction: "up", value: 100, percent: 100.0 },
favorable_direction: "up" favorableDirection: "up"
}.to_json }.to_json
series = TimeSeries.new([ { date: 1.day.ago.to_date, value: 100 }, { date: Date.current, value: 200 } ]) series = TimeSeries.new([ { date: 1.day.ago.to_date, value: 100 }, { date: Date.current, value: 200 } ])