Account namespace updates: part 4 (transfers, singular namespacing) (#896)

* Move Transfer to Account namespace

* Fix partial resolution due to namespacing plurality

* Make category and tag controllers consistent with namespacing convention

* Update stale partial reference

app/controllers/account/logos_controller.rb

@@ -1,4 +1,4 @@
-class Accounts::LogosController < ApplicationController
+class Account::LogosController < ApplicationController
   def show
     @account = Current.family.accounts.find(params[:account_id])
     render_placeholder

app/controllers/account/transfers_controller.rb

@@ -1,17 +1,17 @@
-class TransfersController < ApplicationController
+class Account::TransfersController < ApplicationController
   layout "with_sidebar"
 
   before_action :set_transfer, only: :destroy
 
   def new
-    @transfer = Transfer.new
+    @transfer = Account::Transfer.new
   end
 
   def create
     from_account = Current.family.accounts.find(transfer_params[:from_account_id])
     to_account = Current.family.accounts.find(transfer_params[:to_account_id])
 
-    @transfer = Transfer.build_from_accounts from_account, to_account, \
+    @transfer = Account::Transfer.build_from_accounts from_account, to_account, \
                                              date: transfer_params[:date],
                                              amount: transfer_params[:amount].to_d,
                                              currency: transfer_params[:currency],
@@ -20,7 +20,10 @@ class TransfersController < ApplicationController
     if @transfer.save
       redirect_to transactions_path, notice: t(".success")
     else
-      render :new, status: :unprocessable_entity
+      # TODO: this is not an ideal way to handle errors and should eventually be improved.
+      # See: https://github.com/hotwired/turbo-rails/pull/367
+      flash[:error] = @transfer.errors.full_messages.to_sentence
+      redirect_to transactions_path
     end
   end
 
@@ -32,10 +35,10 @@ class TransfersController < ApplicationController
   private
 
     def set_transfer
-      @transfer = Transfer.find(params[:id])
+      @transfer = Account::Transfer.find(params[:id])
     end
 
     def transfer_params
-      params.require(:transfer).permit(:from_account_id, :to_account_id, :amount, :currency, :date, :name)
+      params.require(:account_transfer).permit(:from_account_id, :to_account_id, :amount, :currency, :date, :name)
     end
 end

app/controllers/category/deletions_controller.rb

@@ -1,4 +1,4 @@
-class Categories::DeletionsController < ApplicationController
+class Category::DeletionsController < ApplicationController
   layout "with_sidebar"
 
   before_action :set_category

app/controllers/category/dropdowns_controller.rb

@@ -1,4 +1,4 @@
-class Categories::DropdownsController < ApplicationController
+class Category::DropdownsController < ApplicationController
   before_action :set_from_params
 
   def show

app/controllers/tag/deletions_controller.rb

@@ -1,4 +1,4 @@
-class Tags::DeletionsController < ApplicationController
+class Tag::DeletionsController < ApplicationController
   layout "with_sidebar"
 
   before_action :set_tag

app/controllers/transaction/rows_controller.rb

@@ -1,4 +1,4 @@
-class Transactions::RowsController < ApplicationController
+class Transaction::RowsController < ApplicationController
   before_action :set_transaction, only: %i[ show update ]
 
   def show

app/controllers/transaction/rules_controller.rb

@@ -0,0 +1,6 @@
+class Transaction::RulesController < ApplicationController
+  layout "with_sidebar"
+
+  def index
+  end
+end

app/controllers/transactions/rules_controller.rb

@@ -1,6 +0,0 @@
-class Transactions::RulesController < ApplicationController
-  layout "with_sidebar"
-
-  def index
-  end
-end