Docker/Maybe
Docker/Maybe
1
0
Fork 0
mirror of https://github.com/maybe-finance/maybe.git synced 2025-08-02 20:15:22 +02:00
Code Issues Releases Activity Actions

Remove missing prices issue (#1390)

Browse source
This commit is contained in:
Zach Gollwitzer 2024-10-29 14:55:46 -04:00 • committed by GitHub
parent 7d8028b505
commit bf695972e4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
8 changed files with 11 additions and 114 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/models/account/holding/syncer.rb
View file

@ -68,8 +68,6 @@ class Account::Holding::Syncer
price = get_cached_price(ticker, date) || trade_price
account.observe_missing_price(ticker:, date:) unless price
account.holdings.build \
date: date,
security_id: holding[:security_id],

6
app/models/concerns/issuable.rb
View file

@ -33,12 +33,6 @@ module Issuable
)
end
def observe_missing_price(ticker:, date:)
issue = issues.find_or_create_by(type: Issue::PricesMissing.name, resolved_at: nil)
issue.append_missing_price(ticker, date)
issue.save!
end
def highest_priority_issue
issues.active.ordered.first
end

33
app/models/issue/prices_missing.rb
View file

@ -1,33 +0,0 @@
class Issue::PricesMissing < Issue
store_accessor :data, :missing_prices
after_initialize :initialize_missing_prices
validates :missing_prices, presence: true, allow_blank: true
def append_missing_price(ticker, date)
missing_prices[ticker] ||= []
missing_prices[ticker] << date unless missing_prices[ticker].include?(date.to_s)
end
def stale?
stale = true
missing_prices.each do |ticker, dates|
next unless issuable.owns_ticker?(ticker)
oldest_date = dates.min.to_date
expected_price_count = (oldest_date..Date.current).count
prices = Security::Price.find_prices(ticker: ticker, start_date: oldest_date)
stale = false if prices.count < expected_price_count
end
stale
end
private
def initialize_missing_prices
self.missing_prices ||= {}
end
end