Improve account transaction, trade, and valuation editing and sync experience (#1506)

* Consolidate entry controller logic

* Transaction builder

* Update trades controller to use new params

* Load account charts in turbo frames, fix PG overflow

* Consolidate tests

* Tests passing

* Remove unused code

* Add client side trade form validations

app/views/accounts/_chart_loader.html.erb

@@ -0,0 +1,5 @@
+<div class="h-10">
+</div>
+<div class="h-64 flex items-center justify-center">
+  <p class="text-gray-500 animate-pulse text-sm">Loading...</p>
+</div>

app/views/accounts/chart.html.erb

@@ -0,0 +1,32 @@
+<% period = Period.from_param(params[:period]) %>
+<% series = @account.series(period: period) %>
+<% trend = series.trend %>
+
+<%= turbo_frame_tag dom_id(@account, :chart_details) do %>
+  <div class="px-4">
+    <% if trend.direction.flat? %>
+      <%= tag.span t(".no_change"), class: "text-gray-500" %>
+    <% else %>
+      <%= tag.span "#{trend.value.positive? ? "+" : ""}#{format_money(trend.value)}", style: "color: #{trend.color}" %>
+      <% unless trend.percent.infinite? %>
+        <%= tag.span "(#{trend.percent}%)", style: "color: #{trend.color}" %>
+      <% end %>
+    <% end %>
+
+    <%= tag.span period_label(period), class: "text-gray-500" %>
+  </div>
+
+  <div class="h-64">
+    <% if series %>
+      <div
+        id="lineChart"
+        class="w-full h-full"
+        data-controller="time-series-chart"
+        data-time-series-chart-data-value="<%= series.to_json %>"></div>
+    <% else %>
+      <div class="w-full h-full flex items-center justify-center">
+        <p class="text-gray-500">No data available for the selected period.</p>
+      </div>
+    <% end %>
+  </div>
+<% end %>

app/views/accounts/show/_activity.html.erb

@@ -1,5 +1,5 @@
 <%# locals: (account:) %>
 
-<%= turbo_frame_tag dom_id(account, :entries), src: account_entries_path(account) do %>
+<%= turbo_frame_tag dom_id(account, :entries), src: account_entries_path(account_id: account.id) do %>
   <%= render "account/entries/loading" %>
 <% end %>

app/views/accounts/show/_chart.html.erb

@@ -1,12 +1,10 @@
 <%# locals: (account:, title: nil, tooltip: nil, **args) %>
 
 <% period = Period.from_param(params[:period]) %>
-<% series = account.series(period: period) %>
-<% trend = series.trend %>
 <% default_value_title = account.asset? ? t(".balance") : t(".owed") %>
 
-<div id="<%= dom_id(account, :chart) %>" class="bg-white shadow-xs rounded-xl border border-alpha-black-25 rounded-lg">
-  <div class="p-4 flex justify-between">
+<div id="<%= dom_id(account, :chart) %>" class="bg-white shadow-xs rounded-xl border border-alpha-black-25 rounded-lg space-y-2">
+  <div class="flex justify-between px-4 pt-4 mb-2">
     <div class="space-y-2">
       <div class="flex items-center gap-1">
         <%= tag.p title || default_value_title, class: "text-sm font-medium text-gray-500" %>
@@ -14,19 +12,6 @@
       </div>
 
       <%= tag.p format_money(account.value), class: "text-gray-900 text-3xl font-medium" %>
-
-      <div>
-        <% if trend.direction.flat? %>
-          <%= tag.span t(".no_change"), class: "text-gray-500" %>
-        <% else %>
-          <%= tag.span "#{trend.value.positive? ? "+" : ""}#{format_money(trend.value)}", style: "color: #{trend.color}" %>
-          <% unless trend.percent.infinite? %>
-            <%= tag.span "(#{trend.percent}%)", style: "color: #{trend.color}" %>
-          <% end %>
-        <% end %>
-
-        <%= tag.span period_label(period), class: "text-gray-500" %>
-      </div>
     </div>
 
     <%= form_with url: request.path, method: :get, data: { controller: "auto-submit-form" } do |form| %>
@@ -34,7 +19,7 @@
     <% end %>
   </div>
 
-  <div class="h-64 flex items-center justify-center text-2xl font-bold">
-    <%= render "shared/line_chart", series: series %>
-  </div>
+  <%= turbo_frame_tag dom_id(account, :chart_details), src: chart_account_path(account, period: period.name) do %>
+    <%= render "accounts/chart_loader" %>
+  <% end %>
 </div>

app/views/accounts/show/_tab.html.erb

@@ -2,6 +2,7 @@
 
 <%= link_to key.titleize,
             account_path(account, tab: key),
+            data: { turbo: false },
             class: [
               "px-2 py-1.5 rounded-md border border-transparent",
               "bg-white shadow-xs border-alpha-black-50": is_selected