Improve account transaction, trade, and valuation editing and sync experience (#1506)

* Consolidate entry controller logic

* Transaction builder

* Update trades controller to use new params

* Load account charts in turbo frames, fix PG overflow

* Consolidate tests

* Tests passing

* Remove unused code

* Add client side trade form validations

test/controllers/account/transactions_controller_test.rb

@@ -1,40 +1,117 @@
 require "test_helper"
 
 class Account::TransactionsControllerTest < ActionDispatch::IntegrationTest
+  include EntryableResourceInterfaceTest
+
   setup do
     sign_in @user = users(:family_admin)
-    @entry = account_entries :transaction
+    @entry = account_entries(:transaction)
   end
 
-  test "should get index" do
-    get account_transactions_url(@entry.account)
-    assert_response :success
-  end
-
-  test "update" do
-    assert_no_difference [ "Account::Entry.count", "Account::Transaction.count" ] do
-      patch account_transaction_url(@entry.account, @entry), params: {
+  test "creates with transaction details" do
+    assert_difference [ "Account::Entry.count", "Account::Transaction.count" ], 1 do
+      post account_transactions_url, params: {
         account_entry: {
-          name: "Name",
+          account_id: @entry.account_id,
+          name: "New transaction",
           date: Date.current,
           currency: "USD",
           amount: 100,
-          nature: "income",
-          entryable_type: @entry.entryable_type,
+          nature: "inflow",
           entryable_attributes: {
-            id: @entry.entryable_id,
             tag_ids: [ Tag.first.id, Tag.second.id ],
             category_id: Category.first.id,
-            merchant_id: Merchant.first.id,
-            notes: "test notes",
-            excluded: false
+            merchant_id: Merchant.first.id
           }
         }
       }
     end
 
-    assert_equal "Transaction updated successfully.", flash[:notice]
-    assert_redirected_to account_entry_url(@entry.account, @entry)
+    created_entry = Account::Entry.order(:created_at).last
+
+    assert_redirected_to account_url(created_entry.account)
+    assert_equal "Entry created", flash[:notice]
     assert_enqueued_with(job: SyncJob)
   end
+
+  test "updates with transaction details" do
+    assert_no_difference [ "Account::Entry.count", "Account::Transaction.count" ] do
+      patch account_transaction_url(@entry), params: {
+        account_entry: {
+          name: "Updated name",
+          date: Date.current,
+          currency: "USD",
+          amount: 100,
+          nature: "inflow",
+          entryable_type: @entry.entryable_type,
+          notes: "test notes",
+          excluded: false,
+          entryable_attributes: {
+            id: @entry.entryable_id,
+            tag_ids: [ Tag.first.id, Tag.second.id ],
+            category_id: Category.first.id,
+            merchant_id: Merchant.first.id
+          }
+        }
+      }
+    end
+
+    @entry.reload
+
+    assert_equal "Updated name", @entry.name
+    assert_equal Date.current, @entry.date
+    assert_equal "USD", @entry.currency
+    assert_equal -100, @entry.amount
+    assert_equal [ Tag.first.id, Tag.second.id ], @entry.entryable.tag_ids.sort
+    assert_equal Category.first.id, @entry.entryable.category_id
+    assert_equal Merchant.first.id, @entry.entryable.merchant_id
+    assert_equal "test notes", @entry.notes
+    assert_equal false, @entry.excluded
+
+    assert_equal "Entry updated", flash[:notice]
+    assert_redirected_to account_url(@entry.account)
+    assert_enqueued_with(job: SyncJob)
+  end
+
+  test "can destroy many transactions at once" do
+    transactions = @user.family.entries.account_transactions
+    delete_count = transactions.size
+
+    assert_difference([ "Account::Transaction.count", "Account::Entry.count" ], -delete_count) do
+      post bulk_delete_account_transactions_url, params: {
+        bulk_delete: {
+          entry_ids: transactions.pluck(:id)
+        }
+      }
+    end
+
+    assert_redirected_to transactions_url
+    assert_equal "#{delete_count} transactions deleted", flash[:notice]
+  end
+
+  test "can update many transactions at once" do
+    transactions = @user.family.entries.account_transactions
+
+    assert_difference [ "Account::Entry.count", "Account::Transaction.count" ], 0 do
+      post bulk_update_account_transactions_url, params: {
+        bulk_update: {
+          entry_ids: transactions.map(&:id),
+          date: 1.day.ago.to_date,
+          category_id: Category.second.id,
+          merchant_id: Merchant.second.id,
+          notes: "Updated note"
+        }
+      }
+    end
+
+    assert_redirected_to transactions_url
+    assert_equal "#{transactions.count} transactions updated", flash[:notice]
+
+    transactions.reload.each do |transaction|
+      assert_equal 1.day.ago.to_date, transaction.date
+      assert_equal Category.second, transaction.account_transaction.category
+      assert_equal Merchant.second, transaction.account_transaction.merchant
+      assert_equal "Updated note", transaction.notes
+    end
+  end
 end