Account::Entry Delegated Type (namespace updates part 7) (#923)

* Initial entryable models

* Update transfer and tests

* Update transaction controllers and tests

* Update sync process to use new entries model

* Get dashboard working again

* Update transfers, imports, and accounts to use Account::Entry

* Update system tests

* Consolidate transaction management into entries controller

* Add permitted partial key helper

* Move account transactions list to entries controller

* Delegate transaction entries search

* Move transfer relation to entry

* Update bulk transaction management flows to use entries

* Remove test code

* Test fix attempt

* Update demo data script

* Consolidate remaining transaction partials to entries

* Consolidate valuations controller to entries controller

* Lint fix

* Remove unused files, additional cleanup

* Add back valuation creation

* Make migrations fully reversible

* Stale routes cleanup

* Migrations reversible fix

* Move types to entryable concern

* Fix search when no entries found

* Remove more unused code

app/helpers/account/entries_helper.rb

@@ -0,0 +1,39 @@
+module Account::EntriesHelper
+  def permitted_entryable_partial_path(entry, relative_partial_path)
+    "account/entries/entryables/#{permitted_entryable_key(entry)}/#{relative_partial_path}"
+  end
+
+  def unconfirmed_transfer?(entry)
+    entry.marked_as_transfer? && entry.transfer.nil?
+  end
+
+  def transfer_entries(entries)
+    transfers = entries.select { |e| e.transfer_id.present? }
+    transfers.map(&:transfer).uniq
+  end
+
+  def entry_icon(entry, is_oldest: false)
+    if is_oldest
+      "keyboard"
+    elsif entry.trend.direction.up?
+      "arrow-up"
+    elsif entry.trend.direction.down?
+      "arrow-down"
+    else
+      "minus"
+    end
+  end
+
+  def entry_style(entry, is_oldest: false)
+    color = is_oldest ? "#D444F1" : entry.trend.color
+
+    mixed_hex_styles(color)
+  end
+
+  private
+
+    def permitted_entryable_key(entry)
+      permitted_entryable_paths = %w[transaction valuation]
+      entry.entryable_name_short.presence_in(permitted_entryable_paths)
+    end
+end

app/helpers/account/transaction/searches_helper.rb

@@ -1,37 +0,0 @@
-module Account::Transaction::SearchesHelper
-  def transaction_search_filters
-    [
-      { key: "account_filter", name: "Account", icon: "layers" },
-      { key: "date_filter", name: "Date", icon: "calendar" },
-      { key: "type_filter", name: "Type", icon: "shapes" },
-      { key: "amount_filter", name: "Amount", icon: "hash" },
-      { key: "category_filter", name: "Category", icon: "tag" },
-      { key: "merchant_filter", name: "Merchant", icon: "store" }
-    ]
-  end
-
-  def get_transaction_search_filter_partial_path(filter)
-    "transactions/searches/filters/#{filter[:key]}"
-  end
-
-  def get_default_transaction_search_filter
-    transaction_search_filters[0]
-  end
-
-  def transactions_path_without_param(param_key, param_value)
-    updated_params = request.query_parameters.deep_dup
-
-    q_params = updated_params[:q] || {}
-
-    current_value = q_params[param_key]
-    if current_value.is_a?(Array)
-      q_params[param_key] = current_value - [ param_value ]
-    else
-      q_params.delete(param_key)
-    end
-
-    updated_params[:q] = q_params
-
-    transactions_path(updated_params)
-  end
-end

app/helpers/account/transactions_helper.rb

@@ -1,24 +0,0 @@
-module Account::TransactionsHelper
-  def unconfirmed_transfer?(transaction)
-    transaction.marked_as_transfer && transaction.transfer.nil?
-  end
-
-  def group_transactions_by_date(transactions)
-    grouped_by_date = {}
-
-    transactions.each do |transaction|
-      if transaction.transfer
-        transfer_date = transaction.transfer.inflow_transaction.date
-        grouped_by_date[transfer_date] ||= { transactions: [], transfers: [] }
-        unless grouped_by_date[transfer_date][:transfers].include?(transaction.transfer)
-          grouped_by_date[transfer_date][:transfers] << transaction.transfer
-        end
-      else
-        grouped_by_date[transaction.date] ||= { transactions: [], transfers: [] }
-        grouped_by_date[transaction.date][:transactions] << transaction
-      end
-    end
-
-    grouped_by_date
-  end
-end

app/helpers/account/valuations_helper.rb

@@ -1,23 +0,0 @@
-module Account::ValuationsHelper
-  def valuation_icon(valuation)
-    if valuation.oldest?
-      "keyboard"
-    elsif valuation.trend.direction.up?
-      "arrow-up"
-    elsif valuation.trend.direction.down?
-      "arrow-down"
-    else
-      "minus"
-    end
-  end
-
-  def valuation_style(valuation)
-    color = valuation.oldest? ? "#D444F1" : valuation.trend.color
-
-    <<-STYLE.strip
-      background-color: color-mix(in srgb, #{color} 5%, white);
-      border-color: color-mix(in srgb, #{color} 10%, white);
-      color: #{color};
-    STYLE
-  end
-end