Account::Entry Delegated Type (namespace updates part 7) (#923)

* Initial entryable models

* Update transfer and tests

* Update transaction controllers and tests

* Update sync process to use new entries model

* Get dashboard working again

* Update transfers, imports, and accounts to use Account::Entry

* Update system tests

* Consolidate transaction management into entries controller

* Add permitted partial key helper

* Move account transactions list to entries controller

* Delegate transaction entries search

* Move transfer relation to entry

* Update bulk transaction management flows to use entries

* Remove test code

* Test fix attempt

* Update demo data script

* Consolidate remaining transaction partials to entries

* Consolidate valuations controller to entries controller

* Lint fix

* Remove unused files, additional cleanup

* Add back valuation creation

* Make migrations fully reversible

* Stale routes cleanup

* Migrations reversible fix

* Move types to entryable concern

* Fix search when no entries found

* Remove more unused code

test/controllers/account/entries_controller_test.rb

@@ -0,0 +1,133 @@
+require "test_helper"
+
+class Account::EntriesControllerTest < ActionDispatch::IntegrationTest
+  setup do
+    sign_in @user = users(:family_admin)
+    @account = accounts(:savings)
+    @transaction_entry = @account.entries.account_transactions.first
+    @valuation_entry = @account.entries.account_valuations.first
+  end
+
+  test "should edit valuation entry" do
+    get edit_account_entry_url(@account, @valuation_entry)
+    assert_response :success
+  end
+
+  test "should show transaction entry" do
+    get account_entry_url(@account, @transaction_entry)
+    assert_response :success
+  end
+
+  test "should show valuation entry" do
+    get account_entry_url(@account, @valuation_entry)
+    assert_response :success
+  end
+
+  test "should get list of transaction entries" do
+    get transaction_account_entries_url(@account)
+    assert_response :success
+  end
+
+  test "should get list of valuation entries" do
+    get valuation_account_entries_url(@account)
+    assert_response :success
+  end
+
+  test "gets new entry by type" do
+    get new_account_entry_url(@account, entryable_type: "Account::Valuation")
+    assert_response :success
+  end
+
+  test "should create valuation" do
+    assert_difference [ "Account::Entry.count", "Account::Valuation.count" ], 1 do
+      post account_entries_url(@account), params: {
+        account_entry: {
+          name: "Manual valuation",
+          amount: 19800,
+          date: Date.current,
+          currency: @account.currency,
+          entryable_type: "Account::Valuation",
+          entryable_attributes: {}
+        }
+      }
+    end
+
+    assert_equal "Valuation created", flash[:notice]
+    assert_enqueued_with job: AccountSyncJob
+    assert_redirected_to account_path(@account)
+  end
+
+  test "error when valuation already exists for date" do
+    assert_no_difference_in_entries do
+      post account_entries_url(@account), params: {
+        account_entry: {
+          amount: 19800,
+          date: @valuation_entry.date,
+          currency: @valuation_entry.currency,
+          entryable_type: "Account::Valuation",
+          entryable_attributes: {}
+        }
+      }
+    end
+
+    assert_equal "Date has already been taken", flash[:error]
+    assert_redirected_to account_path(@account)
+  end
+
+  test "can update entry without entryable attributes" do
+    assert_no_difference_in_entries do
+      patch account_entry_url(@account, @valuation_entry), params: {
+        account_entry: {
+          name: "Updated name"
+        }
+      }
+    end
+
+    assert_redirected_to account_entry_url(@account, @valuation_entry)
+    assert_enqueued_with(job: AccountSyncJob)
+  end
+
+  test "should update transaction entry with entryable attributes" do
+    assert_no_difference_in_entries do
+      patch account_entry_url(@account, @transaction_entry), params: {
+        account_entry: {
+          name: "Updated name",
+          date: Date.current,
+          currency: "USD",
+          amount: 20,
+          entryable_type: @transaction_entry.entryable_type,
+          entryable_attributes: {
+            id: @transaction_entry.entryable_id,
+            tag_ids: [ Tag.first.id, Tag.second.id ],
+            category_id: Category.first.id,
+            merchant_id: Merchant.first.id,
+            notes: "test notes",
+            excluded: false
+          }
+        }
+      }
+    end
+
+    assert_redirected_to account_entry_url(@account, @transaction_entry)
+    assert_enqueued_with(job: AccountSyncJob)
+  end
+
+  test "should destroy transaction entry" do
+    [ @transaction_entry, @valuation_entry ].each do |entry|
+      assert_difference -> { Account::Entry.count } => -1, -> { entry.entryable_class.count } => -1 do
+        delete account_entry_url(@account, entry)
+      end
+
+      assert_redirected_to account_url(@account)
+      assert_enqueued_with(job: AccountSyncJob)
+    end
+  end
+
+  private
+
+    # Simple guard to verify that nested attributes are passed the record ID to avoid new creation of record
+    # See `update_only` option of accepts_nested_attributes_for
+    def assert_no_difference_in_entries(&block)
+      assert_no_difference [ "Account::Entry.count", "Account::Transaction.count", "Account::Valuation.count" ], &block
+    end
+end