Account::Entry Delegated Type (namespace updates part 7) (#923)

* Initial entryable models

* Update transfer and tests

* Update transaction controllers and tests

* Update sync process to use new entries model

* Get dashboard working again

* Update transfers, imports, and accounts to use Account::Entry

* Update system tests

* Consolidate transaction management into entries controller

* Add permitted partial key helper

* Move account transactions list to entries controller

* Delegate transaction entries search

* Move transfer relation to entry

* Update bulk transaction management flows to use entries

* Remove test code

* Test fix attempt

* Update demo data script

* Consolidate remaining transaction partials to entries

* Consolidate valuations controller to entries controller

* Lint fix

* Remove unused files, additional cleanup

* Add back valuation creation

* Make migrations fully reversible

* Stale routes cleanup

* Migrations reversible fix

* Move types to entryable concern

* Fix search when no entries found

* Remove more unused code

test/models/account/transfer_test.rb

@@ -3,19 +3,32 @@ require "test_helper"
 class Account::TransferTest < ActiveSupport::TestCase
   setup do
     # Transfers can be posted on different dates
-    @outflow = accounts(:checking).transactions.create! date: 1.day.ago.to_date, name: "Transfer to Savings", amount: 100, marked_as_transfer: true
-    @inflow = accounts(:savings).transactions.create! date: Date.current, name: "Transfer from Savings", amount: -100, marked_as_transfer: true
+    @outflow = accounts(:checking).entries.create! \
+      date: 1.day.ago.to_date,
+      name: "Transfer to Savings",
+      amount: 100,
+      currency: "USD",
+      marked_as_transfer: true,
+      entryable: Account::Transaction.new
+
+    @inflow = accounts(:savings).entries.create! \
+      date: Date.current,
+      name: "Transfer from Savings",
+      amount: -100,
+      currency: "USD",
+      marked_as_transfer: true,
+      entryable: Account::Transaction.new
   end
 
   test "transfer valid if it has inflow and outflow from different accounts for the same amount" do
-    transfer = Account::Transfer.create! transactions: [ @inflow, @outflow ]
+    transfer = Account::Transfer.create! entries: [ @inflow, @outflow ]
 
     assert transfer.valid?
   end
 
   test "transfer must have 2 transactions" do
-    invalid_transfer_1 = Account::Transfer.new transactions: [ @outflow ]
-    invalid_transfer_2 = Account::Transfer.new transactions: [ @inflow, @outflow, account_transactions(:savings_four) ]
+    invalid_transfer_1 = Account::Transfer.new entries: [ @outflow ]
+    invalid_transfer_2 = Account::Transfer.new entries: [ @inflow, @outflow, account_entries(:savings_four) ]
 
     assert invalid_transfer_1.invalid?
     assert invalid_transfer_2.invalid?
@@ -23,11 +36,24 @@ class Account::TransferTest < ActiveSupport::TestCase
 
   test "transfer cannot have 2 transactions from the same account" do
     account = accounts(:checking)
-    inflow = account.transactions.create! date: Date.current, name: "Inflow", amount: -100
-    outflow = account.transactions.create! date: Date.current, name: "Outflow", amount: 100
+    inflow = account.entries.create! \
+      date: Date.current,
+      name: "Inflow",
+      amount: -100,
+      currency: "USD",
+      marked_as_transfer: true,
+      entryable: Account::Transaction.new
+
+    outflow = account.entries.create! \
+      date: Date.current,
+      name: "Outflow",
+      amount: 100,
+      currency: "USD",
+      marked_as_transfer: true,
+      entryable: Account::Transaction.new
 
     assert_raise ActiveRecord::RecordInvalid do
-      Account::Transfer.create! transactions: [ inflow, outflow ]
+      Account::Transfer.create! entries: [ inflow, outflow ]
     end
   end
 
@@ -35,7 +61,7 @@ class Account::TransferTest < ActiveSupport::TestCase
     @inflow.update! marked_as_transfer: false
 
     assert_raise ActiveRecord::RecordInvalid do
-      Account::Transfer.create! transactions: [ @inflow, @outflow ]
+      Account::Transfer.create! entries: [ @inflow, @outflow ]
     end
   end
 
@@ -43,13 +69,13 @@ class Account::TransferTest < ActiveSupport::TestCase
     @outflow.update! amount: 105
 
     assert_raises ActiveRecord::RecordInvalid do
-      Account::Transfer.create! transactions: [ @inflow, @outflow ]
+      Account::Transfer.create! entries: [ @inflow, @outflow ]
     end
   end
 
   test "multi-currency transfer transactions do not have to net to zero" do
     @outflow.update! amount: 105, currency: "EUR"
-    transfer = Account::Transfer.create! transactions: [ @inflow, @outflow ]
+    transfer = Account::Transfer.create! entries: [ @inflow, @outflow ]
 
     assert transfer.valid?
   end