Account::Sync model and test fixture simplifications (#968)

* Add sync model

* Fresh fixtures for sync tests

* Sync tests overhaul

* Fix entry tests

* Complete remaining model test updates

* Update system tests

* Update demo data task

* Add system tests back to PR checks

* More simplifications, add empty family to fixtures for easier testing

test/models/account/entry_test.rb

@@ -1,26 +1,29 @@
 require "test_helper"
 
 class Account::EntryTest < ActiveSupport::TestCase
+  include Account::EntriesTestHelper
+
   setup do
-    @entry = account_entries :checking_one
-    @family = families :dylan_family
+    @entry = account_entries :transaction
   end
 
   test "valuations cannot have more than one entry per day" do
-    new_entry = Account::Entry.new \
-      entryable: Account::Valuation.new,
-      date: @entry.date, # invalid
-      currency: @entry.currency,
-      amount: @entry.amount
+    existing_valuation = account_entries :valuation
 
-    assert new_entry.invalid?
+    new_valuation = Account::Entry.new \
+      entryable: Account::Valuation.new,
+      date: existing_valuation.date, # invalid
+      currency: existing_valuation.currency,
+      amount: existing_valuation.amount
+
+    assert new_valuation.invalid?
   end
 
   test "triggers sync with correct start date when transaction is set to prior date" do
     prior_date = @entry.date - 1
     @entry.update! date: prior_date
 
-    @entry.account.expects(:sync_later).with(prior_date)
+    @entry.account.expects(:sync_later).with(start_date: prior_date)
     @entry.sync_account_later
   end
 
@@ -28,48 +31,62 @@ class Account::EntryTest < ActiveSupport::TestCase
     prior_date = @entry.date
     @entry.update! date: @entry.date + 1
 
-    @entry.account.expects(:sync_later).with(prior_date)
+    @entry.account.expects(:sync_later).with(start_date: prior_date)
     @entry.sync_account_later
   end
 
   test "triggers sync with correct start date when transaction deleted" do
-    prior_entry = account_entries(:checking_two) # 12 days ago
-    current_entry = account_entries(:checking_one) # 5 days ago
+    current_entry = create_transaction(date: 1.day.ago.to_date)
+    prior_entry = create_transaction(date: current_entry.date - 1.day)
+
     current_entry.destroy!
 
-    current_entry.account.expects(:sync_later).with(prior_entry.date)
+    current_entry.account.expects(:sync_later).with(start_date: prior_entry.date)
     current_entry.sync_account_later
   end
 
   test "can search entries" do
+    family = families(:empty)
+    account = family.accounts.create! name: "Test", balance: 0, accountable: Depository.new
+    category = family.categories.first
+    merchant = family.merchants.first
+
+    create_transaction(account: account, name: "a transaction")
+    create_transaction(account: account, name: "ignored")
+    create_transaction(account: account, name: "third transaction", category: category, merchant: merchant)
+
     params = { search: "a" }
 
-    assert_equal 12, Account::Entry.search(params).size
+    assert_equal 2, family.entries.search(params).size
 
-    params = params.merge(categories: [ "Food & Drink" ]) # transaction specific search param
+    params = params.merge(categories: [ category.name ], merchants: [ merchant.name ]) # transaction specific search param
 
-    assert_equal 2, Account::Entry.search(params).size
+    assert_equal 1, family.entries.search(params).size
   end
 
   test "can calculate total spending for a group of transactions" do
-    assert_equal Money.new(2135), @family.entries.expense_total("USD")
-    assert_equal Money.new(1010.85, "EUR"), @family.entries.expense_total("EUR")
+    family = families(:empty)
+    account = family.accounts.create! name: "Test", balance: 0, accountable: Depository.new
+    create_transaction(account: account, amount: 100)
+    create_transaction(account: account, amount: 100)
+    create_transaction(account: account, amount: -500) # income, will be ignored
+
+    assert_equal Money.new(200), family.entries.expense_total("USD")
   end
 
   test "can calculate total income for a group of transactions" do
-    assert_equal -Money.new(2075), @family.entries.income_total("USD")
-    assert_equal -Money.new(250, "EUR"), @family.entries.income_total("EUR")
+    family = families(:empty)
+    account = family.accounts.create! name: "Test", balance: 0, accountable: Depository.new
+    create_transaction(account: account, amount: -100)
+    create_transaction(account: account, amount: -100)
+    create_transaction(account: account, amount: 500) # income, will be ignored
+
+    assert_equal Money.new(-200), family.entries.income_total("USD")
   end
 
   # See: https://github.com/maybe-finance/maybe/wiki/vision#signage-of-money
   test "transactions with negative amounts are inflows, positive amounts are outflows to an account" do
-    inflow_transaction = account_entries(:checking_four)
-    outflow_transaction = account_entries(:checking_five)
-
-    assert inflow_transaction.amount < 0
-    assert inflow_transaction.inflow?
-
-    assert outflow_transaction.amount >= 0
-    assert outflow_transaction.outflow?
+    assert create_transaction(amount: -10).inflow?
+    assert create_transaction(amount: 10).outflow?
   end
 end