Transaction transfers, payments, and matching (#883)

* Add transfer model and clean up family snapshot fixtures

* Ignore transfers in income and expense snapshots

* Add transfer validations

* Implement basic transfer matching UI

* Fix merge conflicts

* Add missing translations

* Tweak selection states for transfer types

* Add missing i18n translation

test/controllers/transactions_controller_test.rb

@@ -4,7 +4,7 @@ class TransactionsControllerTest < ActionDispatch::IntegrationTest
   setup do
     sign_in @user = users(:family_admin)
     @transaction = transactions(:checking_one)
-    @recent_transactions = @user.family.transactions.ordered.limit(20).to_a
+    @recent_transactions = @user.family.transactions.ordered.where(transfer_id: nil).limit(20).to_a
   end
 
   test "should get paginated index with most recent transactions first" do
@@ -18,7 +18,7 @@ class TransactionsControllerTest < ActionDispatch::IntegrationTest
 
   test "transaction count represents filtered total" do
     get transactions_url
-    assert_dom "#total-transactions", count: 1, text: @user.family.transactions.count.to_s
+    assert_dom "#total-transactions", count: 1, text: @user.family.transactions.select { |t| t.currency == "USD" }.count.to_s
 
     new_transaction = @user.family.accounts.first.transactions.create! \
       name: "Transaction to search for",
@@ -42,7 +42,7 @@ class TransactionsControllerTest < ActionDispatch::IntegrationTest
   end
 
   test "loads last page when page is out of range" do
-    user_oldest_transaction = @user.family.transactions.ordered.last
+    user_oldest_transaction = @user.family.transactions.ordered.reject(&:transfer?).last
     get transactions_url(page: 9999999999)
 
     assert_response :success

test/controllers/transfers_controller_test.rb

@@ -0,0 +1,33 @@
+require "test_helper"
+
+class TransfersControllerTest < ActionDispatch::IntegrationTest
+  setup do
+    sign_in users(:family_admin)
+  end
+
+  test "should get new" do
+    get new_transfer_url
+    assert_response :success
+  end
+
+  test "can create transfers" do
+    assert_difference "Transfer.count", 1 do
+      post transfers_url, params: {
+        transfer: {
+          from_account_id: accounts(:checking).id,
+          to_account_id: accounts(:savings).id,
+          date: Date.current,
+          amount: 100,
+          currency: "USD",
+          name: "Test Transfer"
+        }
+      }
+    end
+  end
+
+  test "can destroy transfer" do
+    assert_difference -> { Transfer.count } => -1, -> { Transaction.count } => 0 do
+      delete transfer_url(transfers(:credit_card_payment))
+    end
+  end
+end