mirror of
https://github.com/maybe-finance/maybe.git
synced 2025-08-02 20:15:22 +02:00
Transaction transfers, payments, and matching (#883)
* Add transfer model and clean up family snapshot fixtures * Ignore transfers in income and expense snapshots * Add transfer validations * Implement basic transfer matching UI * Fix merge conflicts * Add missing translations * Tweak selection states for transfer types * Add missing i18n translation
This commit is contained in:
Zach Gollwitzer
GitHub
parent
b462bc8f8c
commit
ca39b26070
57 changed files with 991 additions and 427 deletions
|
|
@ -2,111 +2,82 @@ require "test_helper"
|
|||
require "csv"
|
||||
|
||||
class Account::Balance::CalculatorTest < ActiveSupport::TestCase
|
||||
# See: https://docs.google.com/spreadsheets/d/18LN5N-VLq4b49Mq1fNwF7_eBiHSQB46qQduRtdAEN98/edit?usp=sharing
|
||||
setup do
|
||||
@expected_balances = CSV.read("test/fixtures/account/expected_balances.csv", headers: true).map do |row|
|
||||
{
|
||||
"date" => (Date.current + row["date_offset"].to_i.days).to_date,
|
||||
"collectable" => row["collectable"],
|
||||
"checking" => row["checking"],
|
||||
"savings_with_valuation_overrides" => row["savings_with_valuation_overrides"],
|
||||
"credit_card" => row["credit_card"],
|
||||
"multi_currency" => row["multi_currency"],
|
||||
include FamilySnapshotTestHelper
|
||||
|
||||
# Balances should be calculated for all currencies of an account
|
||||
"eur_checking_eur" => row["eur_checking_eur"],
|
||||
"eur_checking_usd" => row["eur_checking_usd"]
|
||||
}
|
||||
test "syncs other asset balances" do
|
||||
expected_balances = get_expected_balances_for(:collectable)
|
||||
assert_account_balances calculated_balances_for(:collectable), expected_balances
|
||||
end
|
||||
|
||||
test "syncs other liability balances" do
|
||||
expected_balances = get_expected_balances_for(:iou)
|
||||
assert_account_balances calculated_balances_for(:iou), expected_balances
|
||||
end
|
||||
|
||||
test "syncs credit balances" do
|
||||
expected_balances = get_expected_balances_for :credit_card
|
||||
assert_account_balances calculated_balances_for(:credit_card), expected_balances
|
||||
end
|
||||
|
||||
test "syncs checking account balances" do
|
||||
expected_balances = get_expected_balances_for(:checking)
|
||||
assert_account_balances calculated_balances_for(:checking), expected_balances
|
||||
end
|
||||
|
||||
test "syncs foreign checking account balances" do
|
||||
# Foreign accounts will generate balances for all currencies
|
||||
expected_usd_balances = get_expected_balances_for(:eur_checking_usd)
|
||||
expected_eur_balances = get_expected_balances_for(:eur_checking_eur)
|
||||
|
||||
calculated_balances = calculated_balances_for(:eur_checking)
|
||||
calculated_usd_balances = calculated_balances.select { |b| b[:currency] == "USD" }
|
||||
calculated_eur_balances = calculated_balances.select { |b| b[:currency] == "EUR" }
|
||||
|
||||
assert_account_balances calculated_usd_balances, expected_usd_balances
|
||||
assert_account_balances calculated_eur_balances, expected_eur_balances
|
||||
end
|
||||
|
||||
test "syncs multi-currency checking account balances" do
|
||||
expected_balances = get_expected_balances_for(:multi_currency)
|
||||
assert_account_balances calculated_balances_for(:multi_currency), expected_balances
|
||||
end
|
||||
|
||||
test "syncs savings accounts balances" do
|
||||
expected_balances = get_expected_balances_for(:savings)
|
||||
assert_account_balances calculated_balances_for(:savings), expected_balances
|
||||
end
|
||||
|
||||
test "syncs investment account balances" do
|
||||
expected_balances = get_expected_balances_for(:brokerage)
|
||||
assert_account_balances calculated_balances_for(:brokerage), expected_balances
|
||||
end
|
||||
|
||||
test "syncs loan account balances" do
|
||||
expected_balances = get_expected_balances_for(:mortgage_loan)
|
||||
assert_account_balances calculated_balances_for(:mortgage_loan), expected_balances
|
||||
end
|
||||
|
||||
test "syncs property account balances" do
|
||||
expected_balances = get_expected_balances_for(:house)
|
||||
assert_account_balances calculated_balances_for(:house), expected_balances
|
||||
end
|
||||
|
||||
test "syncs vehicle account balances" do
|
||||
expected_balances = get_expected_balances_for(:car)
|
||||
assert_account_balances calculated_balances_for(:car), expected_balances
|
||||
end
|
||||
|
||||
private
|
||||
def assert_account_balances(actual_balances, expected_balances)
|
||||
assert_equal expected_balances.count, actual_balances.count
|
||||
|
||||
actual_balances.each do |ab|
|
||||
expected_balance = expected_balances.find { |eb| eb[:date] == ab[:date] }
|
||||
assert_in_delta expected_balance[:balance], ab[:balance], 0.01, "Balance incorrect on date: #{ab[:date]}"
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
test "syncs account with only valuations" do
|
||||
account = accounts(:collectable)
|
||||
|
||||
calculator = Account::Balance::Calculator.new(account)
|
||||
calculator.calculate
|
||||
|
||||
expected = @expected_balances.map { |row| row["collectable"].to_d }
|
||||
actual = calculator.daily_balances.map { |b| b[:balance] }
|
||||
|
||||
assert_equal expected, actual
|
||||
end
|
||||
|
||||
test "syncs account with only transactions" do
|
||||
account = accounts(:checking)
|
||||
|
||||
calculator = Account::Balance::Calculator.new(account)
|
||||
calculator.calculate
|
||||
|
||||
expected = @expected_balances.map { |row| row["checking"].to_d }
|
||||
actual = calculator.daily_balances.map { |b| b[:balance] }
|
||||
|
||||
assert_equal expected, actual
|
||||
end
|
||||
|
||||
test "syncs account with both valuations and transactions" do
|
||||
account = accounts(:savings_with_valuation_overrides)
|
||||
|
||||
calculator = Account::Balance::Calculator.new(account)
|
||||
calculator.calculate
|
||||
|
||||
expected = @expected_balances.map { |row| row["savings_with_valuation_overrides"].to_d }
|
||||
actual = calculator.daily_balances.map { |b| b[:balance] }
|
||||
|
||||
assert_equal expected, actual
|
||||
end
|
||||
|
||||
test "syncs liability account" do
|
||||
account = accounts(:credit_card)
|
||||
|
||||
calculator = Account::Balance::Calculator.new(account)
|
||||
calculator.calculate
|
||||
|
||||
expected = @expected_balances.map { |row| row["credit_card"].to_d }
|
||||
actual = calculator.daily_balances.map { |b| b[:balance] }
|
||||
|
||||
assert_equal expected, actual
|
||||
end
|
||||
|
||||
test "syncs foreign currency account" do
|
||||
account = accounts(:eur_checking)
|
||||
calculator = Account::Balance::Calculator.new(account)
|
||||
calculator.calculate
|
||||
|
||||
# Calculator should calculate balances in both account and family currency
|
||||
expected_eur_balances = @expected_balances.map { |row| row["eur_checking_eur"].to_d }
|
||||
expected_usd_balances = @expected_balances.map { |row| row["eur_checking_usd"].to_d }
|
||||
|
||||
actual_eur_balances = calculator.daily_balances.select { |b| b[:currency] == "EUR" }.sort_by { |b| b[:date] }.map { |b| b[:balance] }
|
||||
actual_usd_balances = calculator.daily_balances.select { |b| b[:currency] == "USD" }.sort_by { |b| b[:date] }.map { |b| b[:balance] }
|
||||
|
||||
assert_equal expected_eur_balances, actual_eur_balances
|
||||
assert_equal expected_usd_balances, actual_usd_balances
|
||||
end
|
||||
|
||||
test "syncs multi currency account" do
|
||||
account = accounts(:multi_currency)
|
||||
calculator = Account::Balance::Calculator.new(account)
|
||||
calculator.calculate
|
||||
|
||||
expected_balances = @expected_balances.map { |row| row["multi_currency"].to_d }
|
||||
|
||||
actual_balances = calculator.daily_balances.map { |b| b[:balance] }
|
||||
|
||||
assert_equal expected_balances, actual_balances
|
||||
end
|
||||
|
||||
test "syncs with overridden start date" do
|
||||
account = accounts(:multi_currency)
|
||||
account.sync
|
||||
calc_start_date = 10.days.ago.to_date
|
||||
calculator = Account::Balance::Calculator.new(account, { calc_start_date: })
|
||||
calculator.calculate
|
||||
|
||||
expected_balances = @expected_balances.filter { |row| row["date"] >= calc_start_date }.map { |row| row["multi_currency"].to_d }
|
||||
|
||||
actual_balances = calculator.daily_balances.map { |b| b[:balance] }
|
||||
|
||||
assert_equal expected_balances, actual_balances
|
||||
end
|
||||
def calculated_balances_for(account_key)
|
||||
Account::Balance::Calculator.new(accounts(account_key)).calculate.daily_balances
|
||||
end
|
||||
end
|
||||
|
|
|
|||
|
|
@ -4,7 +4,7 @@ class Account::SyncableTest < ActiveSupport::TestCase
|
|||
include ActiveJob::TestHelper
|
||||
|
||||
setup do
|
||||
@account = accounts(:savings_with_valuation_overrides)
|
||||
@account = accounts(:savings)
|
||||
end
|
||||
|
||||
test "triggers sync job" do
|
||||
|
|
@ -14,27 +14,27 @@ class Account::SyncableTest < ActiveSupport::TestCase
|
|||
end
|
||||
|
||||
test "account has no balances until synced" do
|
||||
account = accounts(:savings_with_valuation_overrides)
|
||||
account = accounts(:savings)
|
||||
|
||||
assert_equal 0, account.balances.count
|
||||
end
|
||||
|
||||
test "account has balances after syncing" do
|
||||
account = accounts(:savings_with_valuation_overrides)
|
||||
account = accounts(:savings)
|
||||
account.sync
|
||||
|
||||
assert_equal 31, account.balances.count
|
||||
assert_equal 32, account.balances.count
|
||||
end
|
||||
|
||||
test "partial sync with missing historical balances performs a full sync" do
|
||||
account = accounts(:savings_with_valuation_overrides)
|
||||
account = accounts(:savings)
|
||||
account.sync 10.days.ago.to_date
|
||||
|
||||
assert_equal 31, account.balances.count
|
||||
assert_equal 32, account.balances.count
|
||||
end
|
||||
|
||||
test "balances are updated after syncing" do
|
||||
account = accounts(:savings_with_valuation_overrides)
|
||||
account = accounts(:savings)
|
||||
balance_date = 10.days.ago
|
||||
account.balances.create!(date: balance_date, balance: 1000)
|
||||
account.sync
|
||||
|
|
@ -43,7 +43,7 @@ class Account::SyncableTest < ActiveSupport::TestCase
|
|||
end
|
||||
|
||||
test "balances before sync start date are not updated after syncing" do
|
||||
account = accounts(:savings_with_valuation_overrides)
|
||||
account = accounts(:savings)
|
||||
balance_date = 10.days.ago
|
||||
account.balances.create!(date: balance_date, balance: 1000)
|
||||
account.sync 5.days.ago.to_date
|
||||
|
|
@ -52,7 +52,7 @@ class Account::SyncableTest < ActiveSupport::TestCase
|
|||
end
|
||||
|
||||
test "balances after sync start date are updated after syncing" do
|
||||
account = accounts(:savings_with_valuation_overrides)
|
||||
account = accounts(:savings)
|
||||
balance_date = 10.days.ago
|
||||
account.balances.create!(date: balance_date, balance: 1000)
|
||||
account.sync 20.days.ago.to_date
|
||||
|
|
@ -61,7 +61,7 @@ class Account::SyncableTest < ActiveSupport::TestCase
|
|||
end
|
||||
|
||||
test "balance on the sync date is updated after syncing" do
|
||||
account = accounts(:savings_with_valuation_overrides)
|
||||
account = accounts(:savings)
|
||||
balance_date = 5.days.ago
|
||||
account.balances.create!(date: balance_date, balance: 1000)
|
||||
account.sync balance_date.to_date
|
||||
|
|
@ -73,13 +73,13 @@ class Account::SyncableTest < ActiveSupport::TestCase
|
|||
account = accounts(:eur_checking)
|
||||
account.sync
|
||||
|
||||
assert_equal 62, account.balances.count
|
||||
assert_equal 31, account.balances.where(currency: "EUR").count
|
||||
assert_equal 31, account.balances.where(currency: "USD").count
|
||||
assert_equal 64, account.balances.count
|
||||
assert_equal 32, account.balances.where(currency: "EUR").count
|
||||
assert_equal 32, account.balances.where(currency: "USD").count
|
||||
end
|
||||
|
||||
test "stale balances are purged after syncing" do
|
||||
account = accounts(:savings_with_valuation_overrides)
|
||||
account = accounts(:savings)
|
||||
|
||||
# Create old, stale balances that should be purged (since they are before account start date)
|
||||
account.balances.create!(date: 1.year.ago, balance: 1000)
|
||||
|
|
@ -88,14 +88,6 @@ class Account::SyncableTest < ActiveSupport::TestCase
|
|||
|
||||
account.sync
|
||||
|
||||
assert_equal 31, account.balances.count
|
||||
end
|
||||
|
||||
test "account balance is updated after sync" do
|
||||
account = accounts(:savings_with_valuation_overrides)
|
||||
|
||||
assert_changes -> { account.balance }, to: 20500 do
|
||||
account.sync
|
||||
end
|
||||
assert_equal 32, account.balances.count
|
||||
end
|
||||
end
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue