Docker/Maybe
Docker/Maybe
1
0
Fork 0
mirror of https://github.com/maybe-finance/maybe.git synced 2025-08-04 13:05:19 +02:00
Code Issues Releases Activity Actions

Simplify rule scope building and action executions

Browse source
This commit is contained in:
Zach Gollwitzer 2025-04-02 11:36:38 -04:00
parent 3bc0c18da0
commit d64e1fc575
5 changed files with 81 additions and 73 deletions
Download patch file Download diff file Expand all files Collapse all files

76
app/models/rule.rb
View file

@ -1,72 +1,30 @@
class Rule < ApplicationRecord
RESOURCE_TYPES = %w[transaction].freeze
belongs_to :family
has_many :conditions, dependent: :destroy
has_many :actions, dependent: :destroy
validates :effective_date, presence: true
def get_operator_symbol(operator)
case operator
when "gt"
">"
when "lt"
"<"
when "eq"
"="
end
end
validates :resource_type, inclusion: { in: RESOURCE_TYPES }
def apply
case resource_type
when "transaction"
scope = family.transactions
scope = resource_scope
conditions.each do |condition|
case condition.condition_type
when "match_merchant"
scope = scope.left_joins(:merchant).where(merchant: { name: condition.value })
when "compare_amount"
operator_symbol = get_operator_symbol(condition.operator)
scope = scope.joins(:entry)
.where("account_entries.amount #{Arel.sql(operator_symbol)} ?", condition.value)
when "compound"
subconditions = condition.conditions
conditions.each do |condition|
scope = condition.apply(scope)
end
subconditions.each do |subcondition|
case condition.operator
when "and"
case subcondition.condition_type
when "match_merchant"
scope = scope.left_joins(:merchant).where(merchant: { name: subcondition.value })
when "compare_amount"
operator_symbol = get_operator_symbol(subcondition.operator)
scope = scope.joins(:entry)
.where("account_entries.amount #{Arel.sql(operator_symbol)} ?", subcondition.value.to_f)
end
when "or"
raise "not implemented yet"
else
raise "Invalid compound operator"
end
end
else
raise "Unsupported condition type: #{condition.condition_type}"
end
end
scope.each do |transaction|
actions.each do |action|
case action.action_type
when "set_category"
category = family.categories.find_by(name: action.value)
transaction.update!(category: category)
else
raise "Unsupported action type: #{action.action_type}"
end
end
end
else
raise "Unsupported resource type: #{resource_type}"
actions.each do |action|
action.apply(scope)
end
end
private
def resource_scope
case resource_type
when "transaction"
family.transactions
end
end
end