New Design System + Codebase Refresh (#1823)

Since the very first 0.1.0-alpha.1 release, we've been moving quickly to add new features to the Maybe app. In doing so, some parts of the codebase have become outdated, unnecessary, or overly-complex as a natural result of this feature prioritization.

Now that "core" Maybe is complete, we're moving into a second phase of development where we'll be working hard to improve the accuracy of existing features and build additional features on top of "core". This PR is a quick overhaul of the existing codebase aimed to:

- Establish the brand new and simplified dashboard view (pictured above)
- Establish and move towards the conventions introduced in Cursor rules and project design overview #1788
- Consolidate layouts and improve the performance of layout queries
- Organize the core models of the Maybe domain (i.e. Account::Entry, Account::Transaction, etc.) and break out specific traits of each model into dedicated concerns for better readability
- Remove stale / dead code from codebase
- Remove overly complex code paths in favor of simpler ones

app/helpers/account/entries_helper.rb

@@ -1,22 +1,13 @@
 module Account::EntriesHelper
-  def permitted_entryable_partial_path(entry, relative_partial_path)
-    "account/entries/entryables/#{permitted_entryable_key(entry)}/#{relative_partial_path}"
-  end
-
-  def transfer_entries(entries)
-    transfers = entries.select { |e| e.transfer_id.present? }
-    transfers.map(&:transfer).uniq
-  end
-
-  def entries_by_date(entries, transfers: [], selectable: true, totals: false)
+  def entries_by_date(entries, totals: false)
     entries.group_by(&:date).map do |date, grouped_entries|
       content = capture do
-        yield [ grouped_entries, transfers.select { |t| t.outflow_transaction.entry.date == date } ]
+        yield grouped_entries
       end
 
       next if content.blank?
 
-      render partial: "account/entries/entry_group", locals: { date:, entries: grouped_entries, content:, selectable:, totals: }
+      render partial: "account/entries/entry_group", locals: { date:, entries: grouped_entries, content:, totals: }
     end.compact.join.html_safe
   end
 
@@ -28,11 +19,4 @@ module Account::EntriesHelper
       entry.display_name
     ].join(" • ")
   end
-
-  private
-
-    def permitted_entryable_key(entry)
-      permitted_entryable_paths = %w[transaction valuation trade]
-      entry.entryable_name_short.presence_in(permitted_entryable_paths)
-    end
 end

app/helpers/account/holdings_helper.rb

@@ -1,13 +0,0 @@
-module Account::HoldingsHelper
-  def brokerage_cash_holding(account)
-    currency = Money::Currency.new(account.currency)
-
-    account.holdings.build \
-      date: Date.current,
-      qty: account.cash_balance,
-      price: 1,
-      amount: account.cash_balance,
-      currency: currency.iso_code,
-      security: Security.new(ticker: currency.iso_code, name: currency.name)
-  end
-end

app/helpers/accounts_helper.rb

@@ -1,87 +1,6 @@
 module AccountsHelper
-  def period_label(period)
-    return "since account creation" if period.date_range.begin.nil?
-    start_date, end_date = period.date_range.first, period.date_range.last
-
-    return "Starting from #{start_date.strftime('%b %d, %Y')}" if end_date.nil?
-    return "Ending at #{end_date.strftime('%b %d, %Y')}" if start_date.nil?
-
-    days_apart = (end_date - start_date).to_i
-
-    # Handle specific cases
-    if start_date == Date.current.beginning_of_week && end_date == Date.current
-      return "Current Week to Date (CWD)"
-    elsif start_date == Date.current.beginning_of_month && end_date == Date.current
-      return "Current Month to Date (MTD)"
-    elsif start_date == Date.current.beginning_of_quarter && end_date == Date.current
-      return "Current Quarter to Date (CQD)"
-    elsif start_date == Date.current.beginning_of_year && end_date == Date.current
-      return "Current Year to Date (YTD)"
-    end
-
-    # Default cases
-    case days_apart
-    when 1
-      "vs. yesterday"
-    when 7
-      "vs. last week"
-    when 30, 31
-      "vs. last month"
-    when 90
-      "vs. last 3 months"
-    when 365, 366
-      "vs. last year"
-    else
-      "from #{start_date.strftime('%b %d, %Y')} to #{end_date.strftime('%b %d, %Y')}"
-    end
-  end
-
   def summary_card(title:, &block)
     content = capture(&block)
     render "accounts/summary_card", title: title, content: content
   end
-
-  def to_accountable_title(accountable)
-    accountable.model_name.human
-  end
-
-  def accountable_text_class(accountable_type)
-    class_mapping(accountable_type)[:text]
-  end
-
-  def accountable_fill_class(accountable_type)
-    class_mapping(accountable_type)[:fill]
-  end
-
-  def accountable_bg_class(accountable_type)
-    class_mapping(accountable_type)[:bg]
-  end
-
-  def accountable_bg_transparent_class(accountable_type)
-    class_mapping(accountable_type)[:bg_transparent]
-  end
-
-  def accountable_color(accountable_type)
-    class_mapping(accountable_type)[:hex]
-  end
-
-  def account_groups(period: nil)
-    assets, liabilities = Current.family.accounts.active.by_group(currency: Current.family.currency, period: period || Period.last_30_days).values_at(:assets, :liabilities)
-    [ assets.children.sort_by(&:name), liabilities.children.sort_by(&:name) ].flatten
-  end
-
-  private
-
-    def class_mapping(accountable_type)
-      {
-        "CreditCard" => { text: "text-red-500", bg: "bg-red-500", bg_transparent: "bg-red-500/10", fill: "fill-red-500", hex: "#F13636" },
-        "Loan" => { text: "text-fuchsia-500", bg: "bg-fuchsia-500", bg_transparent: "bg-fuchsia-500/10", fill: "fill-fuchsia-500", hex: "#D444F1" },
-        "OtherLiability" => { text: "text-secondary", bg: "bg-gray-500", bg_transparent: "bg-gray-500/10", fill: "fill-gray-500", hex: "#737373" },
-        "Depository" => { text: "text-violet-500", bg: "bg-violet-500", bg_transparent: "bg-violet-500/10", fill: "fill-violet-500", hex: "#875BF7" },
-        "Investment" => { text: "text-blue-600", bg: "bg-blue-600", bg_transparent: "bg-blue-600/10", fill: "fill-blue-600", hex: "#1570EF" },
-        "OtherAsset" => { text: "text-green-500", bg: "bg-green-500", bg_transparent: "bg-green-500/10", fill: "fill-green-500", hex: "#12B76A" },
-        "Property" => { text: "text-cyan-500", bg: "bg-cyan-500", bg_transparent: "bg-cyan-500/10", fill: "fill-cyan-500", hex: "#06AED4" },
-        "Vehicle" => { text: "text-pink-500", bg: "bg-pink-500", bg_transparent: "bg-pink-500/10", fill: "fill-pink-500", hex: "#F23E94" }
-      }.fetch(accountable_type, { text: "text-secondary", bg: "bg-gray-500", bg_transparent: "bg-gray-500/10", fill: "fill-gray-500", hex: "#737373" })
-    end
 end

app/helpers/application_helper.rb

@@ -72,18 +72,8 @@ module ApplicationHelper
     render partial: "shared/disclosure", locals: { title: title, content: content, open: default_open }
   end
 
-  def sidebar_link_to(name, path, options = {})
-    is_current = current_page?(path) || (request.path.start_with?(path) && path != "/")
-
-    classes = [
-      "flex items-center gap-2 px-3 py-2 rounded-xl border text-sm font-medium text-secondary",
-      (is_current ? "bg-white text-primary shadow-xs border-alpha-black-50" : "hover:bg-gray-100 border-transparent")
-    ].compact.join(" ")
-
-    link_to path, **options.merge(class: classes), aria: { current: ("page" if current_page?(path)) } do
-      concat(lucide_icon(options[:icon], class: "w-5 h-5")) if options[:icon]
-      concat(name)
-    end
+  def page_active?(path)
+    current_page?(path) || (request.path.start_with?(path) && path != "/")
   end
 
   def mixed_hex_styles(hex)
@@ -105,24 +95,6 @@ module ApplicationHelper
     uri.relative? ? uri.path : root_path
   end
 
-  def trend_styles(trend)
-    fallback = { bg_class: "bg-gray-500/5", text_class: "text-secondary", symbol: "", icon: "minus" }
-    return fallback if trend.nil? || trend.direction.flat?
-
-    bg_class, text_class, symbol, icon = case trend.direction
-    when "up"
-      trend.favorable_direction.down? ? [ "bg-red-500/5", "text-red-500", "+", "arrow-up" ] : [ "bg-green-500/5", "text-green-500", "+", "arrow-up" ]
-    when "down"
-      trend.favorable_direction.down? ? [ "bg-green-500/5", "text-green-500", "-", "arrow-down" ] : [ "bg-red-500/5", "text-red-500", "-", "arrow-down" ]
-    when "flat"
-      [ "bg-gray-500/5", "text-secondary", "", "minus" ]
-    else
-      raise ArgumentError, "Invalid trend direction: #{trend.direction}"
-    end
-
-    { bg_class: bg_class, text_class: text_class, symbol: symbol, icon: icon }
-  end
-
   # Wrapper around I18n.l to support custom date formats
   def format_date(object, format = :default, options = {})
     date = object.to_date
@@ -139,17 +111,7 @@ module ApplicationHelper
   def format_money(number_or_money, options = {})
     return nil unless number_or_money
 
-    money = Money.new(number_or_money)
-    options.reverse_merge!(money.format_options(I18n.locale))
-    number_to_currency(money.amount, options)
-  end
-
-  def format_money_without_symbol(number_or_money, options = {})
-    return nil unless number_or_money
-
-    money = Money.new(number_or_money)
-    options.reverse_merge!(money.format_options(I18n.locale))
-    ActiveSupport::NumberHelper.number_to_delimited(money.amount.round(options[:precision] || 0), { delimiter: options[:delimiter], separator: options[:separator] })
+    Money.new(number_or_money).format(options)
   end
 
   def totals_by_currency(collection:, money_method:, separator: " | ", negate: false)
@@ -168,7 +130,6 @@ module ApplicationHelper
   end
 
   private
-
     def calculate_total(item, money_method, negate)
       items = item.reject { |i| i.respond_to?(:entryable) && i.entryable.transfer? }
       total = items.sum(&money_method)

app/helpers/email_confirmations_helper.rb

@@ -1,2 +0,0 @@
-module EmailConfirmationsHelper
-end

app/helpers/forms_helper.rb

@@ -18,18 +18,9 @@ module FormsHelper
   end
 
   def period_select(form:, selected:, classes: "border border-tertiary shadow-xs rounded-lg text-sm pr-7 cursor-pointer text-primary focus:outline-hidden focus:ring-0")
-    periods_for_select = [
-      %w[CWD current_week], # Current Week to Date
-      %w[7D last_7_days],
-      %w[MTD current_month], # Month to Date
-      %w[1M last_30_days],
-      %w[CQD current_quarter], # Quarter to Date
-      %w[3M last_90_days],
-      %w[YTD current_year], # Year to Date
-      %w[1Y last_365_days]
-    ]
+    periods_for_select = Period.all.map { |period| [ period.label_short, period.key ] }
 
-    form.select(:period, periods_for_select, { selected: selected }, class: classes, data: { "auto-submit-form-target": "auto" })
+    form.select(:period, periods_for_select, { selected: selected.key }, class: classes, data: { "auto-submit-form-target": "auto" })
 end
 
 

app/helpers/impersonation_sessions_helper.rb

@@ -1,2 +0,0 @@
-module ImpersonationSessionsHelper
-end

app/helpers/invitations_helper.rb

@@ -1,2 +0,0 @@
-module InvitationsHelper
-end

app/helpers/pages_helper.rb

@@ -1,2 +0,0 @@
-module PagesHelper
-end

app/helpers/properties_helper.rb

@@ -1,2 +0,0 @@
-module PropertiesHelper
-end

app/helpers/securities_helper.rb

@@ -1,2 +0,0 @@
-module SecuritiesHelper
-end

app/helpers/settings/billing_helper.rb

@@ -1,2 +0,0 @@
-module Settings::BillingHelper
-end

app/helpers/settings/hosting_helper.rb

@@ -1,2 +0,0 @@
-module Settings::HostingHelper
-end

app/helpers/settings_helper.rb

@@ -1,17 +1,17 @@
 module SettingsHelper
   SETTINGS_ORDER = [
-    { name: I18n.t("settings.nav.profile_label"), path: :settings_profile_path },
-    { name: I18n.t("settings.nav.preferences_label"), path: :settings_preferences_path },
-    { name: I18n.t("settings.nav.self_hosting_label"), path: :settings_hosting_path, condition: :self_hosted? },
-    { name: I18n.t("settings.nav.security_label"), path: :settings_security_path },
-    { name: I18n.t("settings.nav.billing_label"), path: :settings_billing_path },
-    { name: I18n.t("settings.nav.accounts_label"), path: :accounts_path },
-    { name: I18n.t("settings.nav.imports_label"), path: :imports_path },
-    { name: I18n.t("settings.nav.tags_label"), path: :tags_path },
-    { name: I18n.t("settings.nav.categories_label"), path: :categories_path },
-    { name: I18n.t("settings.nav.merchants_label"), path: :merchants_path },
-    { name: I18n.t("settings.nav.whats_new_label"), path: :changelog_path },
-    { name: I18n.t("settings.nav.feedback_label"), path: :feedback_path }
+    { name: I18n.t("settings.settings_nav.profile_label"), path: :settings_profile_path },
+    { name: I18n.t("settings.settings_nav.preferences_label"), path: :settings_preferences_path },
+    { name: I18n.t("settings.settings_nav.security_label"), path: :settings_security_path },
+    { name: I18n.t("settings.settings_nav.self_hosting_label"), path: :settings_hosting_path, condition: :self_hosted? },
+    { name: I18n.t("settings.settings_nav.billing_label"), path: :settings_billing_path },
+    { name: I18n.t("settings.settings_nav.accounts_label"), path: :accounts_path },
+    { name: I18n.t("settings.settings_nav.imports_label"), path: :imports_path },
+    { name: I18n.t("settings.settings_nav.tags_label"), path: :tags_path },
+    { name: I18n.t("settings.settings_nav.categories_label"), path: :categories_path },
+    { name: I18n.t("settings.settings_nav.merchants_label"), path: :merchants_path },
+    { name: I18n.t("settings.settings_nav.whats_new_label"), path: :changelog_path },
+    { name: I18n.t("settings.settings_nav.feedback_label"), path: :feedback_path }
   ]
 
   def adjacent_setting(current_path, offset)
@@ -24,7 +24,7 @@ module SettingsHelper
 
     adjacent = visible_settings[adjacent_index]
 
-    render partial: "settings/nav_link_large", locals: {
+    render partial: "settings/settings_nav_link_large", locals: {
       path: send(adjacent[:path]),
       direction: offset > 0 ? "next" : "previous",
       title: adjacent[:name]

app/helpers/subscription_helper.rb

@@ -1,2 +0,0 @@
-module SubscriptionHelper
-end

app/helpers/tags_helper.rb

@@ -1,7 +0,0 @@
-module TagsHelper
-  def null_tag
-    Tag.new \
-      name: "Uncategorized",
-      color: Tag::UNCATEGORIZED_COLOR
-  end
-end

app/helpers/value_groups_helper.rb

@@ -1,13 +0,0 @@
-module ValueGroupsHelper
-  def value_group_pie_data(value_group)
-    value_group.children.filter { |c| c.sum > 0 }.map do |child|
-      {
-        label: to_accountable_title(Accountable.from_type(child.name)),
-        percent_of_total: child.percent_of_total.round(1).to_f,
-        formatted_value: format_money(child.sum, precision: 0),
-        bg_color: accountable_bg_class(child.name),
-        fill_color: accountable_fill_class(child.name)
-      }
-    end.to_json
-  end
-end

app/helpers/vehicles_helper.rb

@@ -1,2 +0,0 @@
-module VehiclesHelper
-end

app/helpers/webhooks_helper.rb

@@ -1,2 +0,0 @@
-module WebhooksHelper
-end