New Design System + Codebase Refresh (#1823)

Since the very first 0.1.0-alpha.1 release, we've been moving quickly to add new features to the Maybe app. In doing so, some parts of the codebase have become outdated, unnecessary, or overly-complex as a natural result of this feature prioritization.

Now that "core" Maybe is complete, we're moving into a second phase of development where we'll be working hard to improve the accuracy of existing features and build additional features on top of "core". This PR is a quick overhaul of the existing codebase aimed to:

- Establish the brand new and simplified dashboard view (pictured above)
- Establish and move towards the conventions introduced in Cursor rules and project design overview #1788
- Consolidate layouts and improve the performance of layout queries
- Organize the core models of the Maybe domain (i.e. Account::Entry, Account::Transaction, etc.) and break out specific traits of each model into dedicated concerns for better readability
- Remove stale / dead code from codebase
- Remove overly complex code paths in favor of simpler ones

app/models/concerns/accountable.rb

@@ -1,23 +1,50 @@
 module Accountable
   extend ActiveSupport::Concern
 
-  ASSET_TYPES = %w[Depository Investment Crypto Property Vehicle OtherAsset]
-  LIABILITY_TYPES = %w[CreditCard Loan OtherLiability]
-  TYPES = ASSET_TYPES + LIABILITY_TYPES
+  TYPES = %w[Depository Investment Crypto Property Vehicle OtherAsset CreditCard Loan OtherLiability]
 
   def self.from_type(type)
     return nil unless TYPES.include?(type)
     type.constantize
   end
 
-  def self.by_classification
-    { assets: ASSET_TYPES, liabilities: LIABILITY_TYPES }
-  end
-
   included do
     has_one :account, as: :accountable, touch: true
   end
 
+  class_methods do
+    def classification
+      raise NotImplementedError, "Accountable must implement #classification"
+    end
+
+    def icon
+      raise NotImplementedError, "Accountable must implement #icon"
+    end
+
+    def color
+      raise NotImplementedError, "Accountable must implement #color"
+    end
+
+    def favorable_direction
+      classification == "asset" ? "up" : "down"
+    end
+
+    def display_name
+      self.name.pluralize.titleize
+    end
+
+    def balance_money(family)
+      family.accounts
+            .active
+            .joins(sanitize_sql_array([
+              "LEFT JOIN exchange_rates ON exchange_rates.date = :current_date AND accounts.currency = exchange_rates.from_currency AND exchange_rates.to_currency = :family_currency",
+              { current_date: Date.current.to_s, family_currency: family.currency }
+            ]))
+            .where(accountable_type: self.name)
+            .sum("accounts.balance * COALESCE(exchange_rates.rate, 1)")
+    end
+  end
+
   def post_sync
     broadcast_replace_to(
       account,
@@ -26,4 +53,20 @@ module Accountable
       locals: { account: account }
     )
   end
+
+  def display_name
+    self.class.display_name
+  end
+
+  def icon
+    self.class.icon
+  end
+
+  def color
+    self.class.color
+  end
+
+  def classification
+    self.class.classification
+  end
 end

app/models/concerns/monetizable.rb

@@ -4,11 +4,19 @@ module Monetizable
   class_methods do
     def monetize(*fields)
       fields.each do |field|
-        define_method("#{field}_money") do
-          value = self.send(field)
-          value.nil? ? nil : Money.new(value, currency || Money.default_currency)
+        define_method("#{field}_money") do |**args|
+          value = self.send(field, **args)
+
+          return nil if value.nil? || monetizable_currency.nil?
+
+          Money.new(value, monetizable_currency)
         end
       end
     end
   end
+
+  private
+    def monetizable_currency
+      currency
+    end
 end