1
0
Fork 0
mirror of https://github.com/maybe-finance/maybe.git synced 2025-07-19 05:09:38 +02:00

New Design System + Codebase Refresh (#1823)

Since the very first 0.1.0-alpha.1 release, we've been moving quickly to add new features to the Maybe app. In doing so, some parts of the codebase have become outdated, unnecessary, or overly-complex as a natural result of this feature prioritization.

Now that "core" Maybe is complete, we're moving into a second phase of development where we'll be working hard to improve the accuracy of existing features and build additional features on top of "core". This PR is a quick overhaul of the existing codebase aimed to:

- Establish the brand new and simplified dashboard view (pictured above)
- Establish and move towards the conventions introduced in Cursor rules and project design overview #1788
- Consolidate layouts and improve the performance of layout queries
- Organize the core models of the Maybe domain (i.e. Account::Entry, Account::Transaction, etc.) and break out specific traits of each model into dedicated concerns for better readability
- Remove stale / dead code from codebase
- Remove overly complex code paths in favor of simpler ones
This commit is contained in:
Zach Gollwitzer 2025-02-21 11:57:59 -05:00 committed by GitHub
parent 8539ac7dec
commit d75be2282b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
278 changed files with 3428 additions and 4354 deletions

View file

@ -55,7 +55,7 @@ class Money
end
def as_json
{ amount: amount, currency: currency.iso_code }.as_json
{ amount: amount, currency: currency.iso_code, formatted: format }.as_json
end
def <=>(other)

View file

@ -54,6 +54,10 @@ module Money::Arithmetic
amount.positive?
end
def to_f
amount.to_f
end
# Override Ruby's coerce method so the order of operands doesn't matter
# Wrap in Coerced so we can distinguish between Money and other types
def coerce(other)

View file

@ -1,11 +1,11 @@
module Money::Formatting
# Fallback formatting. For advanced formatting, use Rails number_to_currency helper.
def format
whole_part, fractional_part = sprintf("%.#{currency.default_precision}f", amount).split(".")
whole_with_delimiters = whole_part.chars.to_a.reverse.each_slice(3).map(&:join).join(currency.delimiter).reverse
formatted_amount = "#{whole_with_delimiters}#{currency.separator}#{fractional_part}"
include ActiveSupport::NumberHelper
currency.default_format.gsub("%n", formatted_amount).gsub("%u", currency.symbol)
def format(options = {})
locale = options[:locale] || I18n.locale
default_opts = format_options(locale)
number_to_currency(amount, default_opts.merge(options))
end
alias_method :to_s, :format

View file

@ -5,8 +5,13 @@ namespace :demo_data do
Demo::Generator.new.reset_and_clear_data!(families)
end
task reset: :environment do
families = [ "Demo Family 1", "Demo Family 2", "Demo Family 3", "Demo Family 4", "Demo Family 5" ]
task :reset, [ :count ] => :environment do |t, args|
count = (args[:count] || 1).to_i
families = count.times.map { |i| "Demo Family #{i + 1}" }
Demo::Generator.new.reset_data!(families)
end
task multi_currency: :environment do
Demo::Generator.new.generate_multi_currency_data!
end
end