New Design System + Codebase Refresh (#1823)

Since the very first 0.1.0-alpha.1 release, we've been moving quickly to add new features to the Maybe app. In doing so, some parts of the codebase have become outdated, unnecessary, or overly-complex as a natural result of this feature prioritization.

Now that "core" Maybe is complete, we're moving into a second phase of development where we'll be working hard to improve the accuracy of existing features and build additional features on top of "core". This PR is a quick overhaul of the existing codebase aimed to:

- Establish the brand new and simplified dashboard view (pictured above)
- Establish and move towards the conventions introduced in Cursor rules and project design overview #1788
- Consolidate layouts and improve the performance of layout queries
- Organize the core models of the Maybe domain (i.e. Account::Entry, Account::Transaction, etc.) and break out specific traits of each model into dedicated concerns for better readability
- Remove stale / dead code from codebase
- Remove overly complex code paths in favor of simpler ones

test/models/account/balance_calculator_test.rb

@@ -113,9 +113,9 @@ class Account::BalanceCalculatorTest < ActiveSupport::TestCase
     create_trade(securities(:msft), account: @account, date: 1.day.ago.to_date, qty: 20, price: 100)
 
     holdings = [
-      Account::Holding.new(date: Date.current, security: securities(:msft), amount: 2000),
-      Account::Holding.new(date: 1.day.ago.to_date, security: securities(:msft), amount: 2000),
-      Account::Holding.new(date: 2.days.ago.to_date, security: securities(:msft), amount: 0)
+      Account::Holding.new(date: Date.current, security: securities(:msft), amount: 2000, currency: "USD"),
+      Account::Holding.new(date: 1.day.ago.to_date, security: securities(:msft), amount: 2000, currency: "USD"),
+      Account::Holding.new(date: 2.days.ago.to_date, security: securities(:msft), amount: 0, currency: "USD")
     ]
 
     expected = [ 0, 20000, 20000, 20000 ]

test/models/account/chartable_test.rb

@@ -0,0 +1,38 @@
+require "test_helper"
+
+class Account::ChartableTest < ActiveSupport::TestCase
+  test "generates gapfilled balance series" do
+    account = accounts(:depository)
+    account.balances.delete_all
+
+    account.balances.create!(date: 20.days.ago.to_date, balance: 5000, currency: "USD")
+    account.balances.create!(date: 10.days.ago.to_date, balance: 5000, currency: "USD")
+
+    period = Period.last_30_days
+    series = account.balance_series(period: period)
+    assert_equal period.days, series.values.count
+    assert_equal 0, series.values.first.trend.current.amount
+    assert_equal 5000, series.values.find { |v| v.date == 20.days.ago.to_date }.trend.current.amount
+    assert_equal 5000, series.values.find { |v| v.date == 10.days.ago.to_date }.trend.current.amount
+    assert_equal 5000, series.values.last.trend.current.amount
+  end
+
+  test "combines assets and liabilities for multiple accounts properly" do
+    family = families(:empty)
+
+    asset = family.accounts.create!(name: "Asset", currency: "USD", balance: 5000, accountable: Depository.new)
+    liability = family.accounts.create!(name: "Liability", currency: "USD", balance: 2000, accountable: CreditCard.new)
+
+    asset.balances.create!(date: 20.days.ago.to_date, balance: 4000, currency: "USD")
+    asset.balances.create!(date: 10.days.ago.to_date, balance: 5000, currency: "USD")
+
+    liability.balances.create!(date: 20.days.ago.to_date, balance: 1000, currency: "USD")
+    liability.balances.create!(date: 10.days.ago.to_date, balance: 1500, currency: "USD")
+
+    series = family.accounts.balance_series(currency: "USD", period: Period.last_30_days)
+
+    assert_equal 0, series.values.first.trend.current.amount
+    assert_equal 3000, series.values.find { |v| v.date == 20.days.ago.to_date }.trend.current.amount
+    assert_equal 3500, series.values.last.trend.current.amount
+  end
+end

test/models/account/entry_test.rb

@@ -67,30 +67,13 @@ class Account::EntryTest < ActiveSupport::TestCase
     assert_equal 0, family.entries.search(params).size
   end
 
-  test "can calculate totals for a group of transactions" do
-    family = families(:empty)
-    account = family.accounts.create! name: "Test", balance: 0, currency: "USD", accountable: Depository.new
-    create_transaction(account: account, amount: 100)
-    create_transaction(account: account, amount: 100)
-    create_transaction(account: account, amount: -500)
-
-    totals = family.entries.stats("USD")
-
-    assert_equal 3, totals.count
-    assert_equal 500, totals.income_total
-    assert_equal 200, totals.expense_total
-    assert_equal "USD", totals.currency
-  end
-
-  test "active scope only returns entries from active, non-scheduled-for-deletion accounts" do
+  test "active scope only returns entries from active accounts" do
     # Create transactions for all account types
     active_transaction = create_transaction(account: accounts(:depository), name: "Active transaction")
     inactive_transaction = create_transaction(account: accounts(:credit_card), name: "Inactive transaction")
-    deletion_transaction = create_transaction(account: accounts(:investment), name: "Scheduled for deletion transaction")
 
     # Update account statuses
     accounts(:credit_card).update!(is_active: false)
-    accounts(:investment).update!(scheduled_for_deletion: true)
 
     # Test the scope
     active_entries = Account::Entry.active
@@ -100,8 +83,5 @@ class Account::EntryTest < ActiveSupport::TestCase
 
     # Should not include entry from inactive account
     assert_not_includes active_entries, inactive_transaction
-
-    # Should not include entry from account scheduled for deletion
-    assert_not_includes active_entries, deletion_transaction
   end
 end

test/models/account/issue_test.rb

@@ -1,7 +0,0 @@
-require "test_helper"
-
-class Account::IssueTest < ActiveSupport::TestCase
-  test "the truth" do
-    assert true
-  end
-end

test/models/account/trade_test.rb

@@ -1,4 +0,0 @@
-require "test_helper"
-
-class Account::TradeTest < ActiveSupport::TestCase
-end

test/models/account/transaction_test.rb

@@ -0,0 +1,5 @@
+require "test_helper"
+
+class Account::TransactionTest < ActiveSupport::TestCase
+  include Account::EntriesTestHelper
+end