mirror of
https://github.com/maybe-finance/maybe.git
synced 2025-08-02 12:05:19 +02:00
New Design System + Codebase Refresh (#1823)
Since the very first 0.1.0-alpha.1 release, we've been moving quickly to add new features to the Maybe app. In doing so, some parts of the codebase have become outdated, unnecessary, or overly-complex as a natural result of this feature prioritization. Now that "core" Maybe is complete, we're moving into a second phase of development where we'll be working hard to improve the accuracy of existing features and build additional features on top of "core". This PR is a quick overhaul of the existing codebase aimed to: - Establish the brand new and simplified dashboard view (pictured above) - Establish and move towards the conventions introduced in Cursor rules and project design overview #1788 - Consolidate layouts and improve the performance of layout queries - Organize the core models of the Maybe domain (i.e. Account::Entry, Account::Transaction, etc.) and break out specific traits of each model into dedicated concerns for better readability - Remove stale / dead code from codebase - Remove overly complex code paths in favor of simpler ones
This commit is contained in:
Zach Gollwitzer
GitHub
parent
8539ac7dec
commit
d75be2282b
278 changed files with 3428 additions and 4354 deletions
|
|
@ -26,135 +26,4 @@ class FamilyTest < ActiveSupport::TestCase
|
|||
|
||||
@syncable.sync_data(start_date: family_sync.start_date)
|
||||
end
|
||||
|
||||
test "calculates assets" do
|
||||
assert_equal Money.new(0, @family.currency), @family.assets
|
||||
|
||||
create_account(balance: 1000, accountable: Depository.new)
|
||||
create_account(balance: 5000, accountable: OtherAsset.new)
|
||||
create_account(balance: 10000, accountable: CreditCard.new) # ignored
|
||||
|
||||
assert_equal Money.new(1000 + 5000, @family.currency), @family.assets
|
||||
end
|
||||
|
||||
test "calculates liabilities" do
|
||||
assert_equal Money.new(0, @family.currency), @family.liabilities
|
||||
|
||||
create_account(balance: 1000, accountable: CreditCard.new)
|
||||
create_account(balance: 5000, accountable: OtherLiability.new)
|
||||
create_account(balance: 10000, accountable: Depository.new) # ignored
|
||||
|
||||
assert_equal Money.new(1000 + 5000, @family.currency), @family.liabilities
|
||||
end
|
||||
|
||||
test "calculates net worth" do
|
||||
assert_equal Money.new(0, @family.currency), @family.net_worth
|
||||
|
||||
create_account(balance: 1000, accountable: CreditCard.new)
|
||||
create_account(balance: 50000, accountable: Depository.new)
|
||||
|
||||
assert_equal Money.new(50000 - 1000, @family.currency), @family.net_worth
|
||||
end
|
||||
|
||||
test "should exclude disabled accounts from calculations" do
|
||||
cc = create_account(balance: 1000, accountable: CreditCard.new)
|
||||
create_account(balance: 50000, accountable: Depository.new)
|
||||
|
||||
assert_equal Money.new(50000 - 1000, @family.currency), @family.net_worth
|
||||
|
||||
cc.update! is_active: false
|
||||
|
||||
assert_equal Money.new(50000, @family.currency), @family.net_worth
|
||||
end
|
||||
|
||||
test "calculates snapshot" do
|
||||
asset = create_account(balance: 500, accountable: Depository.new)
|
||||
liability = create_account(balance: 100, accountable: CreditCard.new)
|
||||
|
||||
asset.balances.create! date: 1.day.ago.to_date, currency: "USD", balance: 450
|
||||
asset.balances.create! date: Date.current, currency: "USD", balance: 500
|
||||
|
||||
liability.balances.create! date: 1.day.ago.to_date, currency: "USD", balance: 50
|
||||
liability.balances.create! date: Date.current, currency: "USD", balance: 100
|
||||
|
||||
expected_asset_series = [
|
||||
{ date: 1.day.ago.to_date, value: Money.new(450) },
|
||||
{ date: Date.current, value: Money.new(500) }
|
||||
]
|
||||
|
||||
expected_liability_series = [
|
||||
{ date: 1.day.ago.to_date, value: Money.new(50) },
|
||||
{ date: Date.current, value: Money.new(100) }
|
||||
]
|
||||
|
||||
expected_net_worth_series = [
|
||||
{ date: 1.day.ago.to_date, value: Money.new(450 - 50) },
|
||||
{ date: Date.current, value: Money.new(500 - 100) }
|
||||
]
|
||||
|
||||
assert_equal expected_asset_series, @family.snapshot[:asset_series].values.map { |v| { date: v.date, value: v.value } }
|
||||
assert_equal expected_liability_series, @family.snapshot[:liability_series].values.map { |v| { date: v.date, value: v.value } }
|
||||
assert_equal expected_net_worth_series, @family.snapshot[:net_worth_series].values.map { |v| { date: v.date, value: v.value } }
|
||||
end
|
||||
|
||||
test "calculates top movers" do
|
||||
checking_account = create_account(balance: 500, accountable: Depository.new)
|
||||
savings_account = create_account(balance: 1000, accountable: Depository.new)
|
||||
create_transaction(account: checking_account, date: 2.days.ago.to_date, amount: -1000)
|
||||
create_transaction(account: checking_account, date: 1.day.ago.to_date, amount: 10)
|
||||
create_transaction(account: savings_account, date: 2.days.ago.to_date, amount: -5000)
|
||||
|
||||
zero_income_zero_expense_account = create_account(balance: 200, accountable: Depository.new)
|
||||
create_transaction(account: zero_income_zero_expense_account, amount: 0)
|
||||
|
||||
snapshot = @family.snapshot_account_transactions
|
||||
top_spenders = snapshot[:top_spenders]
|
||||
top_earners = snapshot[:top_earners]
|
||||
top_savers = snapshot[:top_savers]
|
||||
|
||||
assert_equal [ 10 ], top_spenders.map(&:spending)
|
||||
assert_equal [ 5000, 1000 ], top_earners.map(&:income)
|
||||
assert_equal [ 1, 0.99 ], top_savers.map(&:savings_rate)
|
||||
end
|
||||
|
||||
|
||||
test "calculates rolling transaction totals" do
|
||||
account = create_account(balance: 1000, accountable: Depository.new)
|
||||
create_transaction(account: account, date: 2.days.ago.to_date, amount: -500)
|
||||
create_transaction(account: account, date: 1.day.ago.to_date, amount: 100)
|
||||
create_transaction(account: account, date: Date.current, amount: 20)
|
||||
|
||||
snapshot = @family.snapshot_transactions
|
||||
|
||||
expected_income_series = [
|
||||
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
|
||||
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
|
||||
0, 0, 500, 500, 500
|
||||
]
|
||||
|
||||
assert_equal expected_income_series, snapshot[:income_series].values.map(&:value).map(&:amount)
|
||||
|
||||
expected_spending_series = [
|
||||
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
|
||||
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
|
||||
0, 0, 0, 100, 120
|
||||
]
|
||||
|
||||
assert_equal expected_spending_series, snapshot[:spending_series].values.map(&:value).map(&:amount)
|
||||
|
||||
expected_savings_rate_series = [
|
||||
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
|
||||
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
|
||||
0, 0, 1, 0.8, 0.76
|
||||
]
|
||||
|
||||
assert_equal expected_savings_rate_series, snapshot[:savings_rate_series].values.map(&:value).map { |v| v.round(2) }
|
||||
end
|
||||
|
||||
private
|
||||
|
||||
def create_account(attributes = {})
|
||||
account = @family.accounts.create! name: "Test", currency: "USD", **attributes
|
||||
account
|
||||
end
|
||||
end
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue