Migrate valuations controller to new reconciliation methods

test/models/account/overview_form_test.rb

@@ -30,6 +30,7 @@ class Account::OverviewFormTest < ActiveSupport::TestCase
     )
 
     @account.expects(:update!).with(name: "New Property Name").once
+    @account.expects(:lock_attr!).with(:name).once
     @account.expects(:sync_later).never  # Name change should not trigger sync
 
     result = form.save
@@ -84,6 +85,7 @@ class Account::OverviewFormTest < ActiveSupport::TestCase
 
     # Simulate a validation error on opening balance update
     @account.expects(:update!).with(name: "New Name").once
+    @account.expects(:lock_attr!).with(:name).once
     @account.expects(:set_or_update_opening_balance!).raises(Account::Reconcileable::InvalidBalanceError.new("Cash balance cannot exceed balance"))
     @account.expects(:sync_later).never  # Should NOT sync if any update fails
 

test/models/account/reconcileable_test.rb

@@ -6,16 +6,9 @@ class Account::ReconcileableTest < ActiveSupport::TestCase
     @family = families(:dylan_family)
   end
 
-  # Currency updates earn their own method because updating an account currency incurs
-  # side effects like recalculating balances, etc.
-  test "can update the account currency" do
-    @account.update_currency!("EUR")
-
-    assert_equal "EUR", @account.currency
-    assert_equal "EUR", @account.entries.valuations.first.currency
-  end
-
-  # If a user has an opening balance (valuation) for their manual account and has 1+ transactions, the intent of
+  # Scope: Depository Only
+  #
+  # If a user has an opening balance (valuation) for their manual *Depository* account and has 1+ transactions, the intent of
   # "updating current balance" typically means that their start balance is incorrect. We follow that user intent
   # by default and find the delta required, and update the opening balance so that the timeline reflects this current balance
   #

test/models/account_test.rb

@@ -31,4 +31,13 @@ class AccountTest < ActiveSupport::TestCase
     assert_equal "Investments", account.short_subtype_label
     assert_equal "Investments", account.long_subtype_label
   end
+
+  # Currency updates earn their own method because updating an account currency incurs
+  # side effects like recalculating balances, etc.
+  test "can update the account currency" do
+    @account.update_currency!("EUR")
+
+    assert_equal "EUR", @account.currency
+    assert_equal "EUR", @account.entries.valuations.first.currency
+  end
 end