Docker/Maybe
Docker/Maybe
1
0
Fork 0
mirror of https://github.com/maybe-finance/maybe.git synced 2025-08-09 15:35:22 +02:00
Code Issues Releases Activity Actions

Remove action_type and needs_value now that controller is injecting templates/hiding action target

Browse source
This commit is contained in:
hatz 2025-05-02 16:21:04 -05:00
parent 690daceba2
commit d9a7f19bc1
No known key found for this signature in database
2 changed files with 2 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

7
app/javascript/controllers/rule/actions_controller.js
View file

@ -25,11 +25,6 @@ export default class extends Controller {
(executor) => executor.key === e.target.value,
);
if (!actionExecutor || actionExecutor.needs_value === false) {
this.#hideActionValue();
return;
}
// Clear any existing input elements first
this.#clearFormFields();
@ -38,7 +33,7 @@ export default class extends Controller {
} else if (actionExecutor.type === "text") {
this.#buildTextInputFor();
} else {
// For any type that doesn't need a value (e.g. function)
// Hide for any type that doesn't need a value (e.g. function)
this.#hideActionValue();
}
}

4
app/views/rule/actions/_action.html.erb
View file

@ -2,8 +2,6 @@
<% action = form.object %>
<% rule = action.rule %>
<% action_type = action.executor.type %>
<% needs_value = action.executor.type == "select" || action.executor.type == "text" %>
<li data-controller="rule--actions" data-rule--actions-action-executors-value="<%= rule.action_executors.to_json %>" class="flex items-center gap-3">
<%= form.hidden_field :_destroy, value: false, data: { rule__actions_target: "destroyField" } %>
@ -13,7 +11,7 @@
<%= form.select :action_type, rule.action_executors.map { |executor| [ executor.label, executor.key ] }, {}, data: { action: "rule--actions#handleActionTypeChange" } %>
</div>
<%= tag.div class: class_names("min-w-1/2 flex items-center gap-2", "hidden" => !needs_value),
<%= tag.div class: class_names("min-w-1/2 flex items-center gap-2"),
data: { rule__actions_target: "actionValue" } do %>
<span class="font-medium uppercase text-xs" data-rule--actions-target="toSpan">to</span>
<%# Initial rendering based on rule.action_executors.first from the rule form. %>