Account namespace updates: part 6 (transactions) (#904)

* Move Transaction to Account namespace

* Fix improper routes, improve separation of concerns

* Replace account transactions list partial with view

* Remove logs

* Consolidate transaction views

* Remove unused code

* Transfer style tweaks

* Remove more unused code

* Add back totals by currency helper

app/models/account/transaction.rb

@@ -1,4 +1,4 @@
-class Transaction < ApplicationRecord
+class Account::Transaction < ApplicationRecord
   include Monetizable
 
   monetize :amount
@@ -17,22 +17,22 @@ class Transaction < ApplicationRecord
   scope :active, -> { where(excluded: false) }
   scope :inflows, -> { where("amount <= 0") }
   scope :outflows, -> { where("amount > 0") }
-  scope :by_name, ->(name) { where("transactions.name ILIKE ?", "%#{name}%") }
+  scope :by_name, ->(name) { where("account_transactions.name ILIKE ?", "%#{name}%") }
   scope :with_categories, ->(categories) { joins(:category).where(categories: { name: categories }) }
   scope :with_accounts, ->(accounts) { joins(:account).where(accounts: { name: accounts }) }
   scope :with_account_ids, ->(account_ids) { joins(:account).where(accounts: { id: account_ids }) }
   scope :with_merchants, ->(merchants) { joins(:merchant).where(merchants: { name: merchants }) }
-  scope :on_or_after_date, ->(date) { where("transactions.date >= ?", date) }
-  scope :on_or_before_date, ->(date) { where("transactions.date <= ?", date) }
+  scope :on_or_after_date, ->(date) { where("account_transactions.date >= ?", date) }
+  scope :on_or_before_date, ->(date) { where("account_transactions.date <= ?", date) }
   scope :with_converted_amount, ->(currency = Current.family.currency) {
     # Join with exchange rates to convert the amount to the given currency
     # If no rate is available, exclude the transaction from the results
     select(
-      "transactions.*",
-      "transactions.amount * COALESCE(er.rate, 1) AS converted_amount"
+      "account_transactions.*",
+      "account_transactions.amount * COALESCE(er.rate, 1) AS converted_amount"
     )
-      .joins(sanitize_sql_array([ "LEFT JOIN exchange_rates er ON transactions.date = er.date AND transactions.currency = er.base_currency AND er.converted_currency = ?", currency ]))
-      .where("er.rate IS NOT NULL OR transactions.currency = ?", currency)
+      .joins(sanitize_sql_array([ "LEFT JOIN exchange_rates er ON account_transactions.date = er.date AND account_transactions.currency = er.base_currency AND er.converted_currency = ?", currency ]))
+      .where("er.rate IS NOT NULL OR account_transactions.currency = ?", currency)
   }
 
   def inflow?

app/models/account/valuation.rb

@@ -15,14 +15,10 @@ class Account::Valuation < ApplicationRecord
     @trend ||= create_trend
   end
 
-  def first_of_series?
+  def oldest?
     account.valuations.chronological.limit(1).pluck(:date).first == self.date
   end
 
-  def last_of_series?
-    account.valuations.reverse_chronological.limit(1).pluck(:date).first == self.date
-  end
-
   def sync_account_later
     if destroyed?
       sync_start_date = previous_valuation&.date

app/models/category.rb

@@ -1,5 +1,5 @@
 class Category < ApplicationRecord
-  has_many :transactions, dependent: :nullify
+  has_many :transactions, dependent: :nullify, class_name: "Account::Transaction"
   belongs_to :family
 
   validates :name, :color, :family, presence: true

app/models/family.rb

@@ -3,7 +3,7 @@ class Family < ApplicationRecord
   has_many :tags, dependent: :destroy
   has_many :accounts, dependent: :destroy
   has_many :institutions, dependent: :destroy
-  has_many :transactions, through: :accounts
+  has_many :transactions, through: :accounts, class_name: "Account::Transaction"
   has_many :imports, through: :accounts
   has_many :categories, dependent: :destroy
   has_many :merchants, dependent: :destroy
@@ -40,9 +40,9 @@ class Family < ApplicationRecord
                   "COALESCE(SUM(amount) FILTER (WHERE amount > 0), 0) AS spending",
                   "COALESCE(SUM(-amount) FILTER (WHERE amount < 0), 0) AS income"
                 )
-                .where("transactions.date >= ?", period.date_range.begin)
-                .where("transactions.date <= ?", period.date_range.end)
-                .where("transactions.marked_as_transfer = ?", false)
+                .where("account_transactions.date >= ?", period.date_range.begin)
+                .where("account_transactions.date <= ?", period.date_range.end)
+                .where("account_transactions.marked_as_transfer = ?", false)
                 .group("id")
                 .to_a
 
@@ -60,7 +60,7 @@ class Family < ApplicationRecord
   end
 
   def snapshot_transactions
-    rolling_totals = Transaction.daily_rolling_totals(transactions, period: Period.last_30_days, currency: self.currency)
+    rolling_totals = Account::Transaction.daily_rolling_totals(transactions, period: Period.last_30_days, currency: self.currency)
 
     spending = []
     income = []

app/models/merchant.rb

@@ -1,5 +1,5 @@
 class Merchant < ApplicationRecord
-  has_many :transactions, dependent: :nullify
+  has_many :transactions, dependent: :nullify, class_name: "Account::Transaction"
   belongs_to :family
 
   validates :name, :color, :family, presence: true

app/models/tag.rb

@@ -1,7 +1,7 @@
 class Tag < ApplicationRecord
   belongs_to :family
   has_many :taggings, dependent: :destroy
-  has_many :transactions, through: :taggings, source: :taggable, source_type: "Transaction"
+  has_many :transactions, through: :taggings, source: :taggable, source_type: "Account::Transaction"
 
   validates :name, presence: true, uniqueness: { scope: :family }