Account namespace updates: part 6 (transactions) (#904)

* Move Transaction to Account namespace

* Fix improper routes, improve separation of concerns

* Replace account transactions list partial with view

* Remove logs

* Consolidate transaction views

* Remove unused code

* Transfer style tweaks

* Remove more unused code

* Add back totals by currency helper

test/controllers/transactions_controller_test.rb

@@ -3,10 +3,81 @@ require "test_helper"
 class TransactionsControllerTest < ActionDispatch::IntegrationTest
   setup do
     sign_in @user = users(:family_admin)
-    @transaction = transactions(:checking_one)
+    @transaction = account_transactions(:checking_one)
     @recent_transactions = @user.family.transactions.ordered.limit(20).to_a
   end
 
+  test "should get new" do
+    get new_transaction_url
+    assert_response :success
+  end
+
+  test "prefills account_id" do
+    get new_transaction_url(account_id: @transaction.account.id)
+    assert_response :success
+    assert_select "option[selected][value='#{@transaction.account.id}']"
+  end
+
+  test "should create transaction" do
+    account = @user.family.accounts.first
+    transaction_params = {
+      account_id: account.id,
+      amount: 100.45,
+      currency: "USD",
+      date: Date.current,
+      name: "Test transaction"
+    }
+
+    assert_difference("Account::Transaction.count") do
+      post transactions_url, params: { transaction: transaction_params }
+    end
+
+    assert_equal transaction_params[:amount].to_d, Account::Transaction.order(created_at: :desc).first.amount
+    assert_equal "New transaction created successfully", flash[:notice]
+    assert_enqueued_with(job: AccountSyncJob)
+    assert_redirected_to account_url(account)
+  end
+
+  test "expenses are positive" do
+    assert_difference("Account::Transaction.count") do
+      post transactions_url, params: {
+        transaction: {
+          nature: "expense",
+          account_id: @transaction.account_id,
+          amount: @transaction.amount,
+          currency: @transaction.currency,
+          date: @transaction.date,
+          name: @transaction.name
+        }
+      }
+    end
+
+    created_transaction = Account::Transaction.order(created_at: :desc).first
+
+    assert_redirected_to account_url(@transaction.account)
+    assert created_transaction.amount.positive?, "Amount should be positive"
+  end
+
+  test "incomes are negative" do
+    assert_difference("Account::Transaction.count") do
+      post transactions_url, params: {
+        transaction: {
+          nature: "income",
+          account_id: @transaction.account_id,
+          amount: @transaction.amount,
+          currency: @transaction.currency,
+          date: @transaction.date,
+          name: @transaction.name
+        }
+      }
+    end
+
+    created_transaction = Account::Transaction.order(created_at: :desc).first
+
+    assert_redirected_to account_url(@transaction.account)
+    assert created_transaction.amount.negative?, "Amount should be negative"
+  end
+
   test "should get paginated index with most recent transactions first" do
     get transactions_url
     assert_response :success
@@ -49,104 +120,14 @@ class TransactionsControllerTest < ActionDispatch::IntegrationTest
     assert_dom "#" + dom_id(user_oldest_transaction), count: 1
   end
 
-  test "should get new" do
-    get new_transaction_url
-    assert_response :success
-  end
-
-  test "prefills account_id if provided" do
-    get new_transaction_url(account_id: @transaction.account_id)
-    assert_response :success
-    assert_select "option[selected][value='#{@transaction.account_id}']"
-  end
-
-  test "should create transaction" do
-    account = @user.family.accounts.first
-    transaction_params = {
-      account_id: account.id,
-      amount: 100.45,
-      currency: "USD",
-      date: Date.current,
-      name: "Test transaction"
-    }
-
-    assert_difference("Transaction.count") do
-      post transactions_url, params: { transaction: transaction_params }
-    end
-
-    assert_equal transaction_params[:amount].to_d, Transaction.order(created_at: :desc).first.amount
-    assert_equal "New transaction created successfully", flash[:notice]
-    assert_enqueued_with(job: AccountSyncJob)
-    assert_redirected_to transactions_url
-  end
-
-  test "expenses are positive" do
-    assert_difference("Transaction.count") do
-      post transactions_url, params: { transaction: {
-        nature: "expense",
-        account_id: @transaction.account_id,
-        amount: @transaction.amount,
-        currency: @transaction.currency,
-        date: @transaction.date,
-        name: @transaction.name } }
-    end
-
-    assert_redirected_to transactions_url
-    assert Transaction.order(created_at: :desc).first.amount.positive?, "Amount should be positive"
-  end
-
-  test "incomes are negative" do
-    assert_difference("Transaction.count") do
-      post transactions_url, params: {
-        transaction: {
-          nature: "income",
-          account_id: @transaction.account_id,
-          amount: @transaction.amount,
-          currency: @transaction.currency,
-          date: @transaction.date,
-          name: @transaction.name
-        }
-      }
-    end
-
-    assert_redirected_to transactions_url
-    assert Transaction.order(created_at: :desc).first.amount.negative?, "Amount should be negative"
-  end
-
-  test "should show transaction" do
-    get transaction_url(@transaction)
-    assert_response :success
-  end
-
-  test "should update transaction" do
-    patch transaction_url(@transaction), params: {
-      transaction: {
-        account_id: @transaction.account_id,
-        amount: @transaction.amount,
-        currency: @transaction.currency,
-        date: @transaction.date,
-        name: @transaction.name,
-        tag_ids: [ Tag.first.id, Tag.second.id ]
-      }
-    }
-
-    assert_redirected_to transaction_url(@transaction)
-    assert_enqueued_with(job: AccountSyncJob)
-  end
-
-  test "should destroy transaction" do
-    assert_difference("Transaction.count", -1) do
-      delete transaction_url(@transaction)
-    end
-
-    assert_redirected_to transactions_url
-    assert_enqueued_with(job: AccountSyncJob)
-  end
-
   test "can destroy many transactions at once" do
     delete_count = 10
-    assert_difference("Transaction.count", -delete_count) do
-      post bulk_delete_transactions_url, params: { bulk_delete: { transaction_ids: @recent_transactions.first(delete_count).pluck(:id) } }
+    assert_difference("Account::Transaction.count", -delete_count) do
+      post bulk_delete_transactions_url, params: {
+        bulk_delete: {
+          transaction_ids: @recent_transactions.first(delete_count).pluck(:id)
+        }
+      }
     end
 
     assert_redirected_to transactions_url