Account namespace updates: part 6 (transactions) (#904)

* Move Transaction to Account namespace

* Fix improper routes, improve separation of concerns

* Replace account transactions list partial with view

* Remove logs

* Consolidate transaction views

* Remove unused code

* Transfer style tweaks

* Remove more unused code

* Add back totals by currency helper

test/models/account/transaction_test.rb

@@ -0,0 +1,55 @@
+require "test_helper"
+
+class Account::TransactionTest < ActiveSupport::TestCase
+  setup do
+    @transaction = account_transactions(:checking_one)
+    @family = families(:dylan_family)
+  end
+
+  # See: https://github.com/maybe-finance/maybe/wiki/vision#signage-of-money
+  test "negative amounts are inflows, positive amounts are outflows to an account" do
+    inflow_transaction = account_transactions(:checking_four)
+    outflow_transaction = account_transactions(:checking_five)
+
+    assert inflow_transaction.amount < 0
+    assert inflow_transaction.inflow?
+
+    assert outflow_transaction.amount >= 0
+    assert outflow_transaction.outflow?
+  end
+
+  test "triggers sync with correct start date when transaction is set to prior date" do
+    prior_date = @transaction.date - 1
+    @transaction.update! date: prior_date
+
+    @transaction.account.expects(:sync_later).with(prior_date)
+    @transaction.sync_account_later
+  end
+
+  test "triggers sync with correct start date when transaction is set to future date" do
+    prior_date = @transaction.date
+    @transaction.update! date: @transaction.date + 1
+
+    @transaction.account.expects(:sync_later).with(prior_date)
+    @transaction.sync_account_later
+  end
+
+  test "triggers sync with correct start date when transaction deleted" do
+    prior_transaction = account_transactions(:checking_two) # 12 days ago
+    current_transaction = account_transactions(:checking_one) # 5 days ago
+    current_transaction.destroy!
+
+    current_transaction.account.expects(:sync_later).with(prior_transaction.date)
+    current_transaction.sync_account_later
+  end
+
+  test "can calculate total spending for a group of transactions" do
+    assert_equal Money.new(2135), @family.transactions.expense_total("USD")
+    assert_equal Money.new(1010.85, "EUR"), @family.transactions.expense_total("EUR")
+  end
+
+  test "can calculate total income for a group of transactions" do
+    assert_equal -Money.new(2075), @family.transactions.income_total("USD")
+    assert_equal -Money.new(250, "EUR"), @family.transactions.income_total("EUR")
+  end
+end

test/models/account/transfer_test.rb

@@ -15,7 +15,7 @@ class Account::TransferTest < ActiveSupport::TestCase
 
   test "transfer must have 2 transactions" do
     invalid_transfer_1 = Account::Transfer.new transactions: [ @outflow ]
-    invalid_transfer_2 = Account::Transfer.new transactions: [ @inflow, @outflow, transactions(:savings_four) ]
+    invalid_transfer_2 = Account::Transfer.new transactions: [ @inflow, @outflow, account_transactions(:savings_four) ]
 
     assert invalid_transfer_1.invalid?
     assert invalid_transfer_2.invalid?