Merge branch 'main' of https://github.com/maybe-finance/maybe

README.md

@@ -37,6 +37,8 @@ You'll need:
 - ruby >3 (specific version is in `Gemfile`)
 - postgresql (if using stock `config/database.yml`)
 
+For convenience, the project contains configuration for a devcontainer. Open up the project in your editor that supports devcontainers and run the commands mentioned below.
+
 ```shell
 cd maybe
 bundle install
@@ -69,7 +71,7 @@ If you've got feature ideas, simply [open a new issues](https://github.com/maybe
 
 ## Repo Activity
 
-![Repo Activity](https://repobeats.axiom.co/api/embed/7866c9790deba0baf63ca1688b209130b306ea4e.svg 'Repobeats analytics image')
+![Repo Activity](https://repobeats.axiom.co/api/embed/7866c9790deba0baf63ca1688b209130b306ea4e.svg "Repobeats analytics image")
 
 ## Copyright & license
 

app/controllers/accounts_controller.rb

@@ -33,8 +33,10 @@ class AccountsController < ApplicationController
   end
 
   def account_type_class
-    params[:type].constantize
-  rescue
-    Account # Default to Account if type is not provided or invalid
+    if params[:type].present? && Account::VALID_ACCOUNT_TYPES.include?(params[:type])
+      params[:type].constantizes
+    else
+      Account # Default to Account if type is not provided or invalid
+    end
   end
 end

app/models/account.rb

@@ -2,4 +2,5 @@ class Account < ApplicationRecord
   belongs_to :family
 
   scope :depository, -> { where(type: 'Depository') }
+  VALID_ACCOUNT_TYPES = %w[Investment Depository Credit Loan Property Vehicle OtherAsset OtherLiability].freeze
 end

app/models/depository.rb

@@ -1,2 +1,2 @@
 class Depository < Account
-end
+end

config/routes.rb

@@ -6,9 +6,9 @@ Rails.application.routes.draw do
 
   resources :accounts
 
-  scope 'accounts/new' do
-    scope 'bank' do
-      get '', to: 'accounts#new_bank', as: 'new_bank'
+  scope "accounts/new" do
+    scope "bank" do
+      get "", to: "accounts#new_bank", as: "new_bank"
     end
   end