Docker/Maybe
Docker/Maybe
1
0
Fork 0
mirror of https://github.com/maybe-finance/maybe.git synced 2025-07-19 05:09:38 +02:00
Code Issues Releases Activity Actions 1

Improve holding records generation with security preloading

Browse source
This commit is contained in:
Josh Pigford 2025-02-03 11:18:27 -06:00
parent f57fa526af
commit dd1a7fa8cb
1 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
app/models/account/holding_calculator.rb
View file

@ -48,8 +48,9 @@ class Account::HoldingCalculator
def generate_holding_records(portfolio, date) def generate_holding_records(portfolio, date)
portfolio.map do |security_id, qty| portfolio.map do |security_id, qty|
security = securities_cache[security_id] security = securities_cache[security_id]
price = security.dig(:prices)&.find { |p| p.date == date } next if security.nil?
price = security.dig(:prices)&.find { |p| p.date == date }
next if price.blank? next if price.blank?
converted_price = Money.new(price.price, price.currency).exchange_to(account.currency, fallback_rate: 1).amount converted_price = Money.new(price.price, price.currency).exchange_to(account.currency, fallback_rate: 1).amount
@ -106,7 +107,10 @@ class Account::HoldingCalculator
end end
def preload_securities def preload_securities
# Get securities from trades and current holdings
securities = trades.map(&:entryable).map(&:security).uniq securities = trades.map(&:entryable).map(&:security).uniq
securities += account.holdings.where(date: Date.current).map(&:security)
securities.uniq!
securities.each do |security| securities.each do |security|
prices = Security::Price.find_prices( prices = Security::Price.find_prices(