From de9723d63a2a2df462a4f50c723c0b15f69b8640 Mon Sep 17 00:00:00 2001
From: Zach Gollwitzer <zach@maybe.co>
Date: Fri, 23 Aug 2024 10:30:08 -0400
Subject: [PATCH] Fix file upload UI opening twice (#1119)

* Fix file selector opening twice

* rename click() method

* Remove unused method

* Credit original author

Co-authored-by: Tony Yesudas <tonyvince7@gmail.com>

---------

Co-authored-by: Tony Yesudas <tonyvince7@gmail.com>
---
 app/javascript/controllers/import_upload_controller.js | 4 ----
 app/views/imports/_csv_upload.html.erb                 | 2 +-
 2 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/app/javascript/controllers/import_upload_controller.js b/app/javascript/controllers/import_upload_controller.js
index a7301c22..224b7cdb 100644
--- a/app/javascript/controllers/import_upload_controller.js
+++ b/app/javascript/controllers/import_upload_controller.js
@@ -44,10 +44,6 @@ export default class extends Controller {
     }
   }
 
-  click() {
-    this.inputTarget.click();
-  }
-
   // Private
 
   _fetchFileSize(size) {
diff --git a/app/views/imports/_csv_upload.html.erb b/app/views/imports/_csv_upload.html.erb
index b3c31f43..1da6c140 100644
--- a/app/views/imports/_csv_upload.html.erb
+++ b/app/views/imports/_csv_upload.html.erb
@@ -1,6 +1,6 @@
 <%= styled_form_with model: @import, url: upload_import_path(@import), class: "dropzone space-y-4", data: { controller: "import-upload", import_upload_accepted_types_value: ["text/csv", "application/csv", ".csv"], import_upload_extension_value: "csv", import_upload_unacceptable_type_label_value: t(".allowed_filetypes") }, method: :patch, multipart: true do |form| %>
   <div class="flex items-center justify-center w-full">
-    <label for="import_raw_file_str" class="raw-file-drop-box flex flex-col items-center justify-center w-full h-64 border-2 border-gray-300 border-dashed rounded-lg cursor-pointer bg-gray-50" data-action="dragover->import-upload#dragover dragleave->import-upload#dragleave drop->import-upload#drop click->import-upload#click">
+    <label for="import_raw_file_str" class="raw-file-drop-box flex flex-col items-center justify-center w-full h-64 border-2 border-gray-300 border-dashed rounded-lg cursor-pointer bg-gray-50" data-action="dragover->import-upload#dragover dragleave->import-upload#dragleave drop->import-upload#drop">
       <div class="flex flex-col items-center justify-center pt-5 pb-6">
         <%= lucide_icon "plus", class: "w-5 h-5 text-gray-500" %>
         <%= form.file_field :raw_file_str, class: "hidden", direct_upload: false, accept: "text/csv,.csv,application/csv", data: { import_upload_target: "input", action: "change->import-upload#addFile" } %>