Account:: namespace simplifications and cleanup (#2110)

* Flatten Holding model

* Flatten balance model

* Entries domain renames

* Fix valuations reference

* Fix trades stream

* Fix brakeman warnings

* Fix tests

* Replace existing entryable type references in DB

app/views/valuations/_form.html.erb

@@ -0,0 +1,17 @@
+<%# locals: (entry:) %>
+
+<%= styled_form_with model: entry, url: valuations_path, class: "space-y-4" do |form| %>
+  <%= form.hidden_field :account_id %>
+
+  <% if entry.errors.any? %>
+    <%= render "shared/form_errors", model: entry %>
+  <% end %>
+
+  <div class="space-y-3">
+    <%= form.hidden_field :name, value: "Balance update" %>
+    <%= form.date_field :date, label: true, required: true, value: Date.current, min: Entry.min_supported_date, max: Date.current %>
+    <%= form.money_field :amount, label: t(".amount"), required: true %>
+  </div>
+
+  <%= form.submit t(".submit") %>
+<% end %>

app/views/valuations/_header.html.erb

@@ -0,0 +1,19 @@
+<%# locals: (entry:) %>
+
+<%= tag.header class: "mb-4 space-y-1", id: dom_id(entry, :header) do %>
+  <span class="text-secondary text-sm">
+    <%= t(".balance") %>
+  </span>
+
+  <div class="flex items-center gap-4">
+    <h3 class="font-medium">
+      <span class="text-2xl">
+        <%= format_money entry.amount_money %>
+      </span>
+    </h3>
+  </div>
+
+  <span class="text-sm text-secondary">
+    <%= I18n.l(entry.date, format: :long) %>
+  </span>
+<% end %>

app/views/valuations/_valuation.html.erb

@@ -0,0 +1,43 @@
+<%# locals: (entry:, balance_trend: nil, **) %>
+
+<% valuation = entry.entryable %>
+
+<% color = balance_trend&.trend&.color || "#D444F1" %>
+<% icon = balance_trend&.trend&.icon || "plus" %>
+
+<%= turbo_frame_tag dom_id(entry) do %>
+  <%= turbo_frame_tag dom_id(valuation) do %>
+    <div class="p-4 grid grid-cols-12 items-center text-primary text-sm font-medium">
+      <div class="col-span-8 flex items-center gap-4">
+        <%= check_box_tag dom_id(entry, "selection"),
+                        class: "checkbox checkbox--light",
+                        data: { id: entry.id, "bulk-select-target": "row", action: "bulk-select#toggleRowSelection" } %>
+
+        <div class="flex items-center gap-3">
+          <%= tag.div class: "w-6 h-6 rounded-full p-1.5 flex items-center justify-center", style: mixed_hex_styles(color) do %>
+            <%= lucide_icon icon, class: "w-4 h-4 shrink-0" %>
+          <% end %>
+
+          <div class="truncate text-primary">
+            <%= link_to entry.display_name,
+                        entry_path(entry),
+                        data: { turbo_frame: "drawer", turbo_prefetch: false },
+                        class: "hover:underline hover:text-gray-800" %>
+          </div>
+        </div>
+      </div>
+
+      <div class="col-span-2 justify-self-end font-medium text-sm">
+        <% if balance_trend&.trend %>
+          <%= tag.span format_money(balance_trend.trend.value), style: "color: #{balance_trend.trend.color}" %>
+        <% else %>
+          <%= tag.span "--", class: "text-gray-400" %>
+        <% end %>
+      </div>
+
+      <div class="col-span-2 justify-self-end">
+        <%= tag.p format_money(entry.amount_money), class: "font-medium text-sm text-primary" %>
+      </div>
+    </div>
+  <% end %>
+<% end %>

app/views/valuations/index.html.erb

@@ -0,0 +1,35 @@
+<%= turbo_frame_tag dom_id(@account, "valuations") do %>
+  <div class="bg-container space-y-4 p-5 shadow-border-xs rounded-xl">
+    <div class="flex items-center justify-between">
+      <%= tag.h2 t(".valuations"), class: "font-medium text-lg" %>
+      <%= link_to new_valuation_path(@account),
+                  data:  { turbo_frame: dom_id(@account.entries.valuations.new) },
+                  class: "flex gap-1 font-medium items-center bg-gray-50 text-primary p-2 rounded-lg" do %>
+        <%= lucide_icon("plus", class: "w-5 h-5 text-primary") %>
+        <%= tag.span t(".new_entry"), class: "text-sm" %>
+      <% end %>
+    </div>
+
+    <div class="rounded-xl bg-container-inset p-1">
+      <div class="grid grid-cols-10 items-center uppercase text-xs font-medium text-secondary px-4 py-2">
+        <%= tag.p t(".date"), class: "col-span-5" %>
+        <%= tag.p t(".value"), class: "col-span-2 justify-self-end" %>
+        <%= tag.p t(".change"), class: "col-span-2 justify-self-end" %>
+        <%= tag.div class: "col-span-1" %>
+      </div>
+
+      <div class="rounded-lg bg-container shadow-border-xs">
+        <%= turbo_frame_tag dom_id(@account.entries.valuations.new) %>
+
+        <% if @entries.any? %>
+          <%= render partial: "valuations/valuation",
+                     collection:      @entries,
+                     as:              :entry,
+                     spacer_template: "entries/ruler" %>
+        <% else %>
+          <p class="text-secondary text-sm p-4"><%= t(".no_valuations") %></p>
+        <% end %>
+      </div>
+    </div>
+  </div>
+<% end %>

app/views/valuations/new.html.erb

@@ -0,0 +1,3 @@
+<%= modal_form_wrapper title: t(".title") do %>
+  <%= render "form", entry: @entry %>
+<% end %>

app/views/valuations/show.html.erb

@@ -0,0 +1,67 @@
+<% entry, account = @entry, @entry.account %>
+
+<%= drawer(reload_on_close: true) do %>
+  <%= render "valuations/header", entry: %>
+
+  <div class="space-y-2">
+    <!-- Overview Section -->
+    <%= disclosure t(".overview") do %>
+      <div class="pb-4">
+        <%= styled_form_with model: entry,
+              url: entry_path(entry),
+              class: "space-y-2",
+              data: { controller: "auto-submit-form" } do |f| %>
+          <%= f.text_field :name,
+                label: t(".name_label"),
+                placeholder: t(".name_placeholder"),
+                "data-auto-submit-form-target": "auto" %>
+
+          <%= f.date_field :date,
+                label: t(".date_label"),
+                max: Date.current,
+                "data-auto-submit-form-target": "auto" %>
+
+          <%= f.money_field :amount,
+                label: t(".amount"),
+                auto_submit: true,
+                disable_currency: true %>
+        <% end %>
+      </div>
+    <% end %>
+
+    <!-- Details Section -->
+    <%= disclosure t(".details") do %>
+      <div class="pb-4">
+        <%= styled_form_with model: entry,
+              url: entry_path(entry),
+              class: "space-y-2",
+              data: { controller: "auto-submit-form" } do |f| %>
+          <%= f.text_area :notes,
+                label: t(".note_label"),
+                placeholder: t(".note_placeholder"),
+                rows: 5,
+                "data-auto-submit-form-target": "auto" %>
+        <% end %>
+      </div>
+    <% end %>
+
+    <!-- Settings Section -->
+    <%= disclosure t(".settings") do %>
+      <div class="pb-4">
+        <!-- Delete Valuation Form -->
+        <div class="flex items-center justify-between gap-2 p-3">
+          <div class="text-sm space-y-1">
+            <h4 class="text-primary"><%= t(".delete_title") %></h4>
+            <p class="text-secondary"><%= t(".delete_subtitle") %></p>
+          </div>
+
+          <%= button_to t(".delete"),
+                entry_path(entry),
+                method: :delete,
+                class: "rounded-lg px-3 py-2 text-red-500 text-sm font-medium border border-secondary",
+                data: { turbo_confirm: true, turbo_frame: "_top" } %>
+        </div>
+      </div>
+    <% end %>
+  </div>
+<% end %>