Account:: namespace simplifications and cleanup (#2110)

* Flatten Holding model

* Flatten balance model

* Entries domain renames

* Fix valuations reference

* Fix trades stream

* Fix brakeman warnings

* Fix tests

* Replace existing entryable type references in DB

test/interfaces/accountable_resource_interface_test.rb

@@ -60,7 +60,7 @@ module AccountableResourceInterfaceTest
   end
 
   test "updates account balance by creating new valuation if balance has changed" do
-    assert_difference [ "Account::Entry.count", "Account::Valuation.count" ], 1 do
+    assert_difference [ "Entry.count", "Valuation.count" ], 1 do
       patch account_url(@account), params: {
         account: {
           balance: 12000
@@ -74,9 +74,9 @@ module AccountableResourceInterfaceTest
   end
 
   test "updates account balance by editing existing valuation for today" do
-    @account.entries.create! date: Date.current, amount: 6000, currency: "USD", name: "Balance update", entryable: Account::Valuation.new
+    @account.entries.create! date: Date.current, amount: 6000, currency: "USD", name: "Balance update", entryable: Valuation.new
 
-    assert_no_difference [ "Account::Entry.count", "Account::Valuation.count" ] do
+    assert_no_difference [ "Entry.count", "Valuation.count" ] do
       patch account_url(@account), params: {
         account: {
           balance: 12000

test/interfaces/entryable_resource_interface_test.rb

@@ -9,13 +9,13 @@ module EntryableResourceInterfaceTest
   end
 
   test "shows editing drawer" do
-    get account_entry_url(@entry)
+    get entry_url(@entry)
     assert_response :success
   end
 
   test "destroys entry" do
-    assert_difference "Account::Entry.count", -1 do
-      delete account_entry_url(@entry)
+    assert_difference "Entry.count", -1 do
+      delete entry_url(@entry)
     end
 
     assert_enqueued_with job: SyncJob