From e795c4c9a3b491c6dd7307e4dbe2007eadbc184e Mon Sep 17 00:00:00 2001 From: Zach Gollwitzer Date: Wed, 23 Jul 2025 15:13:12 -0400 Subject: [PATCH] Lint fixes --- .../UI/account/balance_reconciliation.rb | 4 +- app/models/balance/materializer.rb | 2 +- test/models/balance/materializer_test.rb | 40 +++++++++---------- 3 files changed, 23 insertions(+), 23 deletions(-) diff --git a/app/components/UI/account/balance_reconciliation.rb b/app/components/UI/account/balance_reconciliation.rb index 0833e323..980fad60 100644 --- a/app/components/UI/account/balance_reconciliation.rb +++ b/app/components/UI/account/balance_reconciliation.rb @@ -65,10 +65,10 @@ class UI::Account::BalanceReconciliation < ApplicationComponent # Change in brokerage cash (includes deposits, withdrawals, and cash from trades) items << { label: "Change in brokerage cash", value: net_cash_flow, tooltip: "Net change in cash from deposits, withdrawals, and trades", style: :flow } - + # Change in holdings from trading activity items << { label: "Change in holdings (buys/sells)", value: net_non_cash_flow, tooltip: "Impact on holdings from buying and selling securities", style: :flow } - + # Market price changes items << { label: "Change in holdings (market price activity)", value: balance.net_market_flows_money, tooltip: "Change in holdings value from market price movements", style: :flow } diff --git a/app/models/balance/materializer.rb b/app/models/balance/materializer.rb index d972559e..17a950f7 100644 --- a/app/models/balance/materializer.rb +++ b/app/models/balance/materializer.rb @@ -50,7 +50,7 @@ class Balance::Materializer @balances.map { |b| b.attributes .slice("date", "balance", "cash_balance", "currency", "start_cash_balance", "start_non_cash_balance", - "cash_inflows", "cash_outflows", + "cash_inflows", "cash_outflows", "non_cash_inflows", "non_cash_outflows", "net_market_flows", "cash_adjustments", "non_cash_adjustments", diff --git a/test/models/balance/materializer_test.rb b/test/models/balance/materializer_test.rb index 34edfc42..0715ed63 100644 --- a/test/models/balance/materializer_test.rb +++ b/test/models/balance/materializer_test.rb @@ -65,7 +65,7 @@ class Balance::MaterializerTest < ActiveSupport::TestCase test "purges stale balances and holdings" do # Balance before start date is stale @account.expects(:start_date).returns(2.days.ago.to_date).twice - + stale_balance = Balance.new( date: 3.days.ago.to_date, balance: 10000, @@ -147,24 +147,24 @@ class Balance::MaterializerTest < ActiveSupport::TestCase private - def assert_balance_fields_persisted(expected_balances) - expected_balances.each do |expected| - persisted = @account.balances.find_by(date: expected.date) - assert_not_nil persisted, "Balance for #{expected.date} should be persisted" - - # Check all balance component fields - assert_equal expected.balance, persisted.balance - assert_equal expected.cash_balance, persisted.cash_balance - assert_equal expected.start_cash_balance, persisted.start_cash_balance - assert_equal expected.start_non_cash_balance, persisted.start_non_cash_balance - assert_equal expected.cash_inflows, persisted.cash_inflows - assert_equal expected.cash_outflows, persisted.cash_outflows - assert_equal expected.non_cash_inflows, persisted.non_cash_inflows - assert_equal expected.non_cash_outflows, persisted.non_cash_outflows - assert_equal expected.net_market_flows, persisted.net_market_flows - assert_equal expected.cash_adjustments, persisted.cash_adjustments - assert_equal expected.non_cash_adjustments, persisted.non_cash_adjustments - assert_equal expected.flows_factor, persisted.flows_factor + def assert_balance_fields_persisted(expected_balances) + expected_balances.each do |expected| + persisted = @account.balances.find_by(date: expected.date) + assert_not_nil persisted, "Balance for #{expected.date} should be persisted" + + # Check all balance component fields + assert_equal expected.balance, persisted.balance + assert_equal expected.cash_balance, persisted.cash_balance + assert_equal expected.start_cash_balance, persisted.start_cash_balance + assert_equal expected.start_non_cash_balance, persisted.start_non_cash_balance + assert_equal expected.cash_inflows, persisted.cash_inflows + assert_equal expected.cash_outflows, persisted.cash_outflows + assert_equal expected.non_cash_inflows, persisted.non_cash_inflows + assert_equal expected.non_cash_outflows, persisted.non_cash_outflows + assert_equal expected.net_market_flows, persisted.net_market_flows + assert_equal expected.cash_adjustments, persisted.cash_adjustments + assert_equal expected.non_cash_adjustments, persisted.non_cash_adjustments + assert_equal expected.flows_factor, persisted.flows_factor + end end - end end