mirror of
https://github.com/maybe-finance/maybe.git
synced 2025-07-19 05:09:38 +02:00
Refactor sparkline error handling and improve series pre-loading
- Added pre-loading of series in AccountableSparklinesController and AccountsController to catch errors before rendering. - Updated the accounts view to use the pre-loaded sparkline series variable. - Adjusted the test for graceful handling of errors in the sparkline series method. This enhances the robustness of the sparkline feature and improves error visibility in the UI.
This commit is contained in:
parent
6f67827f14
commit
e7f1506728
5 changed files with 33 additions and 9 deletions
|
@ -2,6 +2,7 @@ class AccountableSparklinesController < ApplicationController
|
|||
def show
|
||||
@accountable = Accountable.from_type(params[:accountable_type]&.classify)
|
||||
|
||||
# Pre-load the series to catch any errors before rendering
|
||||
@series = Rails.cache.fetch(cache_key) do
|
||||
account_ids = family.accounts.active.where(accountable_type: @accountable.name).pluck(:id)
|
||||
|
||||
|
|
|
@ -23,6 +23,8 @@ class AccountsController < ApplicationController
|
|||
end
|
||||
|
||||
def sparkline
|
||||
# Pre-load the sparkline series to catch any errors before rendering
|
||||
@sparkline_series = @account.sparkline_series
|
||||
render layout: false
|
||||
rescue => e
|
||||
Rails.logger.error "Sparkline error for account #{@account.id}: #{e.message}"
|
||||
|
|
|
@ -2,11 +2,11 @@
|
|||
<%= turbo_frame_tag dom_id(@account, :sparkline) do %>
|
||||
<div class="flex items-center justify-end gap-1">
|
||||
<div class="w-8 h-5">
|
||||
<%= render "shared/sparkline", id: dom_id(@account, :sparkline_chart), series: @account.sparkline_series %>
|
||||
<%= render "shared/sparkline", id: dom_id(@account, :sparkline_chart), series: @sparkline_series %>
|
||||
</div>
|
||||
|
||||
<%= tag.p @account.sparkline_series.trend.percent_formatted,
|
||||
style: "color: #{@account.sparkline_series.trend.color}",
|
||||
<%= tag.p @sparkline_series.trend.percent_formatted,
|
||||
style: "color: #{@sparkline_series.trend.color}",
|
||||
class: "font-mono text-right text-xs font-medium text-primary" %>
|
||||
</div>
|
||||
<% end %>
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue