Add Property Details View (#1116)

* Add backend for property account details

* Rubocop updates

* Add property form with details

* Revert "Rubocop updates"

This reverts commit 05b0b8f3a4.

* Bump brakeman to latest version

* Add overview section to property view

* Lint fixes

config/brakeman.ignore

@@ -22,8 +22,42 @@
         22
       ],
       "note": ""
+    },
+    {
+      "warning_type": "Dynamic Render Path",
+      "warning_code": 15,
+      "fingerprint": "b7a59d6dd91f4d30873b271659636c7975e25b47f436b4f03900a08809af2e92",
+      "check_name": "Render",
+      "message": "Render path contains parameter value",
+      "file": "app/views/accounts/show.html.erb",
+      "line": 105,
+      "link": "https://brakemanscanner.org/docs/warning_types/dynamic_render_path/",
+      "code": "render(action => selected_account_tab(Current.family.accounts.find(params[:id]))[:partial_path], { :account => Current.family.accounts.find(params[:id]) })",
+      "render_path": [
+        {
+          "type": "controller",
+          "class": "AccountsController",
+          "method": "show",
+          "line": 38,
+          "file": "app/controllers/accounts_controller.rb",
+          "rendered": {
+            "name": "accounts/show",
+            "file": "app/views/accounts/show.html.erb"
+          }
+        }
+      ],
+      "location": {
+        "type": "template",
+        "template": "accounts/show"
+      },
+      "user_input": "params[:id]",
+      "confidence": "Weak",
+      "cwe_id": [
+        22
+      ],
+      "note": ""
     }
   ],
-  "updated": "2024-08-16 10:19:50 -0400",
-  "brakeman_version": "6.1.2"
+  "updated": "2024-08-23 08:29:05 -0400",
+  "brakeman_version": "6.2.1"
 }

config/i18n-tasks.yml

@@ -29,3 +29,4 @@ ignore_unused:
   - 'helpers.submit.*' # i18n-tasks does not detect used at forms
   - 'helpers.label.*' # i18n-tasks does not detect used at forms
   - 'accounts.show.sync_message_*' # messages generated in the sync ActiveJob
+  - 'address.attributes.*'

config/locales/models/address/en.yml

@@ -0,0 +1,15 @@
+---
+en:
+  address:
+    attributes:
+      country: Country
+      line1: Address Line 1
+      line2: Address Line 2
+      locality: Locality
+      postal_code: Postal Code
+      region: Region
+    format: |-
+      %{line1}
+      %{line2}
+      %{locality}, %{region} %{postal_code}
+      %{country}

config/locales/views/accounts/en.yml

@@ -1,20 +1,42 @@
 ---
 en:
   accounts:
+    accountables:
+      property:
+        area_unit: Area unit
+        area_value: Area value (optional)
+        city: City
+        country: Country
+        line1: Address line 1
+        line2: Address line 2 (optional)
+        overview:
+          living_area: Living Area
+          market_value: Market Value
+          purchase_price: Purchase Price
+          trend: Trend
+          unknown: Unknown
+          year_built: Year Built
+        postal_code: Postal code (optional)
+        state: State
+        year_built: Year built (optional)
     create:
       success: New account created successfully
     destroy:
       success: Account deleted successfully
     edit:
-      balance: Balance
       edit: Edit %{account}
-      institution: Financial institution
-      name: Name
-      ungrouped: "(none)"
     empty:
       empty_message: Add an account either via connection, importing or entering manually.
       new_account: New account
       no_accounts: No accounts yet
+    form:
+      balance: Current balance
+      institution: Financial institution
+      name_label: Account name
+      name_placeholder: Example account name
+      start_balance: Start balance (optional)
+      start_date: Start date (optional)
+      ungrouped: "(none)"
     header:
       accounts: Accounts
       manage: Manage accounts
@@ -36,17 +58,8 @@ en:
     institutionless_accounts:
       other_accounts: Other accounts
     new:
-      balance: Current balance
-      institution: Financial institution
-      name:
-        label: Account name
-        placeholder: Example account name
-      optional_start_balance_message: Add a start balance for this account
       select_accountable_type: What would you like to add?
-      start_balance: Start balance (optional)
-      start_date: Start date (optional)
       title: Add an account
-      ungrouped: "(none)"
     show:
       cash: Cash
       confirm_accept: Delete "%{name}"
@@ -60,6 +73,7 @@ en:
       holdings: Holdings
       import: Import transactions
       no_change: No change
+      overview: Overview
       sync_message_missing_rates: Since exchange rates haven't been synced, balance
         graphs may not reflect accurate values.
       sync_message_unknown_error: An error has occurred during the sync.

config/locales/views/properties/en.yml

@@ -0,0 +1,7 @@
+---
+en:
+  properties:
+    create:
+      success: Property created successfully
+    update:
+      success: Property updated successfully

config/routes.rb

@@ -89,6 +89,8 @@ Rails.application.routes.draw do
     end
   end
 
+  resources :properties, only: %i[ create update ]
+
   resources :transactions, only: %i[ index new create ] do
     collection do
       post "bulk_delete"