From ed55ef624bcc60de58469b587df6911c5fdcd60b Mon Sep 17 00:00:00 2001
From: Josh Pigford <josh@joshpigford.com>
Date: Tue, 11 Mar 2025 13:00:34 -0500
Subject: [PATCH] Update billing settings view and locales

---
 app/views/settings/billings/show.html.erb | 7 +++----
 config/locales/views/settings/en.yml      | 2 +-
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/app/views/settings/billings/show.html.erb b/app/views/settings/billings/show.html.erb
index ddf53db0..cd284f83 100644
--- a/app/views/settings/billings/show.html.erb
+++ b/app/views/settings/billings/show.html.erb
@@ -11,7 +11,6 @@
         <div class="text-sm space-y-1">
           <% if @user.family.subscribed? || subscription_pending? %>
             <p class="text-primary">You are currently subscribed to <span class="font-medium">Maybe+</span></p>
-            <p class="text-secondary">Manage your billing settings here.</p>
           <% else %>
             <p class="text-primary">You are currently <span class="font-medium">not subscribed</span></p>
             <p class="text-secondary">Once you subscribe to Maybe+, you'll see your billing settings here.</p>
@@ -20,12 +19,12 @@
       </div>
 
       <% if @user.family.subscribed? || subscription_pending? %>
-        <%= link_to subscription_path, class: "btn btn--secondary flex items-center gap-1" do %>
+        <%= link_to subscription_path, class: "btn btn--secondary flex items-center gap-1", target: "_blank", rel: "noopener" do %>
           <span>Manage</span>
           <%= lucide_icon "external-link", class: "w-5 h-5 shrink-0 text-secondary" %>
         <% end %>
       <% else %>
-        <%= link_to new_subscription_path, class: "btn btn--secondary flex items-center gap-1" do %>
+        <%= link_to new_subscription_path, class: "btn btn--secondary flex items-center gap-1", target: "_blank", rel: "noopener" do %>
           <span>Subscribe</span>
           <%= lucide_icon "external-link", class: "w-5 h-5 shrink-0 text-secondary" %>
         <% end %>
@@ -34,7 +33,7 @@
 
     <div class="flex items-center gap-2">
       <%= image_tag "stripe-logo.svg", class: "w-5 h-5 shrink-0" %>
-      <p class="text-secondary text-sm">Managed via Stripe</p>
+      <p class="text-secondary text-sm">Billing via Stripe</p>
     </div>
   </div>
 <% end %>
diff --git a/config/locales/views/settings/en.yml b/config/locales/views/settings/en.yml
index 8bc0dbf0..35c10f9b 100644
--- a/config/locales/views/settings/en.yml
+++ b/config/locales/views/settings/en.yml
@@ -4,7 +4,7 @@ en:
     billings:
       show:
         page_title: Billing
-        subscription_subtitle: Manage your subscription and billing details
+        subscription_subtitle: Update your subscription and billing details
         subscription_title: Manage subscription
     preferences:
       data_enrichment_settings: