Docker/Maybe
Docker/Maybe
1
0
Fork 0
mirror of https://github.com/maybe-finance/maybe.git synced 2025-07-24 23:59:40 +02:00
Code Issues Releases Activity Actions 1

Fix parent category sums in budget (#1894)
Some checks are pending
Publish Docker image / ci (push) Waiting to run
Details
Publish Docker image / Build docker image (push) Blocked by required conditions
Details

Browse source
This commit is contained in:
Zach Gollwitzer 2025-02-24 12:51:13 -05:00 • committed by GitHub
parent 0dea36ec7d
commit f5ff5332d5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 104 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

20
app/models/income_statement.rb
View file

@ -66,21 +66,25 @@ class IncomeStatement
totals = totals_query(transactions_scope: family.transactions.active.in_period(period)).select { |t| t.classification == classification }
classification_total = totals.sum(&:total)
category_totals = totals.map do |ct|
# If parent category is nil, it's a top-level category. This means we need to
# sum itself + SUM(children) to get the overall category total
children_totals = if ct.parent_category_id.nil? && ct.category_id.present?
totals.select { |t| t.parent_category_id == ct.category_id }.sum(&:total)
else
uncategorized_category = family.categories.uncategorized
category_totals = [ *categories, uncategorized_category ].map do |category|
subcategory = categories.find { |c| c.id == category.parent_id }
parent_category_total = totals.select { |t| t.category_id == category.id }&.sum(&:total) || 0
children_totals = if category == uncategorized_category
0
else
totals.select { |t| t.parent_category_id == category.id }&.sum(&:total) || 0
end
category_total = ct.total + children_totals
category_total = parent_category_total + children_totals
weight = (category_total.zero? ? 0 : category_total.to_f / classification_total) * 100
CategoryTotal.new(
category: categories.find { |c| c.id == ct.category_id } || family.categories.uncategorized,
category: category,
total: category_total,
currency: family.currency,
weight: weight,