Data provider simplification, tests, and documentation (#1997)

* Ignore env.test from source control

* Simplification of providers interface

* Synth tests

* Update money to use new find rates method

* Remove unused issues code

* Additional issue feature removals

* Update price data fetching and tests

* Update documentation for providers

* Security test fixes

* Fix self host test

* Update synth usage data access

* Remove AI pr schema changes

config/brakeman.ignore

@@ -1,28 +1,5 @@
 {
   "ignored_warnings": [
-    {
-      "warning_type": "Dynamic Render Path",
-      "warning_code": 15,
-      "fingerprint": "03a2010b605b8bdb7d4e1566720904d69ef2fbf8e7bc35735b84e161b475215e",
-      "check_name": "Render",
-      "message": "Render path contains parameter value",
-      "file": "app/controllers/issues_controller.rb",
-      "line": 5,
-      "link": "https://brakemanscanner.org/docs/warning_types/dynamic_render_path/",
-      "code": "render(template => \"#{Current.family.issues.find(params[:id]).class.name.underscore.pluralize}/show\", { :layout => \"issues\" })",
-      "render_path": null,
-      "location": {
-        "type": "method",
-        "class": "IssuesController",
-        "method": "show"
-      },
-      "user_input": "params[:id]",
-      "confidence": "Weak",
-      "cwe_id": [
-        22
-      ],
-      "note": ""
-    },
     {
       "warning_type": "Mass Assignment",
       "warning_code": 105,
@@ -30,7 +7,7 @@
       "check_name": "PermitAttributes",
       "message": "Potentially dangerous key allowed for mass assignment",
       "file": "app/controllers/concerns/entryable_resource.rb",
-      "line": 122,
+      "line": 124,
       "link": "https://brakemanscanner.org/docs/warning_types/mass_assignment/",
       "code": "params.require(:account_entry).permit(:account_id, :name, :enriched_name, :date, :amount, :currency, :excluded, :notes, :nature, :entryable_attributes => self.class.permitted_entryable_attributes)",
       "render_path": null,
@@ -53,7 +30,7 @@
       "check_name": "PermitAttributes",
       "message": "Potentially dangerous key allowed for mass assignment",
       "file": "app/controllers/invitations_controller.rb",
-      "line": 40,
+      "line": 58,
       "link": "https://brakemanscanner.org/docs/warning_types/mass_assignment/",
       "code": "params.require(:invitation).permit(:email, :role)",
       "render_path": null,
@@ -76,7 +53,7 @@
       "check_name": "CrossSiteScripting",
       "message": "Unescaped model attribute",
       "file": "app/views/pages/changelog.html.erb",
-      "line": 22,
+      "line": 18,
       "link": "https://brakemanscanner.org/docs/warning_types/cross_site_scripting",
       "code": "Provider::Github.new.fetch_latest_release_notes[:body]",
       "render_path": [
@@ -84,7 +61,7 @@
           "type": "controller",
           "class": "PagesController",
           "method": "changelog",
-          "line": 35,
+          "line": 15,
           "file": "app/controllers/pages_controller.rb",
           "rendered": {
             "name": "pages/changelog",
@@ -134,7 +111,7 @@
       "check_name": "Render",
       "message": "Render path contains parameter value",
       "file": "app/views/import/configurations/show.html.erb",
-      "line": 15,
+      "line": 34,
       "link": "https://brakemanscanner.org/docs/warning_types/dynamic_render_path/",
       "code": "render(partial => permitted_import_configuration_path(Current.family.imports.find(params[:import_id])), { :locals => ({ :import => Current.family.imports.find(params[:import_id]) }) })",
       "render_path": [

config/locales/models/issue/en.yml

@@ -1,8 +0,0 @@
----
-en:
-  activerecord:
-    models:
-      issue/exchange_rate_provider_missing: Exchange rate provider missing
-      issue/exchange_rates_missing: Exchange rates missing
-      issue/missing_prices: Missing prices
-      issue/unknown: Unknown issue occurred

config/locales/views/accounts/en.yml

@@ -2,7 +2,6 @@
 en:
   accounts:
     account:
-      has_issues: Issue detected.
       troubleshoot: Troubleshoot
     chart:
       no_change: no change

config/routes.rb

@@ -154,12 +154,6 @@ Rails.application.routes.draw do
 
   resources :invite_codes, only: %i[index create]
 
-  resources :issues, only: :show
-
-  namespace :issue do
-    resources :exchange_rate_provider_missings, only: :update
-  end
-
   resources :invitations, only: [ :new, :create, :destroy ] do
     get :accept, on: :member
   end