Add loan and credit card views (#1268)

* Add loan and credit card views

* Lint fix

* Clean up overview card markup

* Lint fix

* Test fix

app/controllers/accounts_controller.rb

@@ -41,14 +41,11 @@ class AccountsController < ApplicationController
   end
 
   def edit
+    @account.accountable.build_address if @account.accountable.is_a?(Property) && @account.accountable.address.blank?
   end
 
   def update
-    Account.transaction do
-      @account.update! account_params.except(:accountable_type, :balance)
-      @account.update_balance!(account_params[:balance]) if account_params[:balance]
-    end
-    @account.sync_later
+    @account.update_with_sync!(account_params)
     redirect_back_or_to account_path(@account), notice: t(".success")
   end
 

app/controllers/credit_cards_controller.rb

@@ -0,0 +1,41 @@
+class CreditCardsController < ApplicationController
+  before_action :set_account, only: :update
+
+  def create
+    account = Current.family
+                     .accounts
+                     .create_with_optional_start_balance! \
+                       attributes: account_params.except(:start_date, :start_balance),
+                       start_date: account_params[:start_date],
+                       start_balance: account_params[:start_balance]
+
+    account.sync_later
+    redirect_to account, notice: t(".success")
+  end
+
+  def update
+    @account.update_with_sync!(account_params)
+    redirect_to @account, notice: t(".success")
+  end
+
+  private
+
+    def set_account
+      @account = Current.family.accounts.find(params[:id])
+    end
+
+    def account_params
+      params.require(:account)
+        .permit(
+          :name, :balance, :start_date, :start_balance, :currency, :accountable_type,
+          accountable_attributes: [
+            :id,
+            :available_credit,
+            :minimum_payment,
+            :apr,
+            :annual_fee,
+            :expiration_date
+          ]
+        )
+    end
+end

app/controllers/loans_controller.rb

@@ -0,0 +1,39 @@
+class LoansController < ApplicationController
+  before_action :set_account, only: :update
+
+  def create
+    account = Current.family
+                     .accounts
+                     .create_with_optional_start_balance! \
+                       attributes: account_params.except(:start_date, :start_balance),
+                       start_date: account_params[:start_date],
+                       start_balance: account_params[:start_balance]
+
+    account.sync_later
+    redirect_to account, notice: t(".success")
+  end
+
+  def update
+    @account.update_with_sync!(account_params)
+    redirect_to @account, notice: t(".success")
+  end
+
+  private
+
+    def set_account
+      @account = Current.family.accounts.find(params[:id])
+    end
+
+    def account_params
+      params.require(:account)
+        .permit(
+          :name, :balance, :start_date, :start_balance, :currency, :accountable_type,
+          accountable_attributes: [
+            :id,
+            :rate_type,
+            :interest_rate,
+            :term_months
+          ]
+        )
+    end
+end

app/controllers/properties_controller.rb

@@ -14,8 +14,7 @@ class PropertiesController < ApplicationController
   end
 
   def update
-    @account.update!(account_params)
-    @account.sync_later
+    @account.update_with_sync!(account_params)
     redirect_to @account, notice: t(".success")
   end
 

app/controllers/vehicles_controller.rb

@@ -14,8 +14,7 @@ class VehiclesController < ApplicationController
   end
 
   def update
-    @account.update!(account_params)
-    @account.sync_later
+    @account.update_with_sync!(account_params)
     redirect_to @account, notice: t(".success")
   end