mirror of
https://github.com/maybe-finance/maybe.git
synced 2025-07-23 07:09:39 +02:00
An overhaul and cleanup of the transactions feature including: - Simplification of transactions search and filtering - Consolidation of account sync logic after transaction change - Split sidebar modal and modal into "drawer" and "modal" concepts - Refactor of transaction partials and folder organization - Cleanup turbo frames and streams for transaction updates, including new Transactions::RowsController for inline updates - Refactored and added several integration and systems tests
141 lines
4.2 KiB
Ruby
141 lines
4.2 KiB
Ruby
require "test_helper"
|
|
|
|
class TransactionsControllerTest < ActionDispatch::IntegrationTest
|
|
setup do
|
|
sign_in @user = users(:family_admin)
|
|
@transaction = transactions(:checking_one)
|
|
@recent_transactions = @user.family.transactions.ordered.limit(20).to_a
|
|
end
|
|
|
|
test "should get paginated index with most recent transactions first" do
|
|
get transactions_url
|
|
assert_response :success
|
|
|
|
@recent_transactions.first(10).each do |transaction|
|
|
assert_dom "#" + dom_id(transaction), count: 1
|
|
end
|
|
end
|
|
|
|
test "transaction count represents filtered total" do
|
|
get transactions_url
|
|
assert_dom "#total-transactions", count: 1, text: @user.family.transactions.count.to_s
|
|
|
|
new_transaction = @user.family.accounts.first.transactions.create! \
|
|
name: "Transaction to search for",
|
|
date: Date.current,
|
|
amount: 0
|
|
|
|
get transactions_url(q: { search: new_transaction.name })
|
|
|
|
# Only finds 1 transaction that matches filter
|
|
assert_dom "#" + dom_id(new_transaction), count: 1
|
|
assert_dom "#total-transactions", count: 1, text: "1"
|
|
end
|
|
|
|
test "can navigate to paginated result" do
|
|
get transactions_url(page: 2)
|
|
assert_response :success
|
|
|
|
@recent_transactions[10, 10].each do |transaction|
|
|
assert_dom "#" + dom_id(transaction), count: 1
|
|
end
|
|
end
|
|
|
|
test "loads last page when page is out of range" do
|
|
user_oldest_transaction = @user.family.transactions.ordered.last
|
|
get transactions_url(page: 9999999999)
|
|
|
|
assert_response :success
|
|
assert_dom "#" + dom_id(user_oldest_transaction), count: 1
|
|
end
|
|
|
|
test "should get new" do
|
|
get new_transaction_url
|
|
assert_response :success
|
|
end
|
|
|
|
test "prefills account_id if provided" do
|
|
get new_transaction_url(account_id: @transaction.account_id)
|
|
assert_response :success
|
|
assert_select "option[selected][value='#{@transaction.account_id}']"
|
|
end
|
|
|
|
test "should create transaction" do
|
|
account = @user.family.accounts.first
|
|
transaction_params = {
|
|
account_id: account.id,
|
|
amount: 100.45,
|
|
currency: "USD",
|
|
date: Date.current,
|
|
name: "Test transaction"
|
|
}
|
|
|
|
assert_difference("Transaction.count") do
|
|
post transactions_url, params: { transaction: transaction_params }
|
|
end
|
|
|
|
assert_equal transaction_params[:amount].to_d, Transaction.order(created_at: :desc).first.amount
|
|
assert_equal flash[:notice], "New transaction created successfully"
|
|
assert_enqueued_with(job: AccountSyncJob)
|
|
assert_redirected_to transactions_url
|
|
end
|
|
|
|
test "expenses are positive" do
|
|
assert_difference("Transaction.count") do
|
|
post transactions_url, params: { transaction: {
|
|
nature: "expense",
|
|
account_id: @transaction.account_id,
|
|
amount: @transaction.amount,
|
|
currency: @transaction.currency,
|
|
date: @transaction.date,
|
|
name: @transaction.name } }
|
|
end
|
|
|
|
assert_redirected_to transactions_url
|
|
assert Transaction.order(created_at: :desc).first.amount.positive?, "Amount should be positive"
|
|
end
|
|
|
|
test "incomes are negative" do
|
|
assert_difference("Transaction.count") do
|
|
post transactions_url, params: { transaction: {
|
|
nature: "income",
|
|
account_id: @transaction.account_id,
|
|
amount: @transaction.amount,
|
|
currency: @transaction.currency,
|
|
date: @transaction.date,
|
|
name: @transaction.name } }
|
|
end
|
|
|
|
assert_redirected_to transactions_url
|
|
assert Transaction.order(created_at: :desc).first.amount.negative?, "Amount should be negative"
|
|
end
|
|
|
|
test "should show transaction" do
|
|
get transaction_url(@transaction)
|
|
assert_response :success
|
|
end
|
|
|
|
test "should update transaction" do
|
|
patch transaction_url(@transaction), params: {
|
|
transaction: {
|
|
account_id: @transaction.account_id,
|
|
amount: @transaction.amount,
|
|
currency: @transaction.currency,
|
|
date: @transaction.date,
|
|
name: @transaction.name
|
|
}
|
|
}
|
|
|
|
assert_redirected_to transaction_url(@transaction)
|
|
assert_enqueued_with(job: AccountSyncJob)
|
|
end
|
|
|
|
test "should destroy transaction" do
|
|
assert_difference("Transaction.count", -1) do
|
|
delete transaction_url(@transaction)
|
|
end
|
|
|
|
assert_redirected_to transactions_url
|
|
assert_enqueued_with(job: AccountSyncJob)
|
|
end
|
|
end
|