mirror of
https://github.com/maybe-finance/maybe.git
synced 2025-07-18 20:59:39 +02:00
1aae00f586
* add kind to transaction model * Basic transfer creator * Fix method naming conflict * Creator form pattern * Remove stale methods * Tweak migration * Remove BaseQuery, write entire query in each class for clarity * Query optimizations * Remove unused exchange rate query lines * Remove temporary cache-warming strategy * Fix test * Update transaction search * Decouple transactions endpoint from IncomeStatement * Clean up transactions controller * Update cursor rules * Cleanup comments, logic in search * Fix totals logic on transactions view * Fix pagination * Optimize search totals query * Default to last 30 days on transactions page if no filters * Decouple transactions list from transfer details * Revert transfer route * Migration reset * Bundle update * Fix matching logic, tests * Remove unused code
64 lines
2.9 KiB
Ruby
64 lines
2.9 KiB
Ruby
module Family::AutoTransferMatchable
|
|
def transfer_match_candidates
|
|
Entry.select([
|
|
"inflow_candidates.entryable_id as inflow_transaction_id",
|
|
"outflow_candidates.entryable_id as outflow_transaction_id",
|
|
"ABS(inflow_candidates.date - outflow_candidates.date) as date_diff"
|
|
]).from("entries inflow_candidates")
|
|
.joins("
|
|
JOIN entries outflow_candidates ON (
|
|
inflow_candidates.amount < 0 AND
|
|
outflow_candidates.amount > 0 AND
|
|
inflow_candidates.amount = -outflow_candidates.amount AND
|
|
inflow_candidates.currency = outflow_candidates.currency AND
|
|
inflow_candidates.account_id <> outflow_candidates.account_id AND
|
|
inflow_candidates.date BETWEEN outflow_candidates.date - 4 AND outflow_candidates.date + 4
|
|
)
|
|
").joins("
|
|
LEFT JOIN transfers existing_transfers ON (
|
|
existing_transfers.inflow_transaction_id = inflow_candidates.entryable_id OR
|
|
existing_transfers.outflow_transaction_id = outflow_candidates.entryable_id
|
|
)
|
|
")
|
|
.joins("LEFT JOIN rejected_transfers ON (
|
|
rejected_transfers.inflow_transaction_id = inflow_candidates.entryable_id AND
|
|
rejected_transfers.outflow_transaction_id = outflow_candidates.entryable_id
|
|
)")
|
|
.joins("JOIN accounts inflow_accounts ON inflow_accounts.id = inflow_candidates.account_id")
|
|
.joins("JOIN accounts outflow_accounts ON outflow_accounts.id = outflow_candidates.account_id")
|
|
.where("inflow_accounts.family_id = ? AND outflow_accounts.family_id = ?", self.id, self.id)
|
|
.where("inflow_accounts.is_active = true")
|
|
.where("outflow_accounts.is_active = true")
|
|
.where("inflow_candidates.entryable_type = 'Transaction' AND outflow_candidates.entryable_type = 'Transaction'")
|
|
.where(existing_transfers: { id: nil })
|
|
.order("date_diff ASC") # Closest matches first
|
|
end
|
|
|
|
def auto_match_transfers!
|
|
# Exclude already matched transfers
|
|
candidates_scope = transfer_match_candidates.where(rejected_transfers: { id: nil })
|
|
|
|
# Track which transactions we've already matched to avoid duplicates
|
|
used_transaction_ids = Set.new
|
|
|
|
candidates = []
|
|
|
|
Transfer.transaction do
|
|
candidates_scope.each do |match|
|
|
next if used_transaction_ids.include?(match.inflow_transaction_id) ||
|
|
used_transaction_ids.include?(match.outflow_transaction_id)
|
|
|
|
Transfer.create!(
|
|
inflow_transaction_id: match.inflow_transaction_id,
|
|
outflow_transaction_id: match.outflow_transaction_id,
|
|
)
|
|
|
|
Transaction.find(match.inflow_transaction_id).update!(kind: "funds_movement")
|
|
Transaction.find(match.outflow_transaction_id).update!(kind: Transfer.kind_for_account(Transaction.find(match.outflow_transaction_id).entry.account))
|
|
|
|
used_transaction_ids << match.inflow_transaction_id
|
|
used_transaction_ids << match.outflow_transaction_id
|
|
end
|
|
end
|
|
end
|
|
end
|