mirror of
https://github.com/maybe-finance/maybe.git
synced 2025-07-19 05:09:38 +02:00
* Add auto-update strategies for current balance on manual accounts * Remove deprecated BalanceUpdater, replace with new methods
102 lines
4 KiB
Ruby
102 lines
4 KiB
Ruby
require "test_helper"
|
|
|
|
class Account::ReconciliationManagerTest < ActiveSupport::TestCase
|
|
setup do
|
|
@account = accounts(:investment)
|
|
@manager = Account::ReconciliationManager.new(@account)
|
|
end
|
|
|
|
test "new reconciliation" do
|
|
@account.balances.create!(
|
|
date: Date.current,
|
|
balance: 1000,
|
|
cash_balance: 500,
|
|
currency: @account.currency
|
|
)
|
|
|
|
result = @manager.reconcile_balance(balance: 1200, date: Date.current)
|
|
|
|
assert_equal 1200, result.new_balance
|
|
assert_equal 700, result.new_cash_balance # Non cash stays the same since user is valuing the entire account balance
|
|
assert_equal 1000, result.old_balance
|
|
assert_equal 500, result.old_cash_balance
|
|
assert_equal true, result.success?
|
|
end
|
|
|
|
test "updates existing reconciliation without date change" do
|
|
@account.balances.create!(date: Date.current, balance: 1000, cash_balance: 500, currency: @account.currency)
|
|
|
|
# Existing reconciliation entry
|
|
existing_entry = @account.entries.create!(name: "Test", amount: 1000, date: Date.current, entryable: Valuation.new(kind: "reconciliation"), currency: @account.currency)
|
|
|
|
result = @manager.reconcile_balance(balance: 1200, date: Date.current, existing_valuation_entry: existing_entry)
|
|
|
|
assert_equal 1200, result.new_balance
|
|
assert_equal 700, result.new_cash_balance # Non cash stays the same since user is valuing the entire account balance
|
|
assert_equal 1000, result.old_balance
|
|
assert_equal 500, result.old_cash_balance
|
|
assert_equal true, result.success?
|
|
end
|
|
|
|
test "updates existing reconciliation with date and amount change" do
|
|
@account.balances.create!(date: 5.days.ago, balance: 1000, cash_balance: 500, currency: @account.currency)
|
|
@account.balances.create!(date: Date.current, balance: 1200, cash_balance: 700, currency: @account.currency)
|
|
|
|
# Existing reconciliation entry (5 days ago)
|
|
existing_entry = @account.entries.create!(name: "Test", amount: 1000, date: 5.days.ago, entryable: Valuation.new(kind: "reconciliation"), currency: @account.currency)
|
|
|
|
# Should update and change date for existing entry; not create a new one
|
|
assert_no_difference "Valuation.count" do
|
|
# "Update valuation from 5 days ago to today, set balance from 1000 to 1500"
|
|
result = @manager.reconcile_balance(balance: 1500, date: Date.current, existing_valuation_entry: existing_entry)
|
|
|
|
assert_equal true, result.success?
|
|
|
|
# Reconciliation
|
|
assert_equal 1500, result.new_balance # Equal to new valuation amount
|
|
assert_equal 1000, result.new_cash_balance # Get non-cash balance today (1200 - 700 = 500). Then subtract this from new valuation (1500 - 500 = 1000)
|
|
|
|
# Prior valuation
|
|
assert_equal 1000, result.old_balance # This is the balance from the old valuation, NOT the date we're reconciling to
|
|
assert_equal 500, result.old_cash_balance
|
|
end
|
|
end
|
|
|
|
test "handles date conflicts" do
|
|
@account.balances.create!(
|
|
date: Date.current,
|
|
balance: 1000,
|
|
cash_balance: 1000,
|
|
currency: @account.currency
|
|
)
|
|
|
|
# Existing reconciliation entry
|
|
@account.entries.create!(
|
|
name: "Test",
|
|
amount: 1000,
|
|
date: Date.current,
|
|
entryable: Valuation.new(kind: "reconciliation"),
|
|
currency: @account.currency
|
|
)
|
|
|
|
# Doesn't pass existing_valuation_entry, but reconciliation manager should recognize its the same date and update the existing entry
|
|
assert_no_difference "Valuation.count" do
|
|
result = @manager.reconcile_balance(balance: 1200, date: Date.current)
|
|
|
|
assert result.success?
|
|
assert_equal 1200, result.new_balance
|
|
end
|
|
end
|
|
|
|
test "dry run does not persist account" do
|
|
@account.balances.create!(date: Date.current, balance: 1000, cash_balance: 500, currency: @account.currency)
|
|
|
|
assert_no_difference "Valuation.count" do
|
|
@manager.reconcile_balance(balance: 1200, date: Date.current, dry_run: true)
|
|
end
|
|
|
|
assert_difference "Valuation.count", 1 do
|
|
@manager.reconcile_balance(balance: 1200, date: Date.current)
|
|
end
|
|
end
|
|
end
|