mirror of
https://github.com/maybe-finance/maybe.git
synced 2025-07-19 05:09:38 +02:00
6f67827f14
- Added rescue blocks to handle exceptions in the Accounts and AccountableSparklines controllers, logging errors and rendering error partials. - Enhanced error handling in the Account::Chartable and Balance::ChartSeriesBuilder models, logging specific error messages for series generation failures. - Updated the accounts view to include a timeout for Turbo frame loading. - Added a test to ensure graceful handling of sparkline errors in the AccountsController. In reference to bug #2315
33 lines
940 B
Ruby
33 lines
940 B
Ruby
class AccountableSparklinesController < ApplicationController
|
|
def show
|
|
@accountable = Accountable.from_type(params[:accountable_type]&.classify)
|
|
|
|
@series = Rails.cache.fetch(cache_key) do
|
|
account_ids = family.accounts.active.where(accountable_type: @accountable.name).pluck(:id)
|
|
|
|
builder = Balance::ChartSeriesBuilder.new(
|
|
account_ids: account_ids,
|
|
currency: family.currency,
|
|
period: Period.last_30_days,
|
|
favorable_direction: @accountable.favorable_direction,
|
|
interval: "1 day"
|
|
)
|
|
|
|
builder.balance_series
|
|
end
|
|
|
|
render layout: false
|
|
rescue => e
|
|
Rails.logger.error "Accountable sparkline error for #{@accountable&.name}: #{e.message}"
|
|
render partial: "accountable_sparklines/error", layout: false
|
|
end
|
|
|
|
private
|
|
def family
|
|
Current.family
|
|
end
|
|
|
|
def cache_key
|
|
family.build_cache_key("#{@accountable.name}_sparkline")
|
|
end
|
|
end
|