mirror of
https://github.com/maybe-finance/maybe.git
synced 2025-07-19 13:19:39 +02:00
297a695d0f
* Domain model sketch
* Scaffold out rules domain
* Migrations
* Remove existing data enrichment for clean slate
* Sketch out business logic and basic tests
* Simplify rule scope building and action executions
* Get generator working again
* Basic implementation + tests
* Remove manual merchant management (rules will replace)
* Revert "Remove manual merchant management (rules will replace)"
This reverts commit 83dcbd9ff0.
* Family and Provider merchants model
* Fix brakeman warnings
* Fix notification loader
* Update notification position
* Add Rule action and condition registries
* Rule form with compound conditions and tests
* Split out notification types, add CTA type
* Rules form builder and Stimulus controller
* Clean up rule registry domain
* Clean up rules stimulus controller
* CTA message for rule when user changes transaction category
* Fix tests
* Lint updates
* Centralize notifications in Notifiable concern
* Implement category rule prompts with auto backoff and option to disable
* Fix layout bug caused by merge conflict
* Initialize rule with correct action for category CTA
* Add rule deletions, get rules working
* Complete dynamic rule form, split Stimulus controllers by resource
* Fix failing tests
* Change test password to avoid chromium conflicts
* Update integration tests
* Centralize all test password references
* Add re-apply rule action
* Rule confirm modal
* Run migrations
* Trigger rule notification after inline category updates
* Clean up rule styles
* Basic attribute locking for rules
* Apply attribute locks on user edits
* Log data enrichments, only apply rules to unlocked attributes
* Fix merge errors
* Additional merge conflict fixes
* Form UI improvements, ignore attribute locks on manual rule application
* Batch AI auto-categorization of transactions
* Auto merchant detection, ai enrichment in batches
* Fix Plaid merchant assignments
* Plaid category matching
* Cleanup 1
* Test cleanup
* Remove stale route
* Fix desktop chat UI issues
* Fix mobile nav styling issues
77 lines
3 KiB
Ruby
77 lines
3 KiB
Ruby
require "test_helper"
|
|
|
|
class RuleTest < ActiveSupport::TestCase
|
|
include EntriesTestHelper
|
|
|
|
setup do
|
|
@family = families(:empty)
|
|
@account = @family.accounts.create!(name: "Rule test", balance: 1000, currency: "USD", accountable: Depository.new)
|
|
@whole_foods_merchant = @family.merchants.create!(name: "Whole Foods", type: "FamilyMerchant")
|
|
@groceries_category = @family.categories.create!(name: "Groceries")
|
|
end
|
|
|
|
test "basic rule" do
|
|
transaction_entry = create_transaction(date: Date.current, account: @account, merchant: @whole_foods_merchant)
|
|
|
|
rule = Rule.create!(
|
|
family: @family,
|
|
resource_type: "transaction",
|
|
effective_date: 1.day.ago.to_date,
|
|
conditions: [ Rule::Condition.new(condition_type: "transaction_merchant", operator: "=", value: @whole_foods_merchant.id) ],
|
|
actions: [ Rule::Action.new(action_type: "set_transaction_category", value: @groceries_category.id) ]
|
|
)
|
|
|
|
rule.apply
|
|
|
|
transaction_entry.reload
|
|
|
|
assert_equal @groceries_category, transaction_entry.transaction.category
|
|
end
|
|
|
|
test "compound rule" do
|
|
transaction_entry1 = create_transaction(date: Date.current, amount: 50, account: @account, merchant: @whole_foods_merchant)
|
|
transaction_entry2 = create_transaction(date: Date.current, amount: 100, account: @account, merchant: @whole_foods_merchant)
|
|
|
|
# Assign "Groceries" to transactions with a merchant of "Whole Foods" and an amount greater than $60
|
|
rule = Rule.create!(
|
|
family: @family,
|
|
resource_type: "transaction",
|
|
effective_date: 1.day.ago.to_date,
|
|
conditions: [
|
|
Rule::Condition.new(condition_type: "compound", operator: "and", sub_conditions: [
|
|
Rule::Condition.new(condition_type: "transaction_merchant", operator: "=", value: @whole_foods_merchant.id),
|
|
Rule::Condition.new(condition_type: "transaction_amount", operator: ">", value: 60)
|
|
])
|
|
],
|
|
actions: [ Rule::Action.new(action_type: "set_transaction_category", value: @groceries_category.id) ]
|
|
)
|
|
|
|
rule.apply
|
|
|
|
transaction_entry1.reload
|
|
transaction_entry2.reload
|
|
|
|
assert_nil transaction_entry1.transaction.category
|
|
assert_equal @groceries_category, transaction_entry2.transaction.category
|
|
end
|
|
|
|
# Artificial limitation put in place to prevent users from creating overly complex rules
|
|
# Rules should be shallow and wide
|
|
test "no nested compound conditions" do
|
|
rule = Rule.new(
|
|
family: @family,
|
|
resource_type: "transaction",
|
|
actions: [ Rule::Action.new(action_type: "set_transaction_category", value: @groceries_category.id) ],
|
|
conditions: [
|
|
Rule::Condition.new(condition_type: "compound", operator: "and", sub_conditions: [
|
|
Rule::Condition.new(condition_type: "compound", operator: "and", sub_conditions: [
|
|
Rule::Condition.new(condition_type: "transaction_name", operator: "=", value: "Starbucks")
|
|
])
|
|
])
|
|
]
|
|
)
|
|
|
|
assert_not rule.valid?
|
|
assert_equal [ "Compound conditions cannot be nested" ], rule.errors.full_messages
|
|
end
|
|
end
|