1
0
Fork 0
mirror of https://github.com/maybe-finance/maybe.git synced 2025-07-24 15:49:39 +02:00
Maybe/app/controllers/concerns
Josh Pigford b803ddac96
Add comprehensive API v1 with OAuth and API key authentication (#2389)
* OAuth

* Add API test routes and update Doorkeeper token handling for test environment

- Introduced API namespace with test routes for controller testing in the test environment.
- Updated Doorkeeper configuration to allow fallback to plain tokens in the test environment for easier testing.
- Modified schema to change resource_owner_id type from bigint to string.

* Implement API key authentication and enhance access control

- Replaced Doorkeeper OAuth authentication with a custom method supporting both OAuth and API keys in the BaseController.
- Added methods for API key authentication, including validation and logging.
- Introduced scope-based authorization for API keys in the TestController.
- Updated routes to include API key management endpoints.
- Enhanced logging for API access to include authentication method details.
- Added tests for API key functionality, including validation, scope checks, and access control enforcement.

* Add API key rate limiting and usage tracking

- Implemented rate limiting for API key authentication in BaseController.
- Added methods to check rate limits, render appropriate responses, and include rate limit headers in responses.
- Updated routes to include a new usage resource for tracking API usage.
- Enhanced tests to verify rate limit functionality, including exceeding limits and per-key tracking.
- Cleaned up Redis data in tests to ensure isolation between test cases.

* Add Jbuilder for JSON rendering and refactor AccountsController

- Added Jbuilder gem for improved JSON response handling.
- Refactored index action in AccountsController to utilize Jbuilder for rendering JSON.
- Removed manual serialization of accounts and streamlined response structure.
- Implemented a before_action in BaseController to enforce JSON format for all API requests.

* Add transactions resource to API routes

- Added routes for transactions, allowing index, show, create, update, and destroy actions.
- This enhancement supports comprehensive transaction management within the API.

* Enhance API authentication and onboarding handling

- Updated BaseController to skip onboarding requirements for API endpoints and added manual token verification for OAuth authentication.
- Improved error handling and logging for invalid access tokens.
- Introduced a method to set up the current context for API requests, ensuring compatibility with session-like behavior.
- Excluded API paths from onboarding redirects in the Onboardable concern.
- Updated database schema to change resource_owner_id type from bigint to string for OAuth access grants.

* Fix rubocop offenses

- Fix indentation and spacing issues
- Convert single quotes to double quotes
- Add spaces inside array brackets
- Fix comment alignment
- Add missing trailing newlines
- Correct else/end alignment

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Fix API test failures and improve test reliability

- Fix ApiRateLimiterTest by removing mock users method and using fixtures
- Fix UsageControllerTest by removing mock users method and using fixtures
- Fix BaseControllerTest by using different users for multiple API keys
- Use unique display_key values with SecureRandom to avoid conflicts
- Fix double render issue in UsageController by returning after authorize_scope\!
- Specify controller name in routes for usage resource
- Remove trailing whitespace and empty lines per Rubocop

All tests now pass and linting is clean.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Add API transactions controller warning to brakeman ignore

The account_id parameter in the API transactions controller is properly
validated on line 79: family.accounts.find(transaction_params[:account_id])
This ensures users can only create transactions in accounts belonging to
their family, making this a false positive.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Signed-off-by: Josh Pigford <josh@joshpigford.com>
Co-authored-by: Claude <noreply@anthropic.com>
2025-06-17 15:57:05 -05:00
..
accountable_resource.rb Lazy load Plaid link tokens, fix link issues on broadcast (#2302) 2025-05-25 08:12:54 -04:00
authentication.rb Logger cleanup 2025-03-05 13:44:56 -06:00
auto_sync.rb Comment out auto-sync callback in AutoSync concern to disable family synchronization temporarily. 2025-06-01 06:17:11 -05:00
breadcrumbable.rb Add breadcrumbs support across application (#1897) 2025-02-25 10:14:07 -06:00
entryable_resource.rb Account:: namespace simplifications and cleanup (#2110) 2025-04-14 11:40:34 -04:00
feature_guardable.rb Personal finance AI (v1) (#2022) 2025-03-28 13:08:22 -04:00
impersonatable.rb Impersonation (#1325) 2024-10-18 11:26:58 -05:00
invitable.rb Family invites (#1397) 2024-11-01 10:23:27 -05:00
localize.rb Plaid portfolio sync algorithm and calculation improvements (#1526) 2024-12-10 17:41:20 -05:00
notifiable.rb Improve account sync performance, handle concurrent market data syncing (#2236) 2025-05-15 10:19:56 -04:00
onboardable.rb Add comprehensive API v1 with OAuth and API key authentication (#2389) 2025-06-17 15:57:05 -05:00
periodable.rb Preference to set default_period (#1941) 2025-03-07 10:05:54 -05:00
restore_layout_preferences.rb Improve account sync performance, handle concurrent market data syncing (#2236) 2025-05-15 10:19:56 -04:00
scroll_focusable.rb Preserve transaction filters and transaction focus across page visits (#1733) 2025-01-30 14:12:01 -05:00
self_hostable.rb Redis check for self hosted apps (#2353) 2025-06-09 18:30:52 -04:00
store_location.rb Make encryption config optional for self hosting users (#1476) 2024-11-18 10:47:05 -05:00
stream_extensions.rb Account:: namespace simplifications and cleanup (#2110) 2025-04-14 11:40:34 -04:00