1
0
Fork 0
mirror of https://github.com/maybe-finance/maybe.git synced 2025-07-24 15:49:39 +02:00
Maybe/app/controllers
Josh Pigford b803ddac96
Add comprehensive API v1 with OAuth and API key authentication (#2389)
* OAuth

* Add API test routes and update Doorkeeper token handling for test environment

- Introduced API namespace with test routes for controller testing in the test environment.
- Updated Doorkeeper configuration to allow fallback to plain tokens in the test environment for easier testing.
- Modified schema to change resource_owner_id type from bigint to string.

* Implement API key authentication and enhance access control

- Replaced Doorkeeper OAuth authentication with a custom method supporting both OAuth and API keys in the BaseController.
- Added methods for API key authentication, including validation and logging.
- Introduced scope-based authorization for API keys in the TestController.
- Updated routes to include API key management endpoints.
- Enhanced logging for API access to include authentication method details.
- Added tests for API key functionality, including validation, scope checks, and access control enforcement.

* Add API key rate limiting and usage tracking

- Implemented rate limiting for API key authentication in BaseController.
- Added methods to check rate limits, render appropriate responses, and include rate limit headers in responses.
- Updated routes to include a new usage resource for tracking API usage.
- Enhanced tests to verify rate limit functionality, including exceeding limits and per-key tracking.
- Cleaned up Redis data in tests to ensure isolation between test cases.

* Add Jbuilder for JSON rendering and refactor AccountsController

- Added Jbuilder gem for improved JSON response handling.
- Refactored index action in AccountsController to utilize Jbuilder for rendering JSON.
- Removed manual serialization of accounts and streamlined response structure.
- Implemented a before_action in BaseController to enforce JSON format for all API requests.

* Add transactions resource to API routes

- Added routes for transactions, allowing index, show, create, update, and destroy actions.
- This enhancement supports comprehensive transaction management within the API.

* Enhance API authentication and onboarding handling

- Updated BaseController to skip onboarding requirements for API endpoints and added manual token verification for OAuth authentication.
- Improved error handling and logging for invalid access tokens.
- Introduced a method to set up the current context for API requests, ensuring compatibility with session-like behavior.
- Excluded API paths from onboarding redirects in the Onboardable concern.
- Updated database schema to change resource_owner_id type from bigint to string for OAuth access grants.

* Fix rubocop offenses

- Fix indentation and spacing issues
- Convert single quotes to double quotes
- Add spaces inside array brackets
- Fix comment alignment
- Add missing trailing newlines
- Correct else/end alignment

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Fix API test failures and improve test reliability

- Fix ApiRateLimiterTest by removing mock users method and using fixtures
- Fix UsageControllerTest by removing mock users method and using fixtures
- Fix BaseControllerTest by using different users for multiple API keys
- Use unique display_key values with SecureRandom to avoid conflicts
- Fix double render issue in UsageController by returning after authorize_scope\!
- Specify controller name in routes for usage resource
- Remove trailing whitespace and empty lines per Rubocop

All tests now pass and linting is clean.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Add API transactions controller warning to brakeman ignore

The account_id parameter in the API transactions controller is properly
validated on line 79: family.accounts.find(transaction_params[:account_id])
This ensures users can only create transactions in accounts belonging to
their family, making this a false positive.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Signed-off-by: Josh Pigford <josh@joshpigford.com>
Co-authored-by: Claude <noreply@anthropic.com>
2025-06-17 15:57:05 -05:00
..
api/v1 Add comprehensive API v1 with OAuth and API key authentication (#2389) 2025-06-17 15:57:05 -05:00
category New Design System + Codebase Refresh (#1823) 2025-02-21 11:57:59 -05:00
concerns Add comprehensive API v1 with OAuth and API key authentication (#2389) 2025-06-17 15:57:05 -05:00
import Feature: Add "amount type" configuration column for CSV imports (#1947) 2025-04-18 10:48:10 -04:00
settings Add comprehensive API v1 with OAuth and API key authentication (#2389) 2025-06-17 15:57:05 -05:00
tag New Design System + Codebase Refresh (#1823) 2025-02-21 11:57:59 -05:00
transactions Account:: namespace simplifications and cleanup (#2110) 2025-04-14 11:40:34 -04:00
accountable_sparklines_controller.rb Balance sheet cache layer, non-blocking sync UI (#2356) 2025-06-10 18:20:06 -04:00
accounts_controller.rb Balance sheet cache layer, non-blocking sync UI (#2356) 2025-06-10 18:20:06 -04:00
application_controller.rb Improve account sync performance, handle concurrent market data syncing (#2236) 2025-05-15 10:19:56 -04:00
budget_categories_controller.rb Account:: namespace simplifications and cleanup (#2110) 2025-04-14 11:40:34 -04:00
budgets_controller.rb Add breadcrumbs support across application (#1897) 2025-02-25 10:14:07 -06:00
categories_controller.rb Transaction rules engine V1 (#1900) 2025-04-18 11:39:58 -04:00
chats_controller.rb Pre-launch design sync with Figma spec (#2154) 2025-04-30 18:14:22 -04:00
cookie_sessions_controller.rb Improve account sync performance, handle concurrent market data syncing (#2236) 2025-05-15 10:19:56 -04:00
credit_cards_controller.rb Account Activity View + Account Forms (#1406) 2024-11-04 20:27:31 -05:00
cryptos_controller.rb Account Activity View + Account Forms (#1406) 2024-11-04 20:27:31 -05:00
currencies_controller.rb More composable forms (#989) 2024-07-16 14:08:24 -04:00
current_sessions_controller.rb Improve account sync performance, handle concurrent market data syncing (#2236) 2025-05-15 10:19:56 -04:00
depositories_controller.rb Account Activity View + Account Forms (#1406) 2024-11-04 20:27:31 -05:00
email_confirmations_controller.rb Allow users to update their email address (#1745) 2025-01-31 11:29:49 -06:00
family_merchants_controller.rb Fix merchant editing (#2349) 2025-06-09 10:50:56 -04:00
holdings_controller.rb Account:: namespace simplifications and cleanup (#2110) 2025-04-14 11:40:34 -04:00
impersonation_sessions_controller.rb Impersonation (#1325) 2024-10-18 11:26:58 -05:00
imports_controller.rb Auto sync preference, max limit on account CSV imports (#2259) 2025-05-18 15:02:51 -04:00
investments_controller.rb Account Activity View + Account Forms (#1406) 2024-11-04 20:27:31 -05:00
invitations_controller.rb Add/remove members and invitations (#1744) 2025-01-30 13:13:37 -06:00
invite_codes_controller.rb fix: Only admins can generate invite codes (#1611) 2025-01-23 20:47:51 -05:00
loans_controller.rb loan: Set the first valuation as the original principal. (#2088) 2025-04-14 09:09:25 -04:00
lookbooks_controller.rb Pre-launch design sync with Figma spec (#2154) 2025-04-30 18:14:22 -04:00
messages_controller.rb Personal finance AI (v1) (#2022) 2025-03-28 13:08:22 -04:00
mfa_controller.rb Logger cleanup 2025-03-05 13:44:56 -06:00
onboardings_controller.rb Onboarding redirect tests and trial status bar (#2197) 2025-05-02 15:21:46 -04:00
other_assets_controller.rb Account Activity View + Account Forms (#1406) 2024-11-04 20:27:31 -05:00
other_liabilities_controller.rb Account Activity View + Account Forms (#1406) 2024-11-04 20:27:31 -05:00
pages_controller.rb Redis check for self hosted apps (#2353) 2025-06-09 18:30:52 -04:00
password_resets_controller.rb Improve password reset flow, normalize translations 2024-11-05 17:15:29 -05:00
passwords_controller.rb Rubocop updates (#1118) 2024-08-23 10:06:24 -04:00
plaid_items_controller.rb Lazy load Plaid link tokens, fix link issues on broadcast (#2302) 2025-05-25 08:12:54 -04:00
properties_controller.rb Basic Plaid Integration (#1433) 2024-11-15 13:49:37 -05:00
registrations_controller.rb Feature: Implement Mobile Responsiveness (#2092) 2025-04-18 08:23:10 -05:00
rules_controller.rb Improve rules - add name, allow sorting, improve UI (#2177) 2025-05-13 15:53:13 -04:00
securities_controller.rb Data provider simplification, tests, and documentation (#1997) 2025-03-17 11:54:53 -04:00
sessions_controller.rb Logger cleanup 2025-03-05 13:44:56 -06:00
subscriptions_controller.rb Subscription tests and domain (#2209) 2025-05-06 14:05:21 -04:00
tags_controller.rb Add ability to delete all tags (#2200) 2025-05-05 12:43:46 -04:00
trades_controller.rb Transaction rules engine V1 (#1900) 2025-04-18 11:39:58 -04:00
transaction_categories_controller.rb Transaction rules engine V1 (#1900) 2025-04-18 11:39:58 -04:00
transactions_controller.rb Temporary transactions page performance fix (#2372) 2025-06-15 11:36:21 -04:00
transfer_matches_controller.rb Account:: namespace simplifications and cleanup (#2110) 2025-04-14 11:40:34 -04:00
transfers_controller.rb Fix: Fix unalble to reject automatched transfers (#2102) 2025-04-14 09:05:25 -04:00
users_controller.rb New onboarding, trials, Stripe integration (#2185) 2025-05-01 16:47:14 -04:00
valuations_controller.rb Transaction rules engine V1 (#1900) 2025-04-18 11:39:58 -04:00
vehicles_controller.rb Account Activity View + Account Forms (#1406) 2024-11-04 20:27:31 -05:00
webhooks_controller.rb Plaid webhook processor 2025-05-24 18:33:59 -04:00